1
0
mirror of https://github.com/rkd77/elinks.git synced 2024-09-15 00:58:24 -04:00
elinks/src
Kalle Olavi Niemitalo 84e19d0e4e bug 1054: Don't abort downloads when closing a terminal.
Except if they have external handlers.

When ELinks receives an event from a terminal, move that terminal to
the beginning of the global "terminals" list, so that the terminals
are always sorted according to the time of the most recent use.  Note,
this affects the numbering of bookmark folders in session snapshots.

Add get_default_terminal(), which returns the most recently used
terminal that is still open.  Use that in various places that
previously used terminals.prev or terminals.next.  Four functions
fetch the size of the terminal for User-Agent headers, and
get_default_terminal() is not really right, but neither was the
original code; add TODO comments in those functions.

When the user chooses "Background and Notify", associate the download
with the terminal where the dialog box is.  So any later messages will
then appear in that terminal, if it is still open.  However, don't
change the terminal if the download has an external handler.

When a download gets some data, don't immediately check the associated
terminal.  Instead, wait for the download to end.  Then, if the
terminal of the download has been closed, use get_default_terminal()
instead.  If there is no default terminal either, just skip any
message boxes.
2008-10-15 23:29:25 +03:00
..
bfu Adjust LED update interval according to need 2008-08-02 03:34:51 +00:00
bookmarks get_opt_*: Add ses parameter 2007-08-28 17:24:59 +00:00
cache Rename cache_entry.id and related members. 2008-08-03 21:27:56 +03:00
config Merge branch 'elinks-0.12' into elinks-0.13 2008-04-28 22:08:19 +03:00
cookies Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
dialogs bug 1054: Don't abort downloads when closing a terminal. 2008-10-15 23:29:25 +03:00
document Update document.comb_x and comb_y when splitting lines. 2008-09-14 17:29:39 +03:00
dom Merge branch 'elinks-0.12' into elinks-0.13 2008-07-11 22:28:45 +03:00
ecmascript bug 1054: Don't abort downloads when closing a terminal. 2008-10-15 23:29:25 +03:00
encoding Merge branch 'elinks-0.12' into elinks-0.13 2008-08-03 22:18:53 +03:00
formhist 1045: fix "void function cannot return value" in formhist 2008-09-15 23:43:52 +03:00
globhist Revert a change that was mistakenly included in the last commit 2008-07-11 11:12:37 +00:00
intl Merge branch 'elinks-0.12' into elinks-0.13 2008-02-03 22:30:46 +02:00
main Merge branch 'elinks-0.12' into elinks-0.13 2008-09-27 16:28:28 +03:00
mime Merge branch 'elinks-0.12' into elinks-0.13 2008-06-15 21:43:08 +03:00
network Merge branch 'elinks-0.12' into elinks-0.13 2008-10-04 15:17:11 +03:00
osdep Add newlines to some function signatures to comply with style standards 2008-07-08 07:06:31 +00:00
protocol bug 1054: Don't abort downloads when closing a terminal. 2008-10-15 23:29:25 +03:00
scripting bug 1054: Don't abort downloads when closing a terminal. 2008-10-15 23:29:25 +03:00
session bug 1054: Don't abort downloads when closing a terminal. 2008-10-15 23:29:25 +03:00
terminal bug 1054: Don't abort downloads when closing a terminal. 2008-10-15 23:29:25 +03:00
util 1008: Centralize random numbers. 2008-05-25 18:44:21 +03:00
viewer Merge branch 'elinks-0.12' into elinks-0.13 2008-08-03 22:18:53 +03:00
.gitignore Ignore tags file 2007-08-08 14:25:38 +02:00
elinks.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
Makefile BUILD_ID: Fix dirt check when srcdir != builddir. 2008-03-01 14:30:57 +02:00
README Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
setup.h Make copyright info independent from translations. 2007-10-03 11:53:09 +02:00
vernum.c Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
vernum.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00

				  The Big View

The whole dependency tree is supposed (in ideal world) to look somewhat like
the following. Please note that this deals only with the core parts of ELinks,
not extensions like bookmarks, cookies, globhist, mime etc. Those act like
modules and are generally self-contained - the main visible difference is that
they don't have their UI stuff in dialogs/foo.c but in foo/dialogs.c.

Note also that it isn't all that clean-cut as it looks. Some parts of e.g.
lowlevel/ or osdep/ are omnipresent as well and it's meant to be so (at least
for now). Also some other exceptions are possible; the exception to this is
util/, where no exceptions are permitted - it must have no dependencies to the
rest of the code whatsoever, not even compile-time ones. The other way around,
the gettext part of intl/ is generally omnipresent but the charset part is
pretty isolated - it could be probably drawn as connected to document and
terminal (actually, it is used when encoding forms in viewer too, but that
stuff should be probably moved to document).

viewer/ contains code concerning that big rectangle between bars at the top
and bars at the bottom, documents usually being shown inside. Logically, it
is in fact kind of a BFU widget, but in practice it has little in common with
the bfu/ widgets, it is special in many ways and deeply woven to the fabric
of session/ (e.g. session history is basically a chain of viewer widget
descriptors).

dialogs/ is special too. It in fact means to say "global and unique BFU
instances belonging to the ELinks core"/ but that's a rather long and boring
name, besides the nightmares associated with maintaining files and directories
containing spaces in GIT. The "global and unique BFU instances" part can be
represented by exmode, menus and leds (were they there). The "ELinks core"
part can be represented by options, document and downloads. The reason those
aren't in their respective directories (while bookmarks or formhist have their
dialogs.c) is that it's important to keep the dependencies sorted out
reasonably. Had there been e.g. terminal/dialogs.c, it would mean libterminal
has to depend on libbfu.a and so. (There are two 'managerial' exceptions
to this; don't dig into them, please. ;-)

scripting/ (== browser scripting) is also expected to hook all around, perhaps
it should be better in the omnipresent box.

The edges are directed and represent the "using" relation. Therefore,
"bfu -> terminal" means "bfu/ is using terminal/ services (but not
the other way around)".

.---------.
| util/   | <-- This is omnipresent :)
| config/ |
| intl/   |
`---------'

                   .-------.         .---------.
                   |  bfu  |<------- | dialogs |
                   `-------' \       `---------'
                       v      `---.       |
                 .----------.      \ .--------.
                 | terminal | <----- | viewer | <-----------------.
               / `----------'     .> `--------'                   |
           .--'        v         /        v                       v
.-------. /      .----------.   |    .----------.       .----/ecmascript/----.
| osdep |<------ | lowlevel |   |    | document | ----> | document scripting |
`-------' \      `----------'   |    `----------'       `--------------------'
           `---.       ^         \        ^
                \ .---------.     `> .---------.        .----/scripting/----.
                  | network | <----- | session | -----> | browser scripting |
                  `---------'      / `---------'        `-------------------'
                       ^       .--'
                 .----------. <
                 | protocol |
                 `----------'