1
0
mirror of https://github.com/rkd77/elinks.git synced 2024-12-04 14:46:47 -05:00
elinks/src
Kalle Olavi Niemitalo 7645a836fc Cast the NULL argument of straconcat to unsigned char *.
straconcat reads the args with va_arg(ap, const unsigned char *),
and the NULL macro may have the wrong type (e.g. int).

Many places pass string literals of type char * to straconcat.  This
is in principle also a violation, but I'm ignoring it for now because
if it becomes a problem with some C implementation, then so will the
use of unsigned char * with printf "%s", which is so widespread in
ELinks that I'm not going to try fixing it now.
2007-03-11 12:59:11 +02:00
..
bfu Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
bookmarks Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
cache Make instances of struct listbox_ops const. 2007-02-04 15:17:49 +02:00
config Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
cookies Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
dialogs Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
document Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
dom Fix compiler errors without HAVE_VARIADIC_MACROS. 2007-03-11 12:22:02 +02:00
ecmascript Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
encoding Various comments and tweaks in bzip2 decoding. 2007-02-24 23:03:47 +02:00
formhist Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
globhist Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
intl Fix gcc warning: value computed is not used. Patch by Alexey Tourbin. 2007-03-05 21:10:02 +01:00
main Fix compiler errors without HAVE_VARIADIC_MACROS. 2007-03-11 12:22:02 +02:00
mime Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
network Fix compiler errors without HAVE_VARIADIC_MACROS. 2007-03-11 12:22:02 +02:00
osdep Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
protocol Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
scripting Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
session Cast variadic arguments of getml to void *. 2007-03-11 12:41:17 +02:00
terminal Fix compiler errors without HAVE_VARIADIC_MACROS. 2007-03-11 12:22:02 +02:00
util Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
viewer Cast the NULL argument of straconcat to unsigned char *. 2007-03-11 12:59:11 +02:00
elinks.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
Makefile src/Makefile: Add a TAGS target. 2007-01-27 21:03:09 +02:00
README Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
setup.h Revert bad stuff in a3fb98f499 2006-02-19 07:31:39 +00:00
vernum.c Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
vernum.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00

				  The Big View

The whole dependency tree is supposed (in ideal world) to look somewhat like
the following. Please note that this deals only with the core parts of ELinks,
not extensions like bookmarks, cookies, globhist, mime etc. Those act like
modules and are generally self-contained - the main visible difference is that
they don't have their UI stuff in dialogs/foo.c but in foo/dialogs.c.

Note also that it isn't all that clean-cut as it looks. Some parts of e.g.
lowlevel/ or osdep/ are omnipresent as well and it's meant to be so (at least
for now). Also some other exceptions are possible; the exception to this is
util/, where no exceptions are permitted - it must have no dependencies to the
rest of the code whatsoever, not even compile-time ones. The other way around,
the gettext part of intl/ is generally omnipresent but the charset part is
pretty isolated - it could be probably drawn as connected to document and
terminal (actually, it is used when encoding forms in viewer too, but that
stuff should be probably moved to document).

viewer/ contains code concerning that big rectangle between bars at the top
and bars at the bottom, documents usually being shown inside. Logically, it
is in fact kind of a BFU widget, but in practice it has little in common with
the bfu/ widgets, it is special in many ways and deeply woven to the fabric
of session/ (e.g. session history is basically a chain of viewer widget
descriptors).

dialogs/ is special too. It in fact means to say "global and unique BFU
instances belonging to the ELinks core"/ but that's a rather long and boring
name, besides the nightmares associated with maintaining files and directories
containing spaces in GIT. The "global and unique BFU instances" part can be
represented by exmode, menus and leds (were they there). The "ELinks core"
part can be represented by options, document and downloads. The reason those
aren't in their respective directories (while bookmarks or formhist have their
dialogs.c) is that it's important to keep the dependencies sorted out
reasonably. Had there been e.g. terminal/dialogs.c, it would mean libterminal
has to depend on libbfu.a and so. (There are two 'managerial' exceptions
to this; don't dig into them, please. ;-)

scripting/ (== browser scripting) is also expected to hook all around, perhaps
it should be better in the omnipresent box.

The edges are directed and represent the "using" relation. Therefore,
"bfu -> terminal" means "bfu/ is using terminal/ services (but not
the other way around)".

.---------.
| util/   | <-- This is omnipresent :)
| config/ |
| intl/   |
`---------'

                   .-------.         .---------.
                   |  bfu  |<------- | dialogs |
                   `-------' \       `---------'
                       v      `---.       |
                 .----------.      \ .--------.
                 | terminal | <----- | viewer | <-----------------.
               / `----------'     .> `--------'                   |
           .--'        v         /        v                       v
.-------. /      .----------.   |    .----------.       .----/ecmascript/----.
| osdep |<------ | lowlevel |   |    | document | ----> | document scripting |
`-------' \      `----------'   |    `----------'       `--------------------'
           `---.       ^         \        ^
                \ .---------.     `> .---------.        .----/scripting/----.
                  | network | <----- | session | -----> | browser scripting |
                  `---------'      / `---------'        `-------------------'
                       ^       .--'
                 .----------. <
                 | protocol |
                 `----------'