1
0
mirror of https://github.com/rkd77/elinks.git synced 2024-11-04 08:17:17 -05:00
elinks/src
Kalle Olavi Niemitalo 61019c3130 Debian bug 464384: fix OFF_T_FORMAT mismatches on amd64
On AMD64 apparently, off_t is long but ELinks detected SIZEOF_OFF_T == 8
and defined OFF_T_FORMAT as "lld", which expects long long and so causes
GCC to warn about a mismatching format specifier.  Because --enable-debug
adds -Werror to $CFLAGS, this warning breaks the build.  When both
SIZEOF_LONG and SIZEOF_LONG_LONG are 8, ELinks cannot know which type
it should use.

To fix this, do not attempt to find a format specifier for off_t itself.
Instead cast all printed off_t values to a new typedef off_print_T that
is large enough, and replace OFF_T_FORMAT with OFF_PRINT_FORMAT which
is suitable for off_print_T altough not necessarily for off_t.  ELinks
already had a similar scheme with time_print_T and TIME_PRINT_FORMAT.
2008-02-10 11:30:27 +02:00
..
bfu Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
bookmarks Declare element types of lists. 2007-07-26 22:47:23 +03:00
cache Debian bug 464384: fix OFF_T_FORMAT mismatches on amd64 2008-02-10 11:30:27 +02:00
config config: Fix the "include" command. 2008-02-03 20:28:27 +02:00
cookies Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
dialogs Debian bug 464384: fix OFF_T_FORMAT mismatches on amd64 2008-02-10 11:30:27 +02:00
document Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
dom Move get_test_opt to util/test.h and use throughout test programs 2007-08-28 20:34:17 +02:00
ecmascript Trim trailing whitespaces. 2007-09-14 15:12:32 +02:00
encoding Trim trailing whitespaces. 2007-09-14 15:12:32 +02:00
formhist Declare element types of lists. 2007-07-26 22:47:23 +03:00
globhist Declare element types of lists. 2007-07-26 22:47:23 +03:00
intl const in name_to_language 2008-02-03 14:42:07 +02:00
main Improve display of version and features. 2007-09-14 10:34:42 +02:00
mime Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
network Debian bug 464384: fix cast warning in ssl_connect 2008-02-09 15:19:20 +02:00
osdep Debian bug 464384: fix OFF_T_FORMAT mismatches on amd64 2008-02-10 11:30:27 +02:00
protocol Debian bug 464384: fix OFF_T_FORMAT mismatches on amd64 2008-02-10 11:30:27 +02:00
scripting Bug 975: Fix int/size_t pointer type mismatch. 2007-11-10 19:28:01 +02:00
session Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
terminal Patch: fix for bug 938 2008-02-09 14:11:21 +02:00
util const in map_scanner_string 2008-01-26 17:57:14 +02:00
viewer Strings corrections from Malcolm Parsons 2008-01-27 04:19:23 +00:00
.gitignore Ignore tags file 2007-08-08 14:25:38 +02:00
elinks.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
Makefile Add rule to make (c)tags file 2007-08-10 10:26:14 +02:00
README Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
setup.h Make copyright info independent from translations. 2007-10-03 11:53:09 +02:00
vernum.c Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00
vernum.h Remove now useless $Id: lines. 2005-10-21 09:14:07 +02:00

				  The Big View

The whole dependency tree is supposed (in ideal world) to look somewhat like
the following. Please note that this deals only with the core parts of ELinks,
not extensions like bookmarks, cookies, globhist, mime etc. Those act like
modules and are generally self-contained - the main visible difference is that
they don't have their UI stuff in dialogs/foo.c but in foo/dialogs.c.

Note also that it isn't all that clean-cut as it looks. Some parts of e.g.
lowlevel/ or osdep/ are omnipresent as well and it's meant to be so (at least
for now). Also some other exceptions are possible; the exception to this is
util/, where no exceptions are permitted - it must have no dependencies to the
rest of the code whatsoever, not even compile-time ones. The other way around,
the gettext part of intl/ is generally omnipresent but the charset part is
pretty isolated - it could be probably drawn as connected to document and
terminal (actually, it is used when encoding forms in viewer too, but that
stuff should be probably moved to document).

viewer/ contains code concerning that big rectangle between bars at the top
and bars at the bottom, documents usually being shown inside. Logically, it
is in fact kind of a BFU widget, but in practice it has little in common with
the bfu/ widgets, it is special in many ways and deeply woven to the fabric
of session/ (e.g. session history is basically a chain of viewer widget
descriptors).

dialogs/ is special too. It in fact means to say "global and unique BFU
instances belonging to the ELinks core"/ but that's a rather long and boring
name, besides the nightmares associated with maintaining files and directories
containing spaces in GIT. The "global and unique BFU instances" part can be
represented by exmode, menus and leds (were they there). The "ELinks core"
part can be represented by options, document and downloads. The reason those
aren't in their respective directories (while bookmarks or formhist have their
dialogs.c) is that it's important to keep the dependencies sorted out
reasonably. Had there been e.g. terminal/dialogs.c, it would mean libterminal
has to depend on libbfu.a and so. (There are two 'managerial' exceptions
to this; don't dig into them, please. ;-)

scripting/ (== browser scripting) is also expected to hook all around, perhaps
it should be better in the omnipresent box.

The edges are directed and represent the "using" relation. Therefore,
"bfu -> terminal" means "bfu/ is using terminal/ services (but not
the other way around)".

.---------.
| util/   | <-- This is omnipresent :)
| config/ |
| intl/   |
`---------'

                   .-------.         .---------.
                   |  bfu  |<------- | dialogs |
                   `-------' \       `---------'
                       v      `---.       |
                 .----------.      \ .--------.
                 | terminal | <----- | viewer | <-----------------.
               / `----------'     .> `--------'                   |
           .--'        v         /        v                       v
.-------. /      .----------.   |    .----------.       .----/ecmascript/----.
| osdep |<------ | lowlevel |   |    | document | ----> | document scripting |
`-------' \      `----------'   |    `----------'       `--------------------'
           `---.       ^         \        ^
                \ .---------.     `> .---------.        .----/scripting/----.
                  | network | <----- | session | -----> | browser scripting |
                  `---------'      / `---------'        `-------------------'
                       ^       .--'
                 .----------. <
                 | protocol |
                 `----------'