From aca8b1f7cd5563a74380e1846ce2a01f8446876d Mon Sep 17 00:00:00 2001 From: Witold Filipczyk Date: Fri, 26 Nov 2021 20:18:46 +0100 Subject: [PATCH] [quickjs] Define window properties and functions in global object. window.alert and alert both are functional --- src/ecmascript/quickjs/window.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/ecmascript/quickjs/window.c b/src/ecmascript/quickjs/window.c index 31e1f620..92c8a1f5 100644 --- a/src/ecmascript/quickjs/window.c +++ b/src/ecmascript/quickjs/window.c @@ -417,23 +417,13 @@ fail: int js_window_init(JSContext *ctx) { - JSValue window_proto, window_class; - /* create the window class */ JS_NewClassID(&js_window_class_id); JS_NewClass(JS_GetRuntime(ctx), js_window_class_id, &js_window_class); JSValue global_obj = JS_GetGlobalObject(ctx); - - window_proto = JS_NewObject(ctx); - JS_SetPropertyFunctionList(ctx, window_proto, js_window_proto_funcs, countof(js_window_proto_funcs)); - - window_class = JS_NewCFunction2(ctx, js_window_ctor, "window", 0, JS_CFUNC_constructor, 0); - /* set proto.constructor and ctor.prototype */ - JS_SetConstructor(ctx, window_class, window_proto); - JS_SetClassProto(ctx, js_window_class_id, window_proto); - - JS_SetPropertyStr(ctx, global_obj, "window", window_proto); + JS_SetPropertyFunctionList(ctx, global_obj, js_window_proto_funcs, countof(js_window_proto_funcs)); + JS_SetPropertyStr(ctx, global_obj, "window", global_obj); JS_FreeValue(ctx, global_obj);