From 80aa801e6a33856030b6bc76bd5fca6de6112c8e Mon Sep 17 00:00:00 2001 From: Kalle Olavi Niemitalo Date: Mon, 30 Jun 2008 16:14:49 +0300 Subject: [PATCH] mkdist: avoid echo According to SUSv3, "New applications are encouraged to use printf instead of echo." --- contrib/mkdist | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/contrib/mkdist b/contrib/mkdist index 0c8d8d1d..301ae1ed 100755 --- a/contrib/mkdist +++ b/contrib/mkdist @@ -20,10 +20,12 @@ # set -x -echo "-------------------------------------------------" -echo "Date: $(date)" -echo "Args: $*" -echo "-------------------------------------------------" +cat <&2 "$0:$LINENO: bug found" + (*) printf >&2 "%s:%d: bug found\n" "$0" "$LINENO" exit 1 ;; esac done if [ $OPTIND -le $# ] then - echo >&2 "$0: too many non-option arguments" + printf >&2 "%s: too many non-option arguments\n" "$0" exit 1 fi if [ -z "$GIT_DIR" ] then - echo >&2 "$0: Must specify -g GIT_DIR option" + printf >&2 "%s: Must specify -g GIT_DIR option\n" "$0" exit 1 fi if [ -z "$outdir" ] then - echo >&2 "$0: Must specify -o OUTDIR option" + printf >&2 "%s: Must specify -o OUTDIR option\n" "$0" exit 1 fi if [ -z "$rev" ] then - echo >&2 "$0: Must specify -r REVISION option" + printf >&2 "%s: Must specify -r REVISION option\n" "$0" exit 1 fi if [ -z "$label" ]