From 322b003e22ec18c41b7eec7f894ac59b86420612 Mon Sep 17 00:00:00 2001 From: Witold Filipczyk Date: Thu, 1 Mar 2007 18:51:39 +0100 Subject: [PATCH] cgi: Fix the possible memleak and close pipes in case of error. --- src/protocol/file/cgi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/protocol/file/cgi.c b/src/protocol/file/cgi.c index 68535313..12d6c6f9 100644 --- a/src/protocol/file/cgi.c +++ b/src/protocol/file/cgi.c @@ -373,12 +373,14 @@ execute_cgi(struct connection *conn) } } else { /* ELinks */ - - if (!init_http_connection_info(conn, 1, 0, 1)) - return 0; - mem_free(script); + if (!init_http_connection_info(conn, 1, 0, 1)) { + close(pipe_read[0]); close(pipe_read[1]); + close(pipe_write[0]); close(pipe_write[1]); + return 0; + } + close(pipe_read[1]); close(pipe_write[0]); conn->socket->fd = pipe_read[0];