aniani/amfora
1
0
Fork 0
mirror of https://github.com/makew0rld/amfora.git synced 2024-12-04 14:46:29 -05:00
Code

🐛 Pressing Esc in bottombar doesn't jump to page beg.

Browse Source
This commit is contained in:
makeworld 2020-07-28 19:06:00 -04:00
parent 0977cabb18
commit 2d99db371d
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased] ## [Unreleased]
### Added ### Added
- **Themeing** - check out [default-config.toml](./default-config.toml) for details (#46) - **Themeing** - check out [default-config.toml](./default-config.toml) for details (#46)
@ -24,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Using the `..` command doesn't keep the query string (#49) - Using the `..` command doesn't keep the query string (#49)
- Any error that occurs when downloading a file will be displayed, and the partially downloaded file will be deleted - Any error that occurs when downloading a file will be displayed, and the partially downloaded file will be deleted
- Allow for opening a new tab while the current one is loading - Allow for opening a new tab while the current one is loading
- Pressing Escape after typing in the bottom bar no longer jumps you back to the top of the page
## [1.3.0] - 2020-07-10 ## [1.3.0] - 2020-07-10
@ -47,6 +49,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Plain text documents are displayed faithfully (there were some edge conditions) - Plain text documents are displayed faithfully (there were some edge conditions)
- Opening files in portal.mozz.us uses the `http` setting in the config (#42) - Opening files in portal.mozz.us uses the `http` setting in the config (#42)
## [1.2.0] - 2020-07-02 ## [1.2.0] - 2020-07-02
### Added ### Added
- Alt-Left and Alt-Right for history navigation (#23) - Alt-Left and Alt-Right for history navigation (#23)
@ -76,6 +79,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- New tab text is wrapped to terminal width like other pages (#31) - New tab text is wrapped to terminal width like other pages (#31)
- TOFU "continue anyway" popup has a question mark at the end - TOFU "continue anyway" popup has a question mark at the end
## [1.1.0] - 2020-06-24 ## [1.1.0] - 2020-06-24
### Added ### Added
- **Bookmarks** (#10) - **Bookmarks** (#10)

1
NOTES.md
View File

@ -3,7 +3,6 @@
## Issues ## Issues
- URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL - URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL
- Can't go back or do other things while page is loading - need a way to stop `handleURL` - Can't go back or do other things while page is loading - need a way to stop `handleURL`
- Pressing Escape in the bottom bar jumps back to the top of the page
## Regressions ## Regressions

4
display/display.go
View File

@ -105,6 +105,8 @@ func Init() {
bottomBar.SetDoneFunc(func(key tcell.Key) { bottomBar.SetDoneFunc(func(key tcell.Key) {
tab := curTab tab := curTab
tabs[tab].saveScroll()
// Reset func to set the bottomBar back to what it was before // Reset func to set the bottomBar back to what it was before
// Use for errors. // Use for errors.
reset := func() { reset := func() {
@ -197,7 +199,7 @@ func Init() {
reset() reset()
return return
case tcell.KeyEscape: case tcell.KeyEsc:
// Set back to what it was // Set back to what it was
reset() reset()
return return