1
0
mirror of https://github.com/makew0rld/amfora.git synced 2024-12-04 14:46:29 -05:00
amfora/NOTES.md

22 lines
1.2 KiB
Markdown
Raw Normal View History

2020-06-18 16:54:48 -04:00
# Notes
- Simplify into one struct
- All the maps and stuff could be replaced with a `tab` struct
- And then just one single map of tab number to `tab`
- URL for each tab should not be stored as a string - in the current code there's lots of reparsing the URL
2020-06-18 16:54:48 -04:00
2020-07-01 20:08:07 -04:00
## Upstream Bugs
- Wrapping messes up on brackets
2020-06-18 16:54:48 -04:00
- Filed [issue 23](https://gitlab.com/tslocum/cview/-/issues/23)
- Wrapping panics on strings with brackets and Asian characters
- Filed cview [issue 27](https://gitlab.com/tslocum/cview/-/issues/27)
- The panicking was reported and fixed in Amfora [issue 20](https://github.com/makeworld-the-better-one/amfora/issues/20), but the lines are now just not wrapped
2020-06-18 16:54:48 -04:00
- Text background not reset on ANSI pages
- Filed [issue 25](https://gitlab.com/tslocum/cview/-/issues/25)
2020-06-19 14:05:05 -04:00
- Modal styling messed up when wrapped - example occurence is the error modal for a long unsupported scheme URL
- Filed [issue 26](https://gitlab.com/tslocum/cview/-/issues/26)
- Add some bold back into modal text after this is fixed
- Bookmark keys aren't deleted, just set to `""`
2020-07-01 20:08:07 -04:00
- Waiting on [this viper PR](https://github.com/spf13/viper/pull/519) to be merged
- Help table cells aren't dynamically wrapped
- Filed [issue 29](https://gitlab.com/tslocum/cview/-/issues/29)