From 455efc9c3c0ed77a1e85438035842d7b130394bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jordi=20Garc=C3=ADa=20L?= Date: Wed, 1 Jan 2020 18:07:02 +0100 Subject: [PATCH 1/2] Update jekyll and bundle versions in gemspec Trying to use this theme as a gem on a fresh jekyll install results in the following error: ``` Bundler could not find compatible versions for gem "jekyll": In Gemfile: jekyll (~> 4.0.0) garth-jekyll-theme (~> 1.0.4) was resolved to 1.0.4, which depends on jekyll (~> 3.6) ``` This PR fixes the issue by updating the jekyll depencency. --- garth-jekyll-theme.gemspec | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/garth-jekyll-theme.gemspec b/garth-jekyll-theme.gemspec index de286c3..1e9a085 100644 --- a/garth-jekyll-theme.gemspec +++ b/garth-jekyll-theme.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "garth-jekyll-theme" - spec.version = "1.0.4" + spec.version = "1.0.5" spec.authors = ["David Darnes"] spec.email = ["me@daviddarnes.com"] @@ -15,8 +15,8 @@ Gem::Specification.new do |spec| spec.files = `git ls-files -z`.split("\x0").select { |f| f.match(%r{^(assets|_layouts|_includes|_sass|LICENSE|README)}i) } - spec.add_runtime_dependency "jekyll", "~> 3.6" + spec.add_runtime_dependency "jekyll", "~> 4.0.0" spec.add_runtime_dependency "jekyll-paginate", "~> 1.1" - spec.add_development_dependency "bundler", "~> 1.14" + spec.add_development_dependency "bundler", "~> 2.1.2" end From 99bfa05bedde7c62b3dc61cc4be2749fb89d797c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jordi=20Garc=C3=ADa=20L?= Date: Mon, 6 Jan 2020 13:51:56 +0100 Subject: [PATCH 2/2] Define a range for the versions --- garth-jekyll-theme.gemspec | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/garth-jekyll-theme.gemspec b/garth-jekyll-theme.gemspec index 1e9a085..082b28c 100644 --- a/garth-jekyll-theme.gemspec +++ b/garth-jekyll-theme.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "garth-jekyll-theme" - spec.version = "1.0.5" + spec.version = "1.0.4" spec.authors = ["David Darnes"] spec.email = ["me@daviddarnes.com"] @@ -15,8 +15,8 @@ Gem::Specification.new do |spec| spec.files = `git ls-files -z`.split("\x0").select { |f| f.match(%r{^(assets|_layouts|_includes|_sass|LICENSE|README)}i) } - spec.add_runtime_dependency "jekyll", "~> 4.0.0" + spec.add_runtime_dependency "jekyll", ">= 3.6", "< 5.0" spec.add_runtime_dependency "jekyll-paginate", "~> 1.1" - spec.add_development_dependency "bundler", "~> 2.1.2" + spec.add_development_dependency "bundler", ">= 1.14", "< 3.0" end