add -- after readlink

tests/.urchin/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

tests/Test root contains .urchin./Assess root on a file.

@@ -1,3 +1,2 @@
 #!/bin/sh
-#!/bin/sh
 ../../urchin --root .testsuite/a/b/c/testcase

tests/get_stdout_file/t

@@ -0,0 +1,4 @@
+#!/bin/sh
+
+I_AM_SOURCING_URCHIN_IN_A_TEST=true . ../../urchin
+test $(get_stdout_file t) = aoeu

urchin

@@ -7,8 +7,7 @@
 # No part of urchin, including this file, may be copied, modified, propagated,
 # or distributed except according to the terms contained in the COPYING file.
 
-# Stop on error.
+set +e
-set -e
 
 # Make sure that CDPATH isn't set, as it causes `cd` to behave unpredictably -
 # notably, it can produce output, which breaks fullpath().
@@ -19,24 +18,15 @@ VERSION=0.0.6
 
 urchin_root() {
   # Call recursively but remember the original argument.
-  current="$1"
+  current="$(remove_trailing_slash "$1")"
   if test -n "$2"; then
     orig="$2"
   else
     orig="$1"
   fi
 
-  (
+  if test "$(readlink -f -- "$1")" = /; then
-    set -e
+    # Stop traversing upwards at /
-    
-    if ! test -e "$current"; then
-      echo "$current: No such file or directory">&2
-      exit 1
-    elif test -f "$current"; then
-      urchin_root "$(dirname "$current")" "$orig"
-    elif test -d "$current"/.urchin; then
-      echo "$current"
-    elif test "$(readlink -f "$current")" = /; then
     if test -d "$orig"; then
       origdir="$orig"
     else
@@ -45,12 +35,23 @@ urchin_root() {
     echo "You need to create the .urchin directory in the root of your tests,
 maybe like this:
 
-  mkdir '$origdir/.urchin'
+  mkdir '$(readlink -f -- "$(remove_trailing_slash "$origdir")")/.urchin'
 " >&2
+    return 1
+  elif ! test -e "$current"; then
+    echo "$current: No such file or directory">&2
+    return 1
+  elif test -f "$current"; then
+    urchin_root "$(dirname "$current")" "$orig"
+  elif test -d "$current"/.urchin; then
+    remove_trailing_slash "$current"
+  elif test "$current" != . && test "$current" != .. &&
+    echo "$current" | grep '^\.' && > /dev/null; then
+    # Stop traversing upwards at hidden directories.
+    urchin_root / "$orig"
   else
     urchin_root "$current"/.. "$orig"
   fi
-  )
 }
 
 indent() {
@@ -60,13 +61,17 @@ indent() {
   fi
 }
 
+remove_trailing_slash() {
+  echo "$1" | sed s/\\/$//
+}
+
 escape_slashes() {
   echo "$1" | sed s+/+\\\\/+g
 }
 
 get_stdout_file() {
-  root="$(readlink -f "$(urchin_root "$1")")"
+  root="$(readlink -f -- "$(urchin_root "$1")")"
-  test_file="$(readlink -f "$1")"
+  test_file="$(readlink -f -- "$1")"
   eroot="$(escape_slashes "$root")"
   base="$(echo "$test_file" | sed "s/^$eroot/$eroot\/.urchin/")"
   if test -d "$1"; then
@@ -81,6 +86,7 @@ recurse() {
   indent_level="$2"
   shell_for_sh_tests="$3"
 
+  [ "$potential_test" = '.urchin' ] && return
   [ "$potential_test" = 'setup_dir' ] && return
   [ "$potential_test" = 'teardown_dir' ] && return
   [ "$potential_test" = 'setup' ] && return
@@ -116,8 +122,10 @@ recurse() {
         [ -f setup ] && [ -x setup ] && ./setup >> "$stdout_file"
 
         # $2 instead of $indent_level so it doesn't clash
+        set +e
         recurse "${test}" "$(( $2 + 1 ))" "$shell_for_sh_tests"
         exit_code=$?
+        set -e
 
         if $exit_on_fail && test $exit_code -ne 0; then
           [ -f teardown ] && [ -x teardown ] && ./teardown >> "$stdout_file"
@@ -279,7 +287,10 @@ urchin_go() {
     TEST_SHELL='/bin/sh'
   fi
 
-  recurse "$1" 0 "$2"  # test folder -- indentation level -- [shell to invoke test scripts with]
+  # 1 test folder
+  # 2 indentation level
+  # 3 shell to invoke test scripts with
+  recurse "$1" 0 "$2"
 
   finish=$(date +%s)
   elapsed=$(($finish - $start))
@@ -301,7 +312,7 @@ urchin_go() {
     printf '%s\n' "$failed $(plural test "$failed") failed."
     printf '\033[m'
   fi
-  rm -f "$logfile"
+# rm -f "$logfile"
   test -z "$failed" || test "$failed" -eq '0'
 }
 
@@ -317,12 +328,13 @@ urchin_molly_guard() {
   exit 1
 }
 
-shell_for_sh_tests=
+if test -z "$I_AM_SOURCING_URCHIN_IN_A_TEST"; then
-force=false
+  shell_for_sh_tests=
-exit_on_fail=false
+  force=false
-tap_format=false
+  exit_on_fail=false
-while [ $# -gt 0 ]
+  tap_format=false
-do
+  while [ $# -gt 0 ]
+  do
       case "$1" in
           -e) exit_on_fail=true;;
           -f) force=true;;
@@ -348,22 +360,25 @@ do
           *)  break;;
       esac
       shift
-done
+  done
 
-# Verify argument for main stuff
+  # Verify argument for main stuff
-if [ "$#" != '1' ] || [ ! -d "$1" ]
+  if [ "$#" != '1' ] || [ ! -d "$1" ]
     then
     [ -n "$1" ] && [ ! -d "$1" ] && echo "Not a directory: '$1'" >&2
     echo "$USAGE" >&2
     exit 11
-fi
+  fi
 
-# Run or present the Molly guard.
+  # Run or present the Molly guard.
-if dirname "$(readlink -f "$(urchin_root "$1")")" |
+  if ! urchin_root "$1" > /dev/null; then
+    exit 1
+  elif basename "$(readlink -f -- "$(urchin_root "$1")")" |
     grep -Fi 'test' > /dev/null || $force; then
-  logfile="$(readlink -f "$(urchin_root "$1")/.urchin/.log")"
+    logfile="$(readlink -f -- "$(urchin_root "$1")/.urchin/.log")"
-  echo > "$logfile"
+    printf '' > "$logfile"
     urchin_go "$1" "$shell_for_sh_tests"
-else
+  else
     urchin_molly_guard
+  fi
 fi