Bram Moolenaar
8d4ed11da6
patch 8.2.0510: Coverity complains about using uninitialized variable
...
Problem: Coverity complains about using uninitialized variable.
Solution: Assign a value to "scol". Move code inside NULL check.
2020-04-04 14:50:32 +02:00
Bram Moolenaar
aeea72151c
patch 8.2.0500: using the same loop in many places
...
Problem: Using the same loop in many places.
Solution: Define more FOR_ALL macros. (Yegappan Lakshmanan, closes #5339 )
2020-04-02 18:50:46 +02:00
Bram Moolenaar
1939826509
patch 8.2.0380: tiny popup when creating a terminal popup without minwidth
...
Problem: Tiny popup when creating a terminal popup without minwidth.
Solution: Use a default mininum size of 5 lines of 20 characters.
2020-03-14 15:28:08 +01:00
Bram Moolenaar
8210693795
patch 8.2.0375: Coverity warning for not using return value
...
Problem: Coverity warning for not using return value.
Solution: Move error message to separate function.
2020-03-13 14:34:38 +01:00
Bram Moolenaar
cee52204ca
patch 8.2.0371: crash with combination of terminal popup and autocmd
...
Problem: Crash with combination of terminal popup and autocmd.
Solution: Disallow closing a popup that is the current window. Add a check
that the current buffer is valid. (closes #5754 )
2020-03-11 14:19:58 +01:00
Bram Moolenaar
ba2920fe97
patch 8.2.0359: popup_atcursor() may hang
...
Problem: popup_atcursor() may hang. (Yasuhiro Matsumoto)
Solution: Take the decoration into account. (closes #5728 )
2020-03-06 21:43:17 +01:00
Bram Moolenaar
57c732ed78
patch 8.2.0330: build error with popup window but without terminal
...
Problem: Build error with popup window but without terminal.
Solution: Add #ifdef.
2020-02-28 22:51:54 +01:00
Bram Moolenaar
ec084d3356
patch 8.2.0329: popup filter converts 0x80 bytes
...
Problem: Popup filter converts 0x80 bytes.
Solution: Keep 0x80 bytes as-is. (Ozaki Kiichi, closes #5706 )
2020-02-28 22:44:47 +01:00
Bram Moolenaar
e52e0c89d1
patch 8.2.0328: no redraw when leaving term-normal mode in popup terminal
...
Problem: No redraw when leaving terminal-normal mode in a terminal popup
window.
Solution: Redraw the popup window. (closes #5708 )
2020-02-28 22:20:10 +01:00
Bram Moolenaar
80ae880f5f
patch 8.2.0327: crash when opening and closing two popup terminal windows
...
Problem: Crash when opening and closing two popup terminal windows.
Solution: Check that prevwin is valid. (closes #5707 )
2020-02-28 19:11:18 +01:00
Bram Moolenaar
11ec807639
patch 8.2.0286: cannot use popup_close() for a terminal popup
...
Problem: Cannot use popup_close() for a terminal popup.
Solution: Allow using popup_close(). (closes #5666 )
2020-02-20 20:12:29 +01:00
Bram Moolenaar
2e6638d5f0
patch 8.2.0214: a popup window with a terminal can be made hidden
...
Problem: A popup window with a terminal can be made hidden.
Solution: Disallow hiding a terminal popup.
2020-02-05 21:07:18 +01:00
Bram Moolenaar
a5edb670dc
patch 8.2.0205: error code E899 used twice
...
Problem: Error code E899 used twice.
Solution: Use E863 for the terminal in popup error.
2020-02-03 22:58:48 +01:00
Bram Moolenaar
d98c0b63ab
patch 8.2.0196: blocking commands for a finished job in a popup window
...
Problem: Blocking commands for a finished job in a popup window.
Solution: Do not block commands if the job has finished. Adjust test.
2020-02-02 15:25:16 +01:00
Bram Moolenaar
3c01c4a028
patch 8.2.0194: some commands can cause problems in terminal popup
...
Problem: Some commands can cause problems in terminal popup.
Solution: Disallow more commands.
2020-02-01 23:04:24 +01:00
Bram Moolenaar
91cd59a0a2
patch 8.2.0192: build failure without +terminal feature
...
Problem: Build failure without +terminal feature.
Solution: Add #ifdefs.
2020-02-01 22:18:37 +01:00
Bram Moolenaar
219c7d0638
patch 8.2.0191: cannot put a terminal in a popup window
...
Problem: Cannot put a terminal in a popup window.
Solution: Allow opening a terminal in a popup window. It will always have
keyboard focus until closed.
2020-02-01 21:57:29 +01:00
Bram Moolenaar
b09920203a
patch 8.2.0179: still a few places where range() does not work
...
Problem: Still a few places where range() does not work.
Solution: Fix using range() causing problems.
2020-01-30 14:55:42 +01:00
Bram Moolenaar
8bf716cdba
patch 8.2.0142: possible to enter popup window with CTRL-W p
...
Problem: Possible to enter popup window with CTRL-W p. (John Devin)
Solution: Check entered window is not a popup window. (closes #5515 )
2020-01-23 15:33:54 +01:00
Bram Moolenaar
ca7c078b79
patch 8.2.0118: crash when cycling to buffers involving popup window
...
Problem: Crash when cycling to buffers involving popup window .
Solution: Do not decrement buffer reference count.
2020-01-14 20:42:48 +01:00
Bram Moolenaar
fbcdf671f0
patch 8.2.0096: cannot create tiny popup window in last column
...
Problem: Cannot create tiny popup window in last column. (Daniel Steinberg)
Solution: Remove position limit. (closes #5447 )
2020-01-06 23:07:48 +01:00
Bram Moolenaar
4954019c93
patch 8.1.2420: crash when calling popup_close() in win_execute()
...
Problem: Crash when calling popup_close() in win_execute().
Solution: Disallow popup_close() in popup window. (Yasuhiro Matsumoto,
closes #5345 )
2019-12-11 19:34:54 +01:00
Bram Moolenaar
5a4c3082d7
patch 8.1.2373: cannot build with +popupwin but without +quickfix
...
Problem: Cannot build with +popupwin but without +quickfix. (John Marriott)
Solution: Adjust #ifdefs.
2019-12-01 15:23:11 +01:00
Bram Moolenaar
05ad5ff0ab
patch 8.1.2371: FEAT_TEXT_PROP is a confusing name
...
Problem: FEAT_TEXT_PROP is a confusing name.
Solution: Use FEAT_PROP_POPUP. (Naruhiko Nishino, closes #5291 )
2019-11-30 22:48:27 +01:00
Bram Moolenaar
7257073043
patch 8.1.2362: cannot place signs in a popup window
...
Problem: Cannot place signs in a popup window. (Maxim Kim)
Solution: Use the group prefix "PopUp" to specify which signs should show up
in a popup window. (closes #5277 )
2019-11-30 14:21:53 +01:00
Bram Moolenaar
fd318115a5
patch 8.1.2334: possible NULL pointer dereference in popup_locate()
...
Problem: Possible NULL pointer dereference in popup_locate(). (Coverity)
Solution: Check for NULL pointer.
2019-11-22 19:22:08 +01:00
Bram Moolenaar
a37cb55da6
patch 8.1.2307: positioning popup doesn't work for buffer-local textprop
...
Problem: Positioning popup doesn't work for buffer-local textprop.
Solution: Make it work. (closes #5225 )
2019-11-16 20:03:31 +01:00
Bram Moolenaar
db3a205147
patch 8.1.2304: cannot get the mouse position when getting a mouse click
...
Problem: Cannot get the mouse position when getting a mouse click.
Solution: Add getmousepos().
2019-11-16 18:22:41 +01:00
Bram Moolenaar
afe45b68a6
patch 8.1.2300: redraw breaks going through list of popup windows
...
Problem: Redraw breaks going through list of popup windows.
Solution: Use different flags for popup_reset_handled(). (closes #5216 )
2019-11-13 22:35:19 +01:00
Bram Moolenaar
d002e411c6
patch 8.1.2292: v:mouse_winid not set on click in popup window
...
Problem: v:mouse_winid not set on click in popup window.
Solution: Set v:mouse_winid. (closes #5171 )
2019-11-11 21:45:05 +01:00
Bram Moolenaar
5c6b6187ac
patch 8.1.2288: not using all space when popup with "topleft" flips to above
...
Problem: Not using all space when popup with "topleft" flips to above.
Solution: Recompute the height when a popup flips from below to above.
(closes #5151 )
2019-11-10 17:51:38 +01:00
Bram Moolenaar
622b646037
patch 8.1.2286: using border highlight in popup window leaks memory
...
Problem: Using border highlight in popup window leaks memory.
Solution: Free memory before overwriting. (Dominique Pelle, closes #5203 )
2019-11-10 15:16:54 +01:00
Bram Moolenaar
4dd8fe0b4f
patch 8.1.2273: wrong default when "pos" is changed with popup_atcursor()
...
Problem: Wrong default when "pos" is changed with popup_atcursor().
Solution: Adjust the default line and col when "pos" is not the default
value. (#5151 )
2019-11-09 15:33:31 +01:00
Bram Moolenaar
f8b036bcae
patch 8.1.2266: position unknown for a mouse click in a popup window
...
Problem: Position unknown for a mouse click in a popup window.
Solution: Set v:mouse_col and v:mouse_lnum. (closes #5171 )
2019-11-06 21:09:17 +01:00
Bram Moolenaar
638a4a7508
patch 8.1.2265: when popup with "botleft" does not fit it flips incorrectly
...
Problem: When popup with "botleft" does not fit it flips incorrectly.
Solution: Only flip when there is more space on the other side. Add the
"posinvert" option to disable flipping and do it in both
directions if enabled. (closes #5151 )
2019-11-06 19:25:22 +01:00
Bram Moolenaar
30efcf3d26
patch 8.1.2250: CTRL-U and CTRL-D don't work in popup window
...
Problem: CTRL-U and CTRL-D don't work in popup window.
Solution: Initialize 'scroll'. Add "lastline" in popup_getpos().
(closes #5170 )
2019-11-03 22:29:38 +01:00
Bram Moolenaar
f2885d3fb7
patch 8.1.2240: popup window width changes when scrolling
...
Problem: Popup window width changes when scrolling.
Solution: Also adjust maxwidth when applying minwidth and there is a
scrollbar. Fix off-by-one error. (closes #5162 )
2019-11-02 20:21:25 +01:00
Bram Moolenaar
aa1f04d092
patch 8.1.2213: popup_textprop tests fail
...
Problem: Popup_textprop tests fail.
Solution: Adjust the column and line positioning.
2019-10-24 22:12:54 +02:00
Bram Moolenaar
b754b5bf6d
patch 8.1.2210: using negative offset for popup_create() does not work
...
Problem: Using negative offset for popup_create() does not work.
Solution: Use -1 instead of zero. (closes #5111 )
2019-10-24 19:25:00 +02:00
Bram Moolenaar
a13961536e
patch 8.1.2193: popup_setoptions(popup_getoptions()) does not work
...
Problem: Popup_setoptions(popup_getoptions()) does not work.
Solution: Also accept a list with three entries for "moved" and
"mousemoved". (closes #5081 )
2019-10-20 18:46:05 +02:00
Bram Moolenaar
dca7abe79c
patch 8.1.2192: cannot easily fill the info popup asynchronously
...
Problem: Cannot easily fill the info popup asynchronously.
Solution: Add the "popuphidden" value to 'completeopt'. (closes #4924 )
2019-10-20 18:17:57 +02:00
Bram Moolenaar
7b3d939667
patch 8.1.2164: stuck when using "j" in a popupwin with popup_filter_menu
...
Problem: Stuck when using "j" in a popupwin with popup_filter_menu if a
line wraps.
Solution: Check the cursor line is visible. (closes #4577 )
2019-10-16 22:17:07 +02:00
Bram Moolenaar
fd00c042af
patch 8.1.2114: when a popup is closed with CTRL-C the callback aborts
...
Problem: When a popup is closed with CTRL-C the callback aborts.
Solution: Reset got_int when invoking the callback. (closes #5008 )
2019-10-05 11:56:54 +02:00
Bram Moolenaar
1824f45883
patch 8.1.2109: popup_getoptions() hangs with tab-local popup
...
Problem: popup_getoptions() hangs with tab-local popup.
Solution: Correct pointer name. (Marko Mahnič, closes #5006 )
2019-10-02 23:06:46 +02:00
Bram Moolenaar
8617348e21
patch 8.1.2107: various memory leaks reported by asan
...
Problem: Various memory leaks reported by asan.
Solution: Free the memory. (Ozaki Kiichi, closes #5003 )
2019-10-01 17:02:16 +02:00
Bram Moolenaar
f21118e4a9
patch 8.1.2078: build error with +textprop but without +terminal
...
Problem: Build error with +textprop but without +terminal. (Tony Mechelynck)
Solution: Add #ifdef.
2019-09-25 22:45:45 +02:00
Bram Moolenaar
e0d749a496
patch 8.1.2076: crash when trying to put a terminal in a popup window
...
Problem: Crash when trying to put a terminal buffer in a popup window.
Solution: Check for NULL buffer. Do not allow putting a terminal in a popup
window.
2019-09-25 22:14:48 +02:00
Bram Moolenaar
076d98839c
patch 8.1.2032: scrollbar thumb wrong in popup window
...
Problem: Scrollbar thumb wrong in popup window.
Solution: Adjust thumb size and position when scrolled.
2019-09-14 22:23:29 +02:00
Bram Moolenaar
3d2a3cbce8
patch 8.1.2009: cursorline highlighting not updated in popup window
...
Problem: Cursorline highlighting not updated in popup window. (Marko
Mahnič)
Solution: Check if the cursor position changed. (closes #4912 )
2019-09-08 17:12:01 +02:00
Bram Moolenaar
fbb3bc89b3
patch 8.1.1998: redraw even when no popup window filter was invoked
...
Problem: Redraw even when no popup window filter was invoked.
Solution: Only redraw when must_redraw was set to a larger value.
2019-09-07 14:33:36 +02:00