Ken Takata
c97b3febc8
patch 9.0.2013: confusing ifdefs in if_<lang>.c
...
Problem: confusing ifdefs in if_<lang>.c
Solution: refactor ifndefs to #ifdefs
if_x: Avoid using #ifndef - #else - #endif
Using #ifndef - #else - #endif is sometimes confusing.
Use #ifdef - #else - #endif instead.
closes : #13310
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Ken Takata <kentkt@csc.jp>
2023-10-11 21:27:06 +02:00
zeertzjq
edcba96c00
patch 9.0.1933: Can change the type of a v: variable using if_lua
...
Problem: Can change the type of a v: variable using if_lua.
Solution: Add additional handling of v: variables like :let.
closes : #13161
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-09-24 23:13:51 +02:00
zeertzjq
4112acae08
patch 9.0.1721: Build failure on Windows with dynamic lua
...
Problem: Build failure on Windows with dynamic lua (after 9.0.1719)
Solution: move definition further down in if_lua
closes : #12811
closes : #12814
closes : #12818
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-16 20:25:10 +02:00
Jesse Pavel
8a35033782
patch 9.0.1719: if_lua: crash for for Lua functions invoked via Vim callbacks
...
Problem: if_lua: crash for Lua functions invoked via Vim callbacks
Solution: Use Lua registry rather than upvalues for udata cache
closes : #12785
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Jesse Pavel <jpavel@alum.mit.edu>
2023-08-15 23:21:05 +02:00
Yegappan Lakshmanan
a23a11b5bf
patch 9.0.1336: functions without arguments are not always declared properly
...
Problem: Functions without arguments are not always declared properly.
Solution: Use "(void)" instead of "()". (Yegappan Lakshmanan, closes #12031 )
2023-02-21 14:27:41 +00:00
Bram Moolenaar
0917e86763
patch 9.0.1320: checking the type of a null object causes a crash
...
Problem: Checking the type of a null object causes a crash.
Solution: Don't try to get the class of a null object. (closes #12005 )
Handle error from calling a user function better.
2023-02-18 14:42:44 +00:00
Bram Moolenaar
ebfec1c531
patch 9.0.1234: the code style has to be checked manually
...
Problem: The code style has to be checked manually.
Solution: Add basic code style checks in a test. Fix or avoid uncovered
problems.
2023-01-22 21:14:53 +00:00
Yegappan Lakshmanan
0233bdfa2b
patch 9.0.1183: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11805 )
2023-01-12 12:33:30 +00:00
Bram Moolenaar
ef2c325f5e
patch 9.0.0949: crash when unletting a variable while listing variables
...
Problem: Crash when unletting a variable while listing variables.
Solution: Disallow changing a hashtable while going over the entries.
(closes #11435 )
2022-11-25 16:31:51 +00:00
Bram Moolenaar
73e28dcc61
patch 9.0.0491: no good reason to build without the float feature
...
Problem: No good reason to build without the float feature.
Solution: Remove configure check for float and "#ifdef FEAT_FLOAT".
2022-09-17 21:08:33 +01:00
Bram Moolenaar
a4d158b3c8
patch 9.0.0206: redraw flags are not named specifically
...
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
2022-08-14 14:17:45 +01:00
Bram Moolenaar
113d9dec99
patch 9.0.0170: various minor code formatting issues
...
Problem: Various minor code formatting issues.
Solution: Improve code formatting.
2022-08-08 15:49:18 +01:00
Bram Moolenaar
6ed545e797
patch 8.2.4928: various white space and cosmetic mistakes
...
Problem: Various white space and cosmetic mistakes.
Solution: Change spaces to tabs, improve comments.
2022-05-09 20:09:23 +01:00
Bram Moolenaar
460ae5dfca
patch 8.2.3967: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
2022-01-01 14:19:49 +00:00
h-east
965d2edbce
patch 8.2.3474: some places use "Vimscript" instead of "Vim script"
...
Problem: Some places use "Vimscript" instead of "Vim script".
Solution: Consistently use "Vim script". (Hirohito Higashi, closes #8910 )
2021-10-04 21:51:57 +01:00
Yegappan Lakshmanan
11328bc7df
patch 8.2.3300: Lua: can only execute on Vim command at a time
...
Problem: Lua: can only execute on Vim command at a time. Not easy to get
the Vim version.
Solution: Make vim.command() accept multiple lines. Add vim.version().
(Yegappan Lakshmanan, closes #8716 )
2021-08-06 21:34:38 +02:00
Bram Moolenaar
1b6acf02b7
patch 8.2.3294: Lua: memory leak when adding dict item fails
...
Problem: Lua: memory leak when adding dict item fails.
Solution: Free the typval and the dict item.
2021-08-05 16:47:08 +02:00
Bram Moolenaar
4a01159da2
patch 8.2.3291: Coverity warns for not checking return value
...
Problem: Coverity warns for not checking return value.
Solution: If dict_add() fails give an error message.
2021-08-05 15:11:08 +02:00
Yegappan Lakshmanan
9dc4bef897
patch 8.2.3288: cannot easily access namespace dictionaries from Lua
...
Problem: Cannot easily access namespace dictionaries from Lua.
Solution: Add vim.g, vim.b, etc. (Yegappan Lakshmanan, closes #8693 ,
from NeoVim)
2021-08-04 21:12:52 +02:00
Yegappan Lakshmanan
41114a2a27
patch 8.2.3244: Lua 5.3 print() with a long string crashes
...
Problem: Lua 5.3 print() with a long string crashes.
Solution: Use a growarray instead of a Lua buffer. (Yegappan Lakshmanan,
closes #8655 )
2021-07-29 20:22:14 +02:00
Bram Moolenaar
2a4bd00cef
patch 8.2.3240: Lua print() does not work properly
...
Problem: Lua print() does not work properly.
Solution: Put back lua_pop().
2021-07-28 21:48:59 +02:00
Bram Moolenaar
78e006b9b0
patch 8.2.3234: crash when printing long string with Lua
...
Problem: Crash when printing long string with Lua.
Solution: Remove lua_pop(). (Martin Tournoij, closes #8648 )
2021-07-28 15:07:01 +02:00
Martin Tournoij
1a3e5747b7
patch 8.2.3208: dynamic library load error does not mention why it failed
...
Problem: Dynamic library load error does not mention why it failed.
Solution: Add the error message. (Martin Tournoij, closes #8621 )
2021-07-24 13:57:29 +02:00
Bram Moolenaar
125ed2745c
patch 8.2.2733: detecting Lua version is not reliable
...
Problem: Detecting Lua version is not reliable.
Solution: Add "vim.lua_version". (Ozaki Kiichi, closes #8080 )
2021-04-07 20:11:12 +02:00
Bram Moolenaar
86c3a2162c
patch 8.2.2578: Lua cannot handle a passed in lambda
...
Problem: Lua cannot handle a passed in lambda.
Solution: Handle VAR_PARTIAL. (Prabir Shrestha, closes #7937 , closes #7936 )
2021-03-08 19:50:24 +01:00
Bram Moolenaar
c8970b9464
patch 8.2.1908: Lua is initialized even when not used
...
Problem: Lua is initialized even when not used.
Solution: Put lua_init() after check for "eap->skip". (Christian Brabandt,
closes #7191 ). Avoid compiler warnings.
2020-10-26 20:18:08 +01:00
Bram Moolenaar
066e7da3cd
patch 8.2.1234: Lua build problem with old compiler
...
Problem: Lua build problem with old compiler.
Solution: Move declarations to start of the block. (Taro Muraoka,
closes #6477 )
2020-07-18 12:50:35 +02:00
Bram Moolenaar
5551b131da
patch 8.2.1212: cannot build with Lua 5.4
...
Problem: Cannot build with Lua 5.4.
Solution: Use luaL_typeerror instead defining it. (closes #6454 )
2020-07-14 21:54:28 +02:00
Bram Moolenaar
a9a8e5f0dc
patch 8.2.1117: Coverity warns for unsing unitialized field
...
Problem: Coverity warns for unsing unitialized field.
Solution: Initialize v_lock.
2020-07-02 21:17:57 +02:00
Bram Moolenaar
e49b8e8d75
patch 8.2.1105: insufficient test coverage for Lua
...
Problem: Insufficient test coverage for Lua.
Solution: Add tests. (Yegappan Lakshmanan, closes #6368 ) Fix uncovered
memory leak. Avoid unnecessary copy/free.
2020-07-01 13:52:55 +02:00
Bram Moolenaar
a1f9f8666e
patch 8.2.1081: Lua: cannot use table.insert() and table.remove()
...
Problem: Lua: cannot use table.insert() and table.remove().
Solution: Add the list functions. (Prabir Shrestha, closes #6353 )
2020-06-28 22:41:26 +02:00
Bram Moolenaar
bd84617d1a
patch 8.2.1066: Lua arrays are zero based
...
Problem: Lua arrays are zero based.
Solution: Make Lua arrays one based. (Prabir Shrestha, closes #6347 )
Note: this is not backwards compatible.
2020-06-27 12:32:57 +02:00
Bram Moolenaar
1e4c7d0ed2
patch 8.2.1057: cannot build with dynamic Lua
...
Problem: Cannot build with dynamic Lua.
Solution: Add dll variables.
2020-06-25 20:56:42 +02:00
Bram Moolenaar
801ab06934
patch 8.2.1054: not so easy to pass a lua function to Vim
...
Problem: Not so easy to pass a lua function to Vim.
Solution: Convert a Lua function and closure to a Vim funcref. (Prabir
Shrestha, closes #6246 )
2020-06-25 19:27:56 +02:00
Bram Moolenaar
788fbb4707
patch 8.2.0858: not easy to require Lua modules
...
Problem: Not easy to require Lua modules.
Solution: Improve use of Lua path. (Prabir Shrestha, closes #6098 )
2020-05-31 14:08:12 +02:00
Bram Moolenaar
ca70c07b72
patch 8.2.0853: ml_delete() often called with FALSE argument
...
Problem: ml_delete() often called with FALSE argument.
Solution: Use ml_delete_flags(x, ML_DEL_MESSAGE) when argument is TRUE.
2020-05-30 20:30:46 +02:00
Bram Moolenaar
df1643a6a7
patch 8.2.0782: cannot build with Lua on MS-Windows
...
Problem: Cannot build with Lua on MS-Windows.
Solution: Add DLL symbol for luaL_Loadstring. (Ken Takata)
2020-05-17 18:53:27 +02:00
Bram Moolenaar
9309eb2f28
patch 8.2.0781: compiler warning for not using value in Lua
...
Problem: Compiler warning for not using value in Lua.
Solution: Add "(void)".
2020-05-17 16:53:56 +02:00
Bram Moolenaar
eb04f0893a
patch 8.2.0775: not easy to call a Vim function from Lua
...
Problem: Not easy to call a Vim function from Lua.
Solution: Add vim.call() and vim.fn(). (Prabir Shrestha, closes #6063 )
2020-05-17 14:32:35 +02:00
Bram Moolenaar
2027973b5b
patch 8.2.0479: unloading shared libraries on exit has no purpose
...
Problem: Unloading shared libraries on exit has no purpose.
Solution: Do not unload shared libraries on exit.
2020-03-29 20:51:07 +02:00
Bram Moolenaar
5f1d3ae8a8
patch 8.2.0244: compiler warning in Lua interface
...
Problem: Compiler warning in Lua interface.
Solution: Add type cast. (Ken Takata, closes #5621 )
2020-02-11 22:37:35 +01:00
Bram Moolenaar
8a7d6542b3
patch 8.2.0149: maintaining a Vim9 branch separately is more work
...
Problem: Maintaining a Vim9 branch separately is more work.
Solution: Merge the Vim9 script changes.
2020-01-26 15:56:19 +01:00
Bram Moolenaar
9b4a15d5db
patch 8.2.0111: VAR_SPECIAL is also used for booleans
...
Problem: VAR_SPECIAL is also used for booleans.
Solution: Add VAR_BOOL for better type checking.
2020-01-11 16:05:23 +01:00
Bram Moolenaar
2ab2e8608f
patch 8.1.2387: using old C style comments
...
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
2019-12-04 21:24:53 +01:00
Bram Moolenaar
b98678a974
patch 8.1.2179: pressing "q" at the more prompt doesn't stop Python output
...
Problem: Pressing "q" at the more prompt doesn't stop Python output. (Daniel
Hahler)
Solution: Check for got_int in writer(). (closes #5053 )
Also do this for Lua.
2019-10-19 15:18:44 +02:00
Bram Moolenaar
7be3ab2589
patch 8.1.1583: set_ref_in_list() only sets ref in items
...
Problem: Set_ref_in_list() only sets ref in items.
Solution: Rename to set_ref_in_list_items() to avoid confusion.
2019-06-23 01:46:15 +02:00
Bram Moolenaar
6fb5c97242
patch 8.1.1054: not checking return value of ga_grow()
...
Problem: Not checking return value of ga_grow(). (Coverity)
Solution: Only append when ga_grow() returns OK.
2019-03-26 21:44:20 +01:00
Bram Moolenaar
b782869033
patch 8.1.1043: Lua interface does not support Blob
...
Problem: Lua interface does not support Blob.
Solution: Add support to Blob. (Ozaki Kiichi, closes #4151 )
2019-03-23 13:57:02 +01:00
Bram Moolenaar
4eefe47ea4
patch 8.1.1019: Lua: may garbage collect function reference in use
...
Problem: Lua: may garbage collect function reference in use.
Solution: Keep the function name instead of the typeval. Make luaV_setref()
handle funcref objects. (Ozaki Kiichi, closes #4127 )
2019-03-19 21:59:19 +01:00
Bram Moolenaar
713bf9e996
patch 8.1.1010: Lua interface leaks memory
...
Problem: Lua interface leaks memory.
Solution: Clear typeval after copying it.
2019-03-16 16:38:41 +01:00