1
0
forked from aniani/vim

patch 9.0.0804: crash when trying to divide a number by -1

Problem:    Crash when trying to divice the largest negative number by -1.
Solution:   Handle this case specifically.
This commit is contained in:
Bram Moolenaar 2022-10-20 14:17:18 +01:00
parent 43625762a9
commit cdef1cefa2
3 changed files with 15 additions and 1 deletions

View File

@ -66,6 +66,12 @@ num_divide(varnumber_T n1, varnumber_T n2, int *failed)
else
result = VARNUM_MAX;
}
else if (n1 == VARNUM_MIN && n2 == -1)
{
// specific case: trying to do VARNUM_MIN / -1 results in a positive
// number that doesn't fit in varnumber_T and causes an FPE
result = VARNUM_MAX;
}
else
result = n1 / n2;
@ -6023,7 +6029,7 @@ var2fpos(
}
/*
* Convert list in "arg" into position "psop" and optional file number "fnump".
* Convert list in "arg" into position "posp" and optional file number "fnump".
* When "fnump" is NULL there is no file number, only 3 items: [lnum, col, off]
* Note that the column is passed on as-is, the caller may want to decrement
* it to use 1 for the first column.

View File

@ -761,6 +761,12 @@ func Test_eval_after_if()
call assert_equal('b', s:val)
endfunc
func Test_divide_by_zero()
" only tests that this doesn't crash, the result is not important
echo 0 / 0
echo 0 / 0 / -1
endfunc
" Test for command-line completion of expressions
func Test_expr_completion()
CheckFeature cmdline_compl

View File

@ -695,6 +695,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
804,
/**/
803,
/**/