thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 9.1.0751: Error callback for term_start() not used

Browse Source 
Problem:  Error callback for term_start() not used
          (darkseid-is)
Solution: attach pipe to stderr if an error callback exists

fixes: #15665
closes: #15729

Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Christian Brabandt
2024-09-30 21:29:43 +02:00
parent 563e8ec8c7
commit b50bc9ad55
3 changed files with 44 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/os_unix.c
View File

@@ -5763,8 +5763,11 @@ mch_job_start(char **argv, job_T *job, jobopt_T *options, int is_terminal)
goto failed;
}
}
// only create a pipe for the error fd, when either a callback has been setup
// or pty is not used (e.g. terminal uses pty by default)
else if (!use_out_for_err && !use_null_for_err
&& pty_master_fd < 0 && pipe(fd_err) < 0)
&& (pty_master_fd < 0 || (options->jo_set & JO_ERR_CALLBACK))
&& pipe(fd_err) < 0)
goto failed;
if (!use_null_for_in || !use_null_for_out || !use_null_for_err)