thac0/vim
1
0
Fork 0
forked from aniani/vim
Code

patch 9.1.1455: Haiku: dailog objects created with no reference

Browse Source 
Problem:  Haiku: dailog objects created with no reference
Solution: delete the objects before returning (jinyaoguo)

In the functions gui_mch_dialog() and gui_mch_font_dialog(), Dialog
objects are created but never escape the function scope. The call to
dialog->Go() only returns a boolean value and does not retain any
reference to the Dialog object itself, which may lead to potential
memory leak.

Fix this by deleting the object after using it.

closes: #17501

Signed-off-by: jinyaoguo <guo846@purdue.edu>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
jinyaoguo 2025-06-11 21:30:01 +02:00 committed by Christian Brabandt
parent 51289207f8
commit ae31d7bfb4
No known key found for this signature in database
GPG Key ID: F3F92DA383FDDE09
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gui_haiku.cc
View File

@ -3820,7 +3820,9 @@ gui_mch_font_dialog(font_family* family, font_style* style, float* size)
#if defined(FEAT_GUI_DIALOG) #if defined(FEAT_GUI_DIALOG)
// gui.vimWindow->Unlock(); // gui.vimWindow->Unlock();
VimSelectFontDialog *dialog = new VimSelectFontDialog(family, style, size); VimSelectFontDialog *dialog = new VimSelectFontDialog(family, style, size);
return dialog->Go(); bool ret = dialog->Go();
delete dialog;
return ret;
#else #else
return NOFONT; return NOFONT;
#endif // FEAT_GUI_DIALOG #endif // FEAT_GUI_DIALOG
@ -4917,7 +4919,9 @@ gui_mch_dialog(
{ {
VimDialog *dialog = new VimDialog(type, (char*)title, (char*)message, VimDialog *dialog = new VimDialog(type, (char*)title, (char*)message,
(char*)buttons, dfltbutton, (char*)textfield, ex_cmd); (char*)buttons, dfltbutton, (char*)textfield, ex_cmd);
return dialog->Go(); bool ret = dialog->Go();
delete dialog;
return ret;
} }
#endif // FEAT_GUI_DIALOG #endif // FEAT_GUI_DIALOG

2
src/version.c
View File

@ -709,6 +709,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
1455,
/**/ /**/
1454, 1454,
/**/ /**/