From 9ccc2972373c8310c20ae7621b9c634d0dc43e26 Mon Sep 17 00:00:00 2001 From: Christian Brabandt Date: Tue, 26 Mar 2024 18:44:48 +0100 Subject: [PATCH] patch 9.1.0210: Motif: leaking memory when mui_mch_dialog() fails Problem: Motif: leaking memory when mui_mch_dialog() fails (LuMingYinDetect) Solution: When allocating the label using the XmStringCreateLtoR() function fails, before returning also free the allocated buttons pointer. fixes: #14247 closes: #14280 Signed-off-by: Christian Brabandt --- src/gui_motif.c | 3 +++ src/version.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/gui_motif.c b/src/gui_motif.c index 630082e981..ed721b52d0 100644 --- a/src/gui_motif.c +++ b/src/gui_motif.c @@ -2732,7 +2732,10 @@ gui_mch_dialog( // Motif. label = XmStringCreateLtoR((char *)message, STRING_TAG); if (label == NULL) + { + vim_free(buttons); return -1; + } w = XtVaCreateManagedWidget("dialogMessage", xmLabelGadgetClass, form, XmNlabelString, label, diff --git a/src/version.c b/src/version.c index 2061fec42e..0c053c5658 100644 --- a/src/version.c +++ b/src/version.c @@ -704,6 +704,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 210, /**/ 209, /**/