thac0/vim
1
0
Fork 0
forked from aniani/vim
Code

patch 8.1.1054: not checking return value of ga_grow()

Browse Source 
Problem:    Not checking return value of ga_grow(). (Coverity)
Solution:   Only append when ga_grow() returns OK.
This commit is contained in:
Bram Moolenaar 2019-03-26 21:44:20 +01:00
parent d6c3f1fa2b
commit 6fb5c97242
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/if_lua.c
View File

@ -1144,9 +1144,9 @@ luaV_blob_add(lua_State *L)
size_t i, l = 0;
const char *s = lua_tolstring(L, 2, &l);
ga_grow(&b->bv_ga, l);
for (i = 0; i < l; ++i)
ga_append(&b->bv_ga, s[i]);
if (ga_grow(&b->bv_ga, l) == OK)
for (i = 0; i < l; ++i)
ga_append(&b->bv_ga, s[i]);
}
lua_settop(L, 1);
return 1;
@ -1776,9 +1776,9 @@ luaV_blob(lua_State *L)
size_t i, l = 0;
const char *s = lua_tolstring(L, 1, &l);
ga_grow(&b->bv_ga, l);
for (i = 0; i < l; ++i)
ga_append(&b->bv_ga, s[i]);
if (ga_grow(&b->bv_ga, l) == OK)
for (i = 0; i < l; ++i)
ga_append(&b->bv_ga, s[i]);
}
}
return 1;

2
src/version.c
View File

@ -775,6 +775,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1054,
/**/
1053,
/**/