1
0
forked from aniani/vim

patch 8.2.0199: Vim9 script commands not sufficiently tested

Problem:    Vim9 script commands not sufficiently tested.
Solution:   Add more tests.  Fix script-local function use.
This commit is contained in:
Bram Moolenaar
2020-02-02 17:22:27 +01:00
parent 43c60eda2a
commit 0f18b6d17b
4 changed files with 58 additions and 11 deletions

View File

@@ -106,7 +106,7 @@ def Test_call_ufunc_count()
Increment() Increment()
" works with and without :call " works with and without :call
assert_equal(4, g:counter) assert_equal(4, g:counter)
call assert_equal(4, g:counter) assert_equal(4, g:counter)
unlet g:counter unlet g:counter
enddef enddef
@@ -354,7 +354,7 @@ def Test_fixed_size_list()
l->remove(0) l->remove(0)
l->add(5) l->add(5)
l->insert(99, 1) l->insert(99, 1)
call assert_equal([2, 99, 3, 4, 5], l) assert_equal([2, 99, 3, 4, 5], l)
enddef enddef
" Test that inside :function a Python function can be defined, :def is not " Test that inside :function a Python function can be defined, :def is not
@@ -387,15 +387,52 @@ enddef
def Test_compile_const_expr() def Test_compile_const_expr()
assert_equal("\nyes", execute('call HasEval()')) assert_equal("\nyes", execute('call HasEval()'))
let instr = execute('disassemble HasEval') let instr = execute('disassemble HasEval')
call assert_match('PUSHS "yes"', instr) assert_match('PUSHS "yes"', instr)
call assert_notmatch('PUSHS "no"', instr) assert_notmatch('PUSHS "no"', instr)
call assert_notmatch('JUMP', instr) assert_notmatch('JUMP', instr)
assert_equal("\nno", execute('call HasNothing()')) assert_equal("\nno", execute('call HasNothing()'))
instr = execute('disassemble HasNothing') instr = execute('disassemble HasNothing')
call assert_notmatch('PUSHS "yes"', instr) assert_notmatch('PUSHS "yes"', instr)
call assert_match('PUSHS "no"', instr) assert_match('PUSHS "no"', instr)
call assert_notmatch('JUMP', instr) assert_notmatch('JUMP', instr)
enddef
func NotCompiled()
echo "not"
endfunc
let s:scriptvar = 4
let g:globalvar = 'g'
def s:ScriptFunc(arg: string)
let local = 1
buffers
echo arg
echo local
echo v:version
echo s:scriptvar
echo g:globalvar
echo &tabstop
echo $ENVVAR
echo @z
enddef
def Test_disassemble()
assert_fails('disass NoFunc', 'E1061:')
assert_fails('disass NotCompiled', 'E1062:')
let res = execute('disass s:ScriptFunc')
assert_match('<SNR>\d*_ScriptFunc.*'
\ .. 'buffers.*'
\ .. ' EXEC \+buffers.*'
\ .. ' LOAD arg\[-1\].*'
\ .. ' LOAD $0.*'
\ .. ' LOADV v:version.*'
\ .. ' LOADS s:scriptvar from .*test_vim9_script.vim.*'
\ .. ' LOADG g:globalvar.*'
\ .. ' LOADENV $ENVVAR.*'
\ .. ' LOADREG @z.*', res)
enddef enddef

View File

@@ -1060,6 +1060,8 @@ call_user_func(
if (fp->uf_dfunc_idx >= 0) if (fp->uf_dfunc_idx >= 0)
{ {
estack_push_ufunc(ETYPE_UFUNC, fp, 1); estack_push_ufunc(ETYPE_UFUNC, fp, 1);
save_current_sctx = current_sctx;
current_sctx = fp->uf_script_ctx;
// Execute the compiled function. // Execute the compiled function.
call_def_function(fp, argcount, argvars, rettv); call_def_function(fp, argcount, argvars, rettv);
@@ -1067,6 +1069,7 @@ call_user_func(
current_funccal = fc->caller; current_funccal = fc->caller;
estack_pop(); estack_pop();
current_sctx = save_current_sctx;
free_funccal(fc); free_funccal(fc);
return; return;
} }

View File

@@ -742,6 +742,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
199,
/**/ /**/
198, 198,
/**/ /**/

View File

@@ -1502,21 +1502,26 @@ failed:
ex_disassemble(exarg_T *eap) ex_disassemble(exarg_T *eap)
{ {
#ifdef DISASSEMBLE #ifdef DISASSEMBLE
ufunc_T *ufunc = find_func(eap->arg, NULL); char_u *fname;
ufunc_T *ufunc;
dfunc_T *dfunc; dfunc_T *dfunc;
isn_T *instr; isn_T *instr;
int current; int current;
int line_idx = 0; int line_idx = 0;
int prev_current = 0; int prev_current = 0;
fname = trans_function_name(&eap->arg, FALSE,
TFN_INT | TFN_QUIET | TFN_NO_AUTOLOAD | TFN_NO_DEREF, NULL, NULL);
ufunc = find_func(fname, NULL);
vim_free(fname);
if (ufunc == NULL) if (ufunc == NULL)
{ {
semsg("Cannot find function %s", eap->arg); semsg("E1061: Cannot find function %s", eap->arg);
return; return;
} }
if (ufunc->uf_dfunc_idx < 0) if (ufunc->uf_dfunc_idx < 0)
{ {
semsg("Function %s is not compiled", eap->arg); semsg("E1062: Function %s is not compiled", eap->arg);
return; return;
} }
if (ufunc->uf_name_exp != NULL) if (ufunc->uf_name_exp != NULL)