1
0
forked from aniani/vim

patch 8.1.0073: crash when autocommands call setloclist()

Problem:    Crash when autocommands call setloclist(). (Dominique Pelle)
Solution:   If the quickfix list changes then don't jump to the error.
This commit is contained in:
Bram Moolenaar
2018-06-18 20:52:13 +02:00
parent dcdeaaf150
commit 0366c0161e
3 changed files with 18 additions and 3 deletions

View File

@@ -6348,9 +6348,11 @@ ex_cexpr(exarg_T *eap)
if (au_name != NULL) if (au_name != NULL)
apply_autocmds(EVENT_QUICKFIXCMDPOST, au_name, apply_autocmds(EVENT_QUICKFIXCMDPOST, au_name,
curbuf->b_fname, TRUE, curbuf); curbuf->b_fname, TRUE, curbuf);
if (res > 0 && (eap->cmdidx == CMD_cexpr || if (res > 0 && (eap->cmdidx == CMD_cexpr
eap->cmdidx == CMD_lexpr)) || eap->cmdidx == CMD_lexpr)
qf_jump(qi, 0, 0, eap->forceit); /* display first error */ && qi == ll_get_or_alloc_list(curwin))
// Jump to the first error if autocmds didn't free the list.
qf_jump(qi, 0, 0, eap->forceit);
} }
else else
EMSG(_("E777: String or List expected")); EMSG(_("E777: String or List expected"));

View File

@@ -3362,3 +3362,14 @@ func Test_lbuffer_with_bwipe()
au! au!
augroup END augroup END
endfunc endfunc
func Test_setloclist_in_aucmd()
" This was using freed memory.
augroup nasty
au * * call setloclist(0, [], 'f')
augroup END
lexpr "x"
augroup nasty
au!
augroup END
endfunc

View File

@@ -761,6 +761,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
73,
/**/ /**/
72, 72,
/**/ /**/