thac0/vim
1
0
Fork 0
forked from aniani/vim
Code Activity

patch 9.1.0121: Infinite loop or signed overflow with 'smoothscroll'

Browse Source 
Problem:  infinite loop in win_update with 'smoothscroll' set when
          window width is equal to textoff, or signed integer overflow
          if smaller.
Solution: don't revalidate wp->w_skipcol in that case, as no buffer text
          is being shown. (Sean Dewar)

Don't instead reset w_skipcol; that would lose the scroll position
within the line, which may be undesirable if the window is made wider
later.

Also include changes from the splitmove PR #14042 that I (in my infinite
Git wisdom) forgot to commit. This includes a change to
Test_window_split_no_room to ensure it doesn't fail for some screen
sizes.

Move Test_smoothscroll_in_zero_width_window to test_scroll_opt.vim, as
that file feels more appropriate.

closes: #14068

Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Sean Dewar
2024-02-21 19:40:44 +01:00
committed by Christian Brabandt
parent 3f905ab3c4
commit 02fcae02a9
6 changed files with 53 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/window.c
View File

@@ -54,7 +54,7 @@ static void win_goto_hor(int left, long count);
static void frame_add_height(frame_T *frp, int n);
static void last_status_rec(frame_T *fr, int statusline);
static void frame_flatten(frame_T *frp);
static void winframe_restore(win_T *wp, int dir, frame_T *to_flatten);
static void winframe_restore(win_T *wp, int dir, frame_T *unflat_altfr);
static int make_snapshot_rec(frame_T *fr, frame_T **frp);
static void clear_snapshot(tabpage_T *tp, int idx);