From c9609ea5ff66f226a2829ab4e00d2b2f8212e3b8 Mon Sep 17 00:00:00 2001 From: sin Date: Wed, 2 Jul 2014 12:03:01 +0100 Subject: [PATCH] Only call fwrite() and fclose() when fp is not NULL Spotted by Hiltjo. --- login.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/login.c b/login.c index ef6d501..aec561f 100644 --- a/login.c +++ b/login.c @@ -89,12 +89,14 @@ main(int argc, char *argv[]) usr.ut_tv.tv_sec = time(NULL); fp = fopen(UTMP_PATH, "a"); - if (!fp) + if (fp) { + if (fwrite(&usr, sizeof(usr), 1, fp) != 1) + if (ferror(fp)) + weprintf("%s: write error:", UTMP_PATH); + fclose(fp); + } else { weprintf("fopen %s:", UTMP_PATH); - if (fwrite(&usr, sizeof(usr), 1, fp) != 1) - if (ferror(fp)) - weprintf("%s: write error:", UTMP_PATH); - fclose(fp); + } return dologin(pw, pflag); }