Hiltjo Posthuma
29649762b3
libutil/getlines: fix potential crash
...
linelen was uninitialized if for example:
$ > empty
$ sort ls.c empty
2015-05-08 16:38:06 +01:00
Hiltjo Posthuma
3f01706837
libutil/getlines: use known line length
...
also style: linelen = length of getline(), this was slightly confusing.
2015-05-07 18:18:36 +01:00
Hiltjo Posthuma
adf9f47525
Revert "libutil/getlines: use known line length"
...
This reverts commit c69a70ddfd5c2b1514d9efd1c7a0fcbee5b0d2e7.
2015-05-07 18:18:36 +01:00
Hiltjo Posthuma
bd67e7d92d
libutil/getlines: use known line length
2015-05-07 18:18:35 +01:00
Hiltjo Posthuma
27f258dd34
libutil/getlines: style fix
2015-03-29 21:55:34 +02:00
Hiltjo Posthuma
9f97430143
libutil/getlines: fix crash with no lines
...
because b->lines and b->nlines would be 0 with no lines read.
reproduce: printf '' | sort or cols
bug was introduced by commit: 66a5ea722d
2015-03-29 21:48:49 +02:00
FRIGN
9144d51594
Check getline()-return-values properly
...
It's not useful when 0 is returned anyway, so be sure that we have a
string with length > 0, this also solves some indexing-gotchas like
"len - 1" and so on.
Also, add checked getline()'s whenever it has been forgotten and
clean up the error-messages.
2015-03-27 14:49:48 +01:00
sin
113caaf677
Make getlines() less verbose
...
Thanks Roberto for the suggestion.
2015-02-12 14:34:07 +00:00
sin
51680535ce
getlines: Style fix
2015-02-11 00:27:30 +00:00
Jakob Kramer
66a5ea722d
getlines: last line of file should always have a newline
...
This is a useful behavior if you want to reorder the lines,
because otherwise you might end up with originally two lines
on one, e.g.
$ echo -ne "foo\nbar" | sort
barfoo
2015-02-11 00:25:48 +00:00
Evan Gates
84b08427a1
remove agetline
2014-11-18 21:05:28 +00:00
sin
027052f5e5
Rename util/ to libutil/
2014-11-17 16:48:34 +00:00