Merge pull request #20 from melloc/nf-self-assign

Fix issues with NF self-assignment and setting NF to negative values

bugs-fixed/README

@@ -51,3 +51,4 @@ array passed as the second argument, then split() would previously read
 from the freed memory and possibly produce incorrect results (depending
 on the system's malloc()/free() behaviour.)
 
+

bugs-fixed/negative-nf.awk

@@ -0,0 +1 @@
+BEGIN { NF = -5; }

bugs-fixed/negative-nf.ok

@@ -0,0 +1,2 @@
+./a.out: cannot set NF to a negative value
+ source line number 1

bugs-fixed/nf-self-assign.awk

@@ -0,0 +1,6 @@
+BEGIN {
+	$0="a b c";
+	OFS=",";
+	NF = NF;
+	print;
+}

bugs-fixed/nf-self-assign.bad

@@ -0,0 +1 @@
+a b c

bugs-fixed/nf-self-assign.ok

@@ -0,0 +1 @@
+a,b,c

lib.c

@@ -393,6 +393,8 @@ void newfld(int n)	/* add field n after end of existing lastfld */
 
 void setlastfld(int n)	/* set lastfld cleaning fldtab cells if necessary */
 {
+	if (n < 0)
+		FATAL("cannot set NF to a negative value");
 	if (n > nfields)
 		growfldtab(n);
 

run.c

@@ -1123,8 +1123,8 @@ Cell *assign(Node **a, int n)	/* a[0] = a[1], a[0] += a[1], etc. */
 	y = execute(a[1]);
 	x = execute(a[0]);
 	if (n == ASSIGN) {	/* ordinary assignment */
-		if (x == y && !(x->tval & (FLD|REC)))	/* self-assignment: */
+		if (x == y && !(x->tval & (FLD|REC)) && x != nfloc)
-			;		/* leave alone unless it's a field */
+			;	/* self-assignment: leave alone unless it's a field or NF */
 		else if ((y->tval & (STR|NUM)) == (STR|NUM)) {
 			setsval(x, getsval(y));
 			x->fval = getfval(y);