jchenry/x
1
0
Fork 0
Code Issues Pull Requests Actions Releases Wiki Activity

sped up mappedParam by removing joins and splits

Browse Source
This commit is contained in:
Colin Henry 2022-09-15 21:28:19 -07:00
parent 593c8db66e
commit 7cf53a2f2d
1 changed files with 11 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
net/http/params.go
View File

@ -9,7 +9,6 @@ import (
"net/http" "net/http"
"net/url" "net/url"
"strconv" "strconv"
"strings"
) )
func PathParam(ctx context.Context, Param func(ctx context.Context, paramName string) string, p interface{}, paramName string, required bool) (err error) { func PathParam(ctx context.Context, Param func(ctx context.Context, paramName string) string, p interface{}, paramName string, required bool) (err error) {
@ -48,52 +47,41 @@ func BodyParam(body io.ReadCloser, p any, v func(p any) error) (err error) {
} }
func mappedParam(m map[string][]string, paramName string, p interface{}, required bool) (err error) { func mappedParam(m map[string][]string, paramName string, p interface{}, required bool) (err error) {
var s string s, exists := m[paramName]
q, exists := m[paramName]
if !exists { // intentionally left empty
} else if len(q) > 1 {
s = strings.Join(q, ",")
} else {
s = q[0]
}
if s == "" && required { if !exists && required {
return errors.New("missing required parameter") return errors.New("missing required parameter")
} }
switch v := p.(type) { switch v := p.(type) {
case *int64: case *int64:
*v, err = strconv.ParseInt(s, 10, 64) *v, err = strconv.ParseInt(s[0], 10, 64)
case *int32: case *int32:
var x int64 var x int64
x, err = strconv.ParseInt(s, 10, 32) x, err = strconv.ParseInt(s[0], 10, 32)
*v = int32(x) *v = int32(x)
case *bool: case *bool:
*v, err = strconv.ParseBool(s) *v, err = strconv.ParseBool(s[0])
case *string: case *string:
*v = s *v = s[0]
case *[]int64: case *[]int64:
str := strings.Split(s, ",") for _, i := range s {
for _, s := range str { if e, err := strconv.ParseInt(i, 10, 64); err != nil {
if e, err := strconv.ParseInt(s, 10, 64); err != nil {
return err return err
} else { } else {
*v = append(*v, e) *v = append(*v, e)
// ints[i] = e
} }
} }
case *[]int32: case *[]int32:
str := strings.Split(s, ",") for _, i := range s {
for _, s := range str { if e, err := strconv.ParseInt(i, 10, 32); err != nil {
if e, err := strconv.ParseInt(s, 10, 32); err != nil {
return err return err
} else { } else {
*v = append(*v, int32(e)) *v = append(*v, int32(e))
// ints[i] = e
} }
} }
case *[]string: case *[]string:
*v = strings.Split(s, ",") *v = s
default: default:
err = fmt.Errorf("no match for pointer type %T", v) err = fmt.Errorf("no match for pointer type %T", v)
} }