Merge pull request #1124 from gucio321/golangci-lint-update

all: fix lint errors

.golangci.yml

@@ -32,6 +32,8 @@ linters-settings:
       # to possibly non-intuitive layout of struct fields (harder to read). Disable
       # `fieldalignment` check here until we evaluate if it is worthwhile.
       - fieldalignment
+      # https://github.com/golangci/golangci-lint/issues/1973
+      - sigchanyzer
   lll:
     line-length: 140
   misspell:
@@ -68,7 +70,6 @@ linters:
     - nakedret
     - prealloc
     - rowserrcheck
-    - scopelint
     - staticcheck
     - structcheck
     - stylecheck

d2common/d2fileformats/d2ds1/ds1_layers.go

@@ -228,8 +228,7 @@ func (l *ds1Layers) insert(t LayerGroupType, idx int, newLayer *Layer) {
 	//		idx=1
 	//		newLayer=c
 	// 		existing layerGroup is [a, b]
-	newGroup := append((*group)[:idx], append([]*Layer{newLayer}, (*group)[idx:]...)...)
-	*group = newGroup
+	*group = append((*group)[:idx], append([]*Layer{newLayer}, (*group)[idx:]...)...)
 }
 
 func (l *ds1Layers) delete(t LayerGroupType, idx int) {

d2core/d2records/set_item_loader.go

@@ -84,6 +84,8 @@ func setItemLoader(r *RecordManager, d *d2txt.DataDictionary) error {
 		}
 
 		record.Properties = props
+		record.SetPropertiesLevel1 = bonus1
+		record.SetPropertiesLevel2 = bonus2
 
 		records[record.SetItemKey] = record
 	}

d2game/d2player/party_panel.go

@@ -97,6 +97,7 @@ func NewPartyPanel(asset *d2asset.AssetManager,
 	}
 
 	pp.partyIndexes = partyIndexes
+	pp.indexes = indexes
 
 	pp.Logger = d2util.NewLogger()
 	pp.Logger.SetLevel(l)
@@ -231,7 +232,7 @@ func (pi *partyIndex) setNameTooltipText() {
 
 // setColor sets appropriate labels' colors
 func (pi *partyIndex) setColor(relations d2enum.PlayersRelationships) {
-	var color = d2util.Color(white)
+	color := d2util.Color(white)
 
 	switch relations {
 	case d2enum.PlayerRelationEnemy: