gravestench/OpenDiablo2
1
1
Fork 0
mirror of https://github.com/OpenDiablo2/OpenDiablo2 synced 2025-02-04 07:37:48 -05:00
Code Issues Releases Wiki Activity

removed links to closed issues from code (#1005)

Browse Source 
Co-authored-by: M. Sz <mszeptuch@protonmail.com>
Co-authored-by: gravestench <dknuth0101@gmail.com>
This commit is contained in:
gucio321 2021-01-07 06:48:12 +01:00 committed by GitHub
parent b77d793698
commit 6addf7a243
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
d2common/d2enum/numeric_labels.go
View File

@ -2,7 +2,9 @@ package d2enum
// there are labels for "numeric labels (see AssetManager.TranslateLabel) // there are labels for "numeric labels (see AssetManager.TranslateLabel)
const ( const (
CancelLabel = iota RepairAll = iota
_
CancelLabel
CopyrightLabel CopyrightLabel
AllRightsReservedLabel AllRightsReservedLabel
SinglePlayerLabel SinglePlayerLabel
@ -62,6 +64,8 @@ const (
// BaseLabelNumbers returns base label value (#n in english string table table) // BaseLabelNumbers returns base label value (#n in english string table table)
func BaseLabelNumbers(idx int) int { func BaseLabelNumbers(idx int) int {
baseLabelNumbers := []int{ baseLabelNumbers := []int{
128, // repairAll
127,
// main menu labels // main menu labels
1612, // CANCEL 1612, // CANCEL
1613, // (c) 2000 Blizzard Entertainment 1613, // (c) 2000 Blizzard Entertainment

1
d2core/d2inventory/inventory_item_factory.go
View File

@ -136,7 +136,6 @@ func (f *InventoryItemFactory) GetMiscItemByCode(code string) (*InventoryItemMis
// GetWeaponItemByCode returns the weapon item for the given code // GetWeaponItemByCode returns the weapon item for the given code
func (f *InventoryItemFactory) GetWeaponItemByCode(code string) (*InventoryItemWeapon, error) { func (f *InventoryItemFactory) GetWeaponItemByCode(code string) (*InventoryItemWeapon, error) {
// https://github.com/OpenDiablo2/OpenDiablo2/issues/796
result := f.asset.Records.Item.Weapons[code] result := f.asset.Records.Item.Weapons[code]
if result == nil { if result == nil {
return nil, fmt.Errorf("could not find weapon entry for code '%s'", code) return nil, fmt.Errorf("could not find weapon entry for code '%s'", code)

1
d2core/d2map/d2mapentity/factory.go
View File

@ -237,7 +237,6 @@ func (f *MapEntityFactory) NewCastOverlay(x, y int, overlayRecord *d2records.Ove
return nil, err return nil, err
} }
// https://github.com/OpenDiablo2/OpenDiablo2/issues/767
animation.Rewind() animation.Rewind()
animation.ResetPlayedCount() animation.ResetPlayedCount()

4
d2core/d2ui/button.go
View File

@ -863,8 +863,6 @@ type buttonStateDescriptor struct {
func (v *Button) createTooltip() { func (v *Button) createTooltip() {
var t *Tooltip var t *Tooltip
// this is also related with https://github.com/OpenDiablo2/OpenDiablo2/issues/944
// all strings starting with "#" could be wrong translated to another locales
switch v.buttonLayout.Tooltip { switch v.buttonLayout.Tooltip {
case buttonTooltipNone: case buttonTooltipNone:
return return
@ -885,7 +883,7 @@ func (v *Button) createTooltip() {
t.SetText(v.manager.asset.TranslateString("NPCRepairItems")) t.SetText(v.manager.asset.TranslateString("NPCRepairItems"))
case buttonTooltipRepairAll: case buttonTooltipRepairAll:
t = v.manager.NewTooltip(d2resource.Font16, d2resource.PaletteSky, TooltipXCenter, TooltipYBottom) t = v.manager.NewTooltip(d2resource.Font16, d2resource.PaletteSky, TooltipXCenter, TooltipYBottom)
t.SetText(v.manager.asset.TranslateString("#128")) t.SetText(v.manager.asset.TranslateLabel(d2enum.RepairAll))
case buttonTooltipLeftArrow: case buttonTooltipLeftArrow:
t = v.manager.NewTooltip(d2resource.Font16, d2resource.PaletteSky, TooltipXCenter, TooltipYBottom) t = v.manager.NewTooltip(d2resource.Font16, d2resource.PaletteSky, TooltipXCenter, TooltipYBottom)
t.SetText(v.manager.asset.TranslateString("KeyLeft")) t.SetText(v.manager.asset.TranslateString("KeyLeft"))

2
d2game/d2player/hud.go
View File

@ -258,7 +258,6 @@ func (h *HUD) loadCustomWidgets() {
} }
func (h *HUD) loadSkillResources() { func (h *HUD) loadSkillResources() {
// https://github.com/OpenDiablo2/OpenDiablo2/issues/799
genericSkillsSprite, err := h.uiManager.NewSprite(d2resource.GenericSkills, d2resource.PaletteSky) genericSkillsSprite, err := h.uiManager.NewSprite(d2resource.GenericSkills, d2resource.PaletteSky)
if err != nil { if err != nil {
h.Error(err.Error()) h.Error(err.Error())
@ -376,7 +375,6 @@ func (h *HUD) onToggleRunButton(noButton bool) {
h.hero.ToggleRunWalk() h.hero.ToggleRunWalk()
h.updateRunTooltipText() h.updateRunTooltipText()
// https://github.com/OpenDiablo2/OpenDiablo2/issues/800
h.hero.SetIsRunning(h.hero.IsRunToggled()) h.hero.SetIsRunning(h.hero.IsRunToggled())
} }