cBlockInfo static initialisation (#3832)

src/BlockInfo.h

@@ -19,20 +19,8 @@ public:
 	/** Returns the associated BlockInfo structure for the specified block type. */
 
 	/** This accessor makes sure that the cBlockInfo structures are properly initialized exactly once.
-	It does so by using the C++ singleton approximation - storing the actual singleton as the function's static variable.
+	It does so by using the C++ singleton approximation - storing the actual singleton as the function's static variable. */
-	It works only if it is called for the first time before the app spawns other threads. */
+	static cBlockInfo & Get(BLOCKTYPE a_Type);
-	static cBlockInfo & Get(BLOCKTYPE a_Type)
-	{
-		static cBlockInfo ms_Info[256];
-		static bool IsBlockInfoInitialized = false;
-		if (!IsBlockInfoInitialized)
-		{
-			cBlockInfo::Initialize(ms_Info);
-			IsBlockInfoInitialized = true;
-		}
-		return ms_Info[a_Type];
-	}
-
 
 	/** How much light do the blocks emit on their own? */
 	NIBBLETYPE m_LightValue;
@@ -75,8 +63,14 @@ public:
 
 	// tolua_end
 
+	/** Custom deleter allows cBlockHandler to be an incomplete type. */
+	struct sHandlerDeleter
+	{
+		void operator () (cBlockHandler * a_Handler);
+	};
+
 	/** Associated block handler. */
-	cBlockHandler * m_Handler;
+	std::unique_ptr<cBlockHandler, sHandlerDeleter> m_Handler;
 
 	// tolua_begin
 
@@ -96,11 +90,7 @@ public:
 
 	// tolua_end
 
-	inline static cBlockHandler * GetHandler      (BLOCKTYPE a_Type) { return Get(a_Type).m_Handler;             }
+	inline static cBlockHandler * GetHandler      (BLOCKTYPE a_Type) { return Get(a_Type).m_Handler.get();       }
-
-protected:
-	/** Storage for all the BlockInfo structures. */
-	typedef cBlockInfo cBlockInfoArray[256];
 
 	/** Creates a default BlockInfo structure, initializes all values to their defaults */
 	cBlockInfo()
@@ -115,26 +105,46 @@ protected:
 		, m_FullyOccupiesVoxel(false)
 		, m_CanBeTerraformed(false)
 		, m_BlockHeight(1.0)
-		, m_PlaceSound("")
+		, m_PlaceSound()
 		, m_Hardness(0.0f)
-		, m_Handler(nullptr)
+		, m_Handler()
 	{}
 
-	/** Cleans up the stored values */
+private:
-	~cBlockInfo();
+	/** Storage for all the BlockInfo structures. */
-
+	class cBlockInfoArray;
-	/** Initializes the specified BlockInfo structures with block-specific values. */
-	static void Initialize(cBlockInfoArray & a_BlockInfos);
 };  // tolua_export
 
 
 
 
 
+class cBlockInfo::cBlockInfoArray:
+	public std::array<cBlockInfo, 256>
+{
+public:
+	/** Initializes the contained BlockInfo structures with block-specific values. */
+	cBlockInfoArray();
+};
+
+
+
+
+
+inline cBlockInfo & cBlockInfo::Get(BLOCKTYPE a_Type)
+{
+	static cBlockInfoArray ms_Info;
+	return ms_Info[a_Type];
+}
+
+
+
+
+
 // Shortcut to get the blockhandler for a specific block
 inline cBlockHandler * BlockHandler(BLOCKTYPE a_BlockType)
 {
-	return cBlockInfo::Get(a_BlockType).m_Handler;
+	return cBlockInfo::Get(a_BlockType).m_Handler.get();
 }
 
 

src/Blocks/BlockPlant.h

@@ -101,7 +101,7 @@ protected:
 				// If the chunk we are trying to get the block information from is loaded
 				if (a_Chunk.UnboundedRelGetBlock(a_RelX + x, a_RelY, a_RelZ + z, Block, Meta))
 				{
-					cBlockHandler * Handler = cBlockInfo::Get(Block).m_Handler;
+					cBlockHandler * Handler = BlockHandler(Block);
 
 					// If the block affects growth, add to the adjustment
 					if (Handler->CanSustainPlant(m_BlockType))

tests/Generating/Stubs.cpp

@@ -85,21 +85,23 @@ extern "C" int luaopen_lxp(lua_State * a_LuaState)
 
 
 
-cBlockInfo::~cBlockInfo()
+void cBlockInfo::sHandlerDeleter::operator () (cBlockHandler * a_Handler)
 {
+	delete a_Handler;
 }
 
 
 
 
 
-void cBlockInfo::Initialize(cBlockInfo::cBlockInfoArray & a_BlockInfos)
+cBlockInfo::cBlockInfoArray::cBlockInfoArray()
 {
+	cBlockInfoArray & BlockInfos = *this;
 	// The piece-loading code uses the handlers for rotations, so we need valid handlers
 	// Insert dummy handlers:
-	for (size_t i = 0; i < ARRAYCOUNT(a_BlockInfos); i++)
+	for (size_t i = 0; i < BlockInfos.size(); i++)
 	{
-		a_BlockInfos[i].m_Handler = new cBlockHandler(static_cast<BLOCKTYPE>(i));
+		BlockInfos[i].m_Handler.reset(new cBlockHandler(static_cast<BLOCKTYPE>(i)));
 	}
 }
 

tests/LuaThreadStress/Stubs.cpp

@@ -85,21 +85,23 @@ extern "C" int luaopen_lxp(lua_State * a_LuaState)
 
 
 
-cBlockInfo::~cBlockInfo()
+void cBlockInfo::sHandlerDeleter::operator () (cBlockHandler * a_Handler)
 {
+	delete a_Handler;
 }
 
 
 
 
 
-void cBlockInfo::Initialize(cBlockInfo::cBlockInfoArray & a_BlockInfos)
+cBlockInfo::cBlockInfoArray::cBlockInfoArray()
 {
+	cBlockInfoArray & BlockInfos = *this;
 	// The piece-loading code uses the handlers for rotations, so we need valid handlers
 	// Insert dummy handlers:
-	for (size_t i = 0; i < ARRAYCOUNT(a_BlockInfos); i++)
+	for (size_t i = 0; i < BlockInfos.size(); i++)
 	{
-		a_BlockInfos[i].m_Handler = new cBlockHandler(static_cast<BLOCKTYPE>(i));
+		BlockInfos[i].m_Handler.reset(new cBlockHandler(static_cast<BLOCKTYPE>(i)));
 	}
 }
 

tests/SchematicFileSerializer/Stubs.cpp

@@ -13,21 +13,23 @@
 
 
 
-cBlockInfo::~cBlockInfo()
+void cBlockInfo::sHandlerDeleter::operator () (cBlockHandler * a_Handler)
 {
+	delete a_Handler;
 }
 
 
 
 
 
-void cBlockInfo::Initialize(cBlockInfo::cBlockInfoArray & a_BlockInfos)
+cBlockInfo::cBlockInfoArray::cBlockInfoArray()
 {
+	cBlockInfoArray & BlockInfos = *this;
 	// The piece-loading code uses the handlers for rotations, so we need valid handlers
 	// Insert dummy handlers:
-	for (size_t i = 0; i < ARRAYCOUNT(a_BlockInfos); i++)
+	for (size_t i = 0; i < BlockInfos.size(); i++)
 	{
-		a_BlockInfos[i].m_Handler = new cBlockHandler(static_cast<BLOCKTYPE>(i));
+		BlockInfos[i].m_Handler.reset(new cBlockHandler(static_cast<BLOCKTYPE>(i)));
 	}
 }