flewkey/cuberite-2a
1
0
Fork 0
Code Releases Activity

Fixed CppCheck: (performance) Possible inefficient checking for emptiness.

Browse Source
This commit is contained in:
Kirill Kirilenko 2015-01-17 15:12:14 +03:00
parent 2ce2741968
commit 3dc994f9dc
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/LightingThread.cpp
View File

@ -197,7 +197,7 @@ void cLightingThread::Execute(void)
{ {
{ {
cCSLock Lock(m_CS); cCSLock Lock(m_CS);
if (m_Queue.size() == 0) if (m_Queue.empty())
{ {
cCSUnlock Unlock(Lock); cCSUnlock Unlock(Lock);
m_evtItemAdded.Wait(); m_evtItemAdded.Wait();

2
src/MobProximityCounter.cpp
View File

@ -50,7 +50,7 @@ cMobProximityCounter::sIterablePair cMobProximityCounter::getMobWithinThosesDist
a_DistanceMin *= a_DistanceMin;// this is because is use square distance a_DistanceMin *= a_DistanceMin;// this is because is use square distance
a_DistanceMax *= a_DistanceMax; a_DistanceMax *= a_DistanceMax;
if (m_DistanceToMonster.size() <= 0) if (m_DistanceToMonster.empty())
{ {
convertMaps(); convertMaps();
} }

4
src/OSSupport/Queue.h
View File

@ -86,7 +86,7 @@ public:
bool TryDequeueItem(ItemType & item) bool TryDequeueItem(ItemType & item)
{ {
cCSLock Lock(m_CS); cCSLock Lock(m_CS);
if (m_Contents.size() == 0) if (m_Contents.empty())
{ {
return false; return false;
} }
@ -101,7 +101,7 @@ public:
ItemType DequeueItem(void) ItemType DequeueItem(void)
{ {
cCSLock Lock(m_CS); cCSLock Lock(m_CS);
while (m_Contents.size() == 0) while (m_Contents.empty())
{ {
cCSUnlock Unlock(Lock); cCSUnlock Unlock(Lock);
m_evtAdded.Wait(); m_evtAdded.Wait();

2
src/Server.cpp
View File

@ -764,7 +764,7 @@ void cServer::cNotifyWriteThread::Execute(void)
while (!m_ShouldTerminate) while (!m_ShouldTerminate)
{ {
cCSLock Lock(m_CS); cCSLock Lock(m_CS);
while (m_Clients.size() == 0) while (m_Clients.empty())
{ {
cCSUnlock Unlock(Lock); cCSUnlock Unlock(Lock);
m_Event.Wait(); m_Event.Wait();