Rewritten string case manipulation to use std::transform.

src/StringUtils.cpp

@@ -198,14 +198,7 @@ AString TrimString(const AString & str)
 
 AString & StrToUpper(AString & s)
 {
-	AString::iterator i = s.begin();
+	std::transform(s.begin(), s.end(), s.begin(), ::toupper);
-	AString::iterator end = s.end();
-
-	while (i != end)
-	{
-		*i = (char)toupper(*i);
-		++i;
-	}
 	return s;
 }
 
@@ -215,14 +208,7 @@ AString & StrToUpper(AString & s)
 
 AString & StrToLower(AString & s)
 {
-	AString::iterator i = s.begin();
+	std::transform(s.begin(), s.end(), s.begin(), ::tolower);
-	AString::iterator end = s.end();
-
-	while (i != end)
-	{
-		*i = (char)tolower(*i);
-		++i;
-	}
 	return s;
 }
 
@@ -232,12 +218,8 @@ AString & StrToLower(AString & s)
 
 AString StrToLower(const AString & s)
 {
-	AString res;
+	AString res(s);
-	res.resize(s.size());
+	std::transform(res.begin(), res.end(), res.begin(), ::tolower);
-	for (AString::iterator itr = res.begin(), end = res.end(); itr != end; ++itr)
-	{
-		*itr = (char)tolower(*itr);
-	}
 	return res;
 }