Yegappan Lakshmanan
a41e221935
patch 9.0.1208: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11819 )
2023-01-16 18:19:05 +00:00
Bram Moolenaar
6d4b2f54df
patch 9.0.0263: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Make some functions always available.
2022-08-25 15:11:15 +01:00
Bram Moolenaar
a4d158b3c8
patch 9.0.0206: redraw flags are not named specifically
...
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
2022-08-14 14:17:45 +01:00
Bram Moolenaar
fa4873ccfc
patch 9.0.0013: reproducing memory access errors can be difficult
...
Problem: Reproducing memory access errors can be difficult.
Solution: When testing, copy each line to allocated memory, so that valgrind
can detect accessing memory before and/or after it. Fix uncovered
problems.
2022-06-30 22:13:59 +01:00
zeertzjq
44068e97db
patch 8.2.5106: default cmdwin mappings are re-mappable
...
Problem: Default cmdwin mappings are re-mappable.
Solution: Make the default mappings not re-mappable. (closes #10580 ) Use
symbols for the first do_map() argument.
2022-06-16 11:14:55 +01:00
Bram Moolenaar
249591057b
patch 8.2.4911: the mode #defines are not clearly named
...
Problem: The mode #defines are not clearly named.
Solution: Prepend MODE_. Renumber them to put the mapped modes first.
2022-05-07 20:01:16 +01:00
Bram Moolenaar
d88be5be80
patch 8.2.4003: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-04 19:57:55 +00:00
Bram Moolenaar
1d423ef75f
patch 8.2.3987: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 21:26:16 +00:00
Bram Moolenaar
b09feaa86e
patch 8.2.3986: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 20:20:45 +00:00
Bram Moolenaar
651fca85c7
patch 8.2.3699: the +title feature adds a lot of #ifdef but little code
...
Problem: The +title feature adds a lot of #ifdef but little code.
Solution: Graduate the +title feature.
2021-11-29 20:39:38 +00:00
Bram Moolenaar
0526815c15
patch 8.2.3617: ":verbose pwd" does not mention 'autochdir' was applied
...
Problem: ":verbose pwd" does not mention 'autochdir' was applied.
Solution: Remember the last chdir was done by 'autochdir'. (issue #9142 )
2021-11-18 18:53:45 +00:00
Leah Neukirchen
0a7984af56
patch 8.2.3510: changes are only detected with one second accuracy
...
Problem: Changes are only detected with one second accuracy.
Solution: Use the nanosecond time if possible. (Leah Neukirchen,
closes #8873 , closes #8875 )
2021-10-14 21:27:55 +01:00
Bram Moolenaar
952d9d827e
patch 8.2.3274: macro for printf format check can be simplified
...
Problem: Macro for printf format check can be simplified.
Solution: Add ATTRIBUTE_FORMAT_PRINTF(). (Dominique Pellé, issue #8635 )
2021-08-02 18:07:18 +02:00
Bram Moolenaar
32e5ec0b01
patch 8.2.1962: netbeans may access freed memory
...
Problem: Netbeans may access freed memory.
Solution: Check the buffer pointer is still valid. Add a test. (Yegappan
Lakshmanan, closes #7248 )
2020-11-06 13:44:21 +01:00
Bram Moolenaar
b9616af23f
patch 8.2.1843: Netbeans: with huge buffer number memory allocation may fail
...
Problem: Netbeans: with huge buffer number memory allocation may fail.
Solution: Check for size overflow.
2020-10-13 21:11:13 +02:00
Bram Moolenaar
173d841e86
patch 8.2.0599: Netbeans interface insufficiently tested
...
Problem: Netbeans interface insufficiently tested.
Solution: Add more tests. (Yegappan Lakshmanan, closes #5921 )
2020-04-19 14:02:26 +02:00
Bram Moolenaar
a80faa8930
patch 8.2.0559: clearing a struct is verbose
...
Problem: Clearing a struct is verbose.
Solution: Define and use CLEAR_FIELD() and CLEAR_POINTER().
2020-04-12 19:37:17 +02:00
Bram Moolenaar
aeea72151c
patch 8.2.0500: using the same loop in many places
...
Problem: Using the same loop in many places.
Solution: Define more FOR_ALL macros. (Yegappan Lakshmanan, closes #5339 )
2020-04-02 18:50:46 +02:00
Bram Moolenaar
6e0ce171e1
patch 8.1.2392: using old C style comments
...
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
2019-12-05 20:12:41 +01:00
Bram Moolenaar
6656c2ec4c
patch 8.1.2205: sign entry structure has confusing name
...
Problem: Sign entry structure has confusing name.
Solution: Rename signlist_T to sign_entry_T and prefix se_ to the fields.
2019-10-24 15:00:04 +02:00
Bram Moolenaar
ea7ecfe2a0
patch 8.1.1889: Coverity warns for using a NULL pointer
...
Problem: Coverity warns for using a NULL pointer.
Solution: Use zero for column if pos is NULL.
2019-08-19 20:08:15 +02:00
Bram Moolenaar
c799fe206e
patch 8.1.1414: alloc() returning "char_u *" causes a lot of type casts
...
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
2019-05-28 23:08:19 +02:00
Bram Moolenaar
18a4ba29ae
patch 8.1.1386: unessesary type casts for lalloc()
...
Problem: Unessesary type casts for lalloc().
Solution: Remove type casts. Change lalloc(size, TRUE) to alloc(size).
2019-05-24 19:39:03 +02:00
Bram Moolenaar
964b3746b9
patch 8.1.1384: using "int" for alloc() often results in compiler warnings
...
Problem: Using "int" for alloc() often results in compiler warnings.
Solution: Use "size_t" and remove type casts. Remove alloc_check(), Vim
only works with 32 bit ints anyway.
2019-05-24 18:54:09 +02:00
Bram Moolenaar
abab0b0fdd
patch 8.1.1086: too many curly braces
...
Problem: Too many curly braces.
Solution: Remove curly braces where they are not needed. (Hirohito Higashi,
closes #3982 )
2019-03-30 18:47:01 +01:00
Bram Moolenaar
c85c8fcb9f
patch 8.1.0944: format of nbdbg() arguments is not checked
...
Problem: Format of nbdbg() arguments is not checked.
Solution: Add format attribute. Fix reported problems. (Dominique Pelle,
closes #3992 )
2019-02-17 19:12:21 +01:00
Bram Moolenaar
4f97475d32
patch 8.1.0941: macros for MS-Windows are inconsistent
...
Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and
others.
Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the
GUI build. (Hirohito Higashi, closes #3932 )
2019-02-17 17:44:42 +01:00
Bram Moolenaar
29ddebef40
patch 8.1.0826: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate FEAT_VIRTUALEDIT. Adds about 10Kbyte to the code.
2019-01-26 17:28:26 +01:00
Bram Moolenaar
32526b3c18
patch 8.1.0779: argument for message functions is inconsistent
...
Problem: Argument for message functions is inconsistent.
Solution: Make first argument to msg() "char *".
2019-01-19 17:43:09 +01:00
Bram Moolenaar
bb1969b6ab
patch 8.1.0763: nobody is using the Sun Workshop support
...
Problem: Nobody is using the Sun Workshop support.
Solution: Remove the Workshop support.
2019-01-17 15:45:25 +01:00
Bram Moolenaar
b5443cc46d
patch 8.1.0753: printf format not checked for semsg()
...
Problem: printf format not checked for semsg().
Solution: Add GNUC attribute and fix reported problems. (Dominique Pelle,
closes #3805 )
2019-01-15 20:19:40 +01:00
Bram Moolenaar
f9e3e09fdc
patch 8.1.0743: giving error messages is not flexible
...
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
#3302 ) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
2019-01-13 23:38:42 +01:00
Bram Moolenaar
6e5ea8d2a9
patch 8.1.0735: cannot handle binary data
...
Problem: Cannot handle binary data.
Solution: Add the Blob type. (Yasuhiro Matsumoto, closes #3638 )
2019-01-12 22:47:31 +01:00
Bram Moolenaar
7d83bf4f2b
patch 8.1.0658: deleting signs and completion for :sign is insufficient
...
Problem: Deleting signs and completion for :sign is insufficient.
Solution: Add deleting signs in a specified or any group from the current
cursor location. Add group and priority to sign command
completion. Add tests for different sign unplace commands. Update
help text. Add tests for sign jump with group. Update help for
sign jump. (Yegappan Lakshmanan, closes #3731 )
2018-12-29 18:53:55 +01:00
Bram Moolenaar
162b71479b
patch 8.1.0614: placing signs can be complicated
...
Problem: Placing signs can be complicated.
Solution: Add functions for defining and placing signs. Introduce a group
name to avoid different plugins using the same signs. (Yegappan
Lakshmanan, closes #3652 )
2018-12-21 15:17:36 +01:00
Bram Moolenaar
6dff58f15c
patch 8.1.0443: unnecessary static function prototypes
...
Problem: Unnecessary static function prototypes.
Solution: Remove unnecessary prototypes.
2018-09-30 21:43:26 +02:00
Bram Moolenaar
42335f50bc
patch 8.1.0377: xdiff doesn't use the Vim memory allocation functions
...
Problem: Xdiff doesn't use the Vim memory allocation functions.
Solution: Change the xdl_ defines. Check for out-of-memory. Rename
"ignored" to "vim_ignored".
2018-09-13 15:33:43 +02:00
Bram Moolenaar
f2bd8ef2b4
patch 8.0.1564: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate the +autocmd feature. Takes away 450 #ifdefs and
increases code size of tiny Vim by only 40 Kbyte.
2018-03-04 18:08:14 +01:00
Bram Moolenaar
d23a823669
patch 8.0.1496: clearing a pointer takes two lines
...
Problem: Clearing a pointer takes two lines.
Solution: Add VIM_CLEAR() and replace vim_clear(). (Hirohito Higashi,
closes #2629 )
2018-02-10 18:45:26 +01:00
Bram Moolenaar
b7407d3fc9
patch 8.0.1459: cannot handle change of directory
...
Problem: Cannot handle change of directory.
Solution: Add the DirChanged autocommand event. (Andy Massimino,
closes #888 ) Avoid changing directory for 'autochdir' too often.
2018-02-03 17:36:27 +01:00
Bram Moolenaar
a338adcf22
patch 8.0.1449: slow redrawing with DirectX
...
Problem: Slow redrawing with DirectX.
Solution: Avoid calling gui_mch_flush() unnecessarily, especially when
updating the cursor. (Ken Takata, closes #2560 )
2018-01-31 20:51:47 +01:00
Bram Moolenaar
c3719bd87b
patch 8.0.1312: balloon_show() only works in terminal when compiled with GUI
...
Problem: balloon_show() only works in terminal when compiled with the GUI.
Solution: Add FEAT_BEVAL_GUI and refactor to move common code out of the GUI
specific file.
2017-11-18 22:13:31 +01:00
Bram Moolenaar
53f8174eae
patch 8.0.1135: W_WINCOL() is always the same
...
Problem: W_WINCOL() is always the same.
Solution: Expand the macro.
2017-09-22 14:35:51 +02:00
Bram Moolenaar
4033c55eca
patch 8.0.1118: FEAT_WINDOWS adds a lot of #ifdefs
...
Problem: FEAT_WINDOWS adds a lot of #ifdefs while it is nearly always
enabled and only adds 7% to the binary size of the tiny build.
Solution: Graduate FEAT_WINDOWS.
2017-09-16 20:54:51 +02:00
Bram Moolenaar
8327d1df17
patch 8.0.0709: libvterm cannot use vsnprintf()
...
Problem: Libvterm cannot use vsnprintf(), it does not exist in C90.
Solution: Use vim_vsnprintf() instead.
2017-07-11 22:34:51 +02:00
Bram Moolenaar
ca24e2cfcf
patch 8.0.0213: Netbeans specialKeys command does not check argument length
...
Problem: The Netbeans "specialKeys" command does not check if the argument
fits in the buffer. (Coverity)
Solution: Add a length check.
2017-01-22 15:19:22 +01:00
Bram Moolenaar
9af4184276
patch 8.0.0012
...
Problem: Typos in comments.
Solution: Change "its" to "it's". (Matthew Brener, closes #1088 )
2016-09-25 21:45:05 +02:00
Bram Moolenaar
edf3f97ae2
patch 7.4.2293
...
Problem: Modelines in source code are inconsistant.
Solution: Use the same line in most files. Add 'noet'. (Naruhiko Nishino)
2016-08-29 22:49:24 +02:00
Bram Moolenaar
2932359000
patch 7.4.2101
...
Problem: Looping over windows, buffers and tab pages is inconsistant.
Solution: Use FOR_ALL_ macros everywhere. (Yegappan Lakshmanan)
2016-07-24 22:04:11 +02:00
Bram Moolenaar
36edf0685c
patch 7.4.2089
...
Problem: Color handling of X11 GUIs is too complicated.
Solution: Simplify the code. Use RGBA where appropriate. (Kazunobu
Kuriyama)
2016-07-21 22:10:12 +02:00