aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-07-26 11:04:33 -04:00
Code
18,651 Commits 1 Branch 18,323 Tags
Commit Graph

558 Commits

Author SHA1 Message Date
Christian Brabandt
ac63787734
patch 9.0.2108: [security]: overflow with count for :s command 
Problem:  [security]: overflow with count for :s command
Solution: Abort the :s command if the count is too large

If the count after the :s command is larger than what fits into a
(signed) long variable, abort with e_value_too_large.

Adds a test with INT_MAX as count and verify it correctly fails.

It seems the return value on Windows using mingw compiler wraps around,
so the initial test using :s/./b/9999999999999999999999999990 doesn't
fail there, since the count is wrapping around several times and finally
is no longer larger than 2147483647. So let's just use 2147483647 in the
test, which hopefully will always cause a failure

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-11-16 22:04:37 +01:00
Christian Brabandt
ee17b6f70d
patch 9.0.1886: Various Typos 
Problem:  Various Typos
Solution: Fix Typos

This is a collection of typo related commits.

closes: #12753
closes: #13016

Co-authored-by: Adri Verhoef <a3@a3.xs4all.nl>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
Co-authored-by: Viktor Szépe <viktor@szepe.net>
Co-authored-by: nuid64 <lvkuzvesov@proton.me>
Co-authored-by: Meng Xiangzhuo <aumo@foxmail.com>
Co-authored-by: Dominique Pellé <dominique.pelle@gmail.com>

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-09 11:31:38 +02:00
Christian Brabandt
f6d28fe2c9
patch 9.0.1873: [security] heap-buffer-overflow in vim_regsub_both 
Problem:  heap-buffer-overflow in vim_regsub_both
Solution: Disallow exchanging windows when textlock is active

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-05 20:18:06 +02:00
Christian Brabandt
c8a034210f
patch 9.0.1849: CI error on different signedness in ex_cmds.c 
Problem:  CI error on different signedness
Solution: cast unsigned to int

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-02 21:50:10 +02:00
Christian Brabandt
ced2c7394a
patch 9.0.1848: [security] buffer-overflow in vim_regsub_both() 
Problem:  buffer-overflow in vim_regsub_both()
Solution: Check remaining space

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-02 21:37:04 +02:00
Christian Brabandt
9d093fd056
patch 9.0.1841: style: trailing whitespace in ex_cmds.c 
Problem:  style: trailing whitespace in ex_cmds.c
Solution: remove it

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-02 15:08:09 +02:00
Christian Brabandt
e1dc9a6275
patch 9.0.1840: [security] use-after-free in do_ecmd 
Problem:  use-after-free in do_ecmd
Solution: Verify oldwin pointer after reset_VIsual()

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-02 14:44:47 +02:00
Bram Moolenaar
79cdf026f1 patch 9.0.1571: RedrawingDisabled not used consistently 
Problem:    RedrawingDisabled not used consistently.
Solution:   Avoid RedrawingDisabled going negative.  Set RedrawingDisabled in
            win_split_ins(). (closes #11961)
 2023-05-20 14:07:00 +01:00
Bram Moolenaar
411da64e77 patch 9.0.1538: :wqall does not trigger ExitPre 
Problem:    :wqall does not trigger ExitPre. (Bart Libert)
Solution:   Move preparations for :qall to a common function. (closes #12374)
 2023-05-10 16:53:27 +01:00
Bram Moolenaar
f39d9e9dca patch 9.0.1479: small source file problems; outdated list of distrib. files 
Problem:    Small source file problems; outdated list of distributed files.
Solution:   Small updates to source files and list of distributed files.
 2023-04-22 22:54:40 +01:00
Bram Moolenaar
5fb78c3fa5 patch 9.0.1380: CTRL-X on 2**64 subtracts two 
Problem:    CTRL-X on 2**64 subtracts two. (James McCoy)
Solution:   Correct computation for large number. (closes #12103)
 2023-03-04 20:47:39 +00:00
Yegappan Lakshmanan
af93691b53 patch 9.0.1330: handling new value of an option has a long "else if" chain 
Problem:    Handling new value of an option has a long "else if" chain.
Solution:   Use a function pointer. (Yegappan Lakshmanan, closes #12015)
 2023-02-20 12:16:39 +00:00
Bram Moolenaar
ebfec1c531 patch 9.0.1234: the code style has to be checked manually 
Problem:    The code style has to be checked manually.
Solution:   Add basic code style checks in a test.  Fix or avoid uncovered
            problems.
 2023-01-22 21:14:53 +00:00
Yegappan Lakshmanan
1cfb14aa97 patch 9.0.1166: code is indented more than necessary 
Problem:    Code is indented more than necessary.
Solution:   Use an early return where it makes sense. (Yegappan Lakshmanan,
            closes #11792)
 2023-01-09 19:04:23 +00:00
Yegappan Lakshmanan
ed0c1d5d4b patch 9.0.1115: code is indented more than needed 
Problem:    Code is indented more than needed.
Solution:   Use an early return to reduce indenting. (Yegappan Lakshmanan,
            closes #11758)
 2022-12-30 18:07:46 +00:00
Rob Pilling
e86190e7c1 patch 9.0.1092: search error message doesn't show used pattern 
Problem:    Search error message doesn't show used pattern.
Solution:   Pass the actually used pattern to where the error message is
            given. (Rob Pilling, closes #11742)
 2022-12-23 19:06:04 +00:00
Bram Moolenaar
6600447c7b patch 9.0.0864: crash when using "!!" without a previous shell command 
Problem:    Crash when using "!!" without a previous shell command.
Solution:   Check "prevcmd" is not NULL. (closes #11487)
 2022-11-12 16:36:35 +00:00
shane.xb.qian
4e7590ec00 patch 9.0.0845: shell command with just space gives strange error 
Problem:    Shell command with just space gives strange error.
Solution:   Skip white space at start of the argument. (Christian Brabandt,
            Shane-XB-Qian, closes #11515, closes #11495)
 2022-11-08 21:40:04 +00:00
Bram Moolenaar
03d6e6f42b patch 9.0.0820: memory leak with empty shell command 
Problem:    Memory leak with empty shell command.
Solution:   Free the empty string.
 2022-10-29 21:53:08 +01:00
Bram Moolenaar
fb0cf2357e patch 9.0.0817 2022-10-22 11:25:19 +01:00
Martin Tournoij
9c50eeb401 patch 9.0.0815 2022-10-22 09:02:56 +01:00
Bram Moolenaar
9652249a2d patch 9.0.0785: memory leak with empty shell command 
Problem:    Memory leak with empty shell command.
Solution:   Free the allocated memory when bailing out.
 2022-10-17 20:00:26 +01:00
Bram Moolenaar
8107a2a8af patch 9.0.0783: ":!" doesn't do anything but does update the previous command 
Problem:    ":!" doesn't do anything but does update the previous command.
Solution:   Do not have ":!" change the previous command. (Martin Tournoij,
            closes #11372)
 2022-10-17 18:00:23 +01:00
Bram Moolenaar
c9121f798f patch 9.0.0751: 'scrolloff' does not work well with 'smoothscroll' 
Problem:    'scrolloff' does not work well with 'smoothscroll'.
Solution:   Make positioning the cursor a bit better.  Rename functions.
 2022-10-14 20:09:04 +01:00
Martin Tournoij
7904fa420e patch 9.0.0657: too many #ifdefs 
Problem:    Too many #ifdefs.
Solution:   Graduate the +cmdwin feature.  Now the tiny and small builds are
            equal, drop the small build.  (Martin Tournoij, closes #11268)
 2022-10-04 16:28:45 +01:00
Yegappan Lakshmanan
0a016671b9 patch 9.0.0648: when using powershell input redirection does not work 
Problem:    When using powershell input redirection does not work.
Solution:   Use a different shell command for powershell. (Yegappan
            Lakshmanan, closes #11257)
 2022-10-03 16:05:28 +01:00
Bram Moolenaar
a2b91036d1 patch 9.0.0506: line number argument for :badd does not work 
Problem:    Line number argument for :badd does not work.
Solution:   Set the last cursor position in the new buffer. (closes #11161)
 2022-09-19 18:20:08 +01:00
Bram Moolenaar
73e28dcc61 patch 9.0.0491: no good reason to build without the float feature 
Problem:    No good reason to build without the float feature.
Solution:   Remove configure check for float and "#ifdef FEAT_FLOAT".
 2022-09-17 21:08:33 +01:00
Bram Moolenaar
d3922afbd6 patch 9.0.0467: build failure 
Problem:    Build failure.
Solution:   Add missing change.
 2022-09-14 22:30:59 +01:00
Bram Moolenaar
a04f457a6c patch 9.0.0457: substitute prompt does not highlight an empty match 
Problem:    Substitute prompt does not highlight an empty match.
Solution:   Highlight at least one character.
 2022-09-13 13:45:26 +01:00
Bram Moolenaar
a2a8973e51 patch 9.0.0340: the 'cmdheight' zero support causes too much trouble 
Problem:    The 'cmdheight' zero support causes too much trouble.
Solution:   Revert support for 'cmdheight' being zero.
 2022-08-31 14:46:18 +01:00
zeertzjq
9c8f94636b patch 9.0.0332: overwrite check may block BufWriteCmd 
Problem:    Overwrite check may block BufWriteCmd.
Solution:   Do not use overwrite check when 'buftype' is "acwrite".
            (closes #11011)
 2022-08-30 18:17:15 +01:00
Bram Moolenaar
13608d851a patch 9.0.0318: clearing screen causes flicker 
Problem:    Clearing screen causes flicker.
Solution:   Do not clear but redraw in more cases.  Add () to "wait_return".
 2022-08-29 15:06:50 +01:00
Bram Moolenaar
309c4e0ed7 patch 9.0.0315: shell command is displayed in message window 
Problem:    Shell command is displayed in message window.
Solution:   Do not echo the shell command in the message window.
 2022-08-29 12:23:39 +01:00
Bram Moolenaar
6d4b2f54df patch 9.0.0263: too many #ifdefs 
Problem:    Too many #ifdefs.
Solution:   Make some functions always available.
 2022-08-25 15:11:15 +01:00
Bram Moolenaar
a4d158b3c8 patch 9.0.0206: redraw flags are not named specifically 
Problem:    Redraw flags are not named specifically.
Solution:   Prefix "UPD_" to the flags, for UPDate_screen().
 2022-08-14 14:17:45 +01:00
Bram Moolenaar
213bbaf15a patch 9.0.0145: substitute that joins lines drops text properties 
Problem:    Substitute that joins lines drops text properties.
Solution:   Move text properties of the last line to the new line.
 2022-08-05 19:46:48 +01:00
Shougo Matsushita
f39cfb7262 patch 9.0.0114: the command line takes up space even when not used 
Problem:    The command line takes up space even when not used.
Solution:   Allow for 'cmdheight' to be set to zero. (Shougo Matsushita,
            closes #10675, closes #940)
 2022-07-30 16:54:05 +01:00
ii14
1f0dc5e84f patch 9.0.0085: ":write" fails after ":file name" and the ":edit" 
Problem:    ":write" fails after ":file name" and the ":edit".
Solution:   Reset BF_NOTEDITED when using ":edit". (closes #10790)
 2022-07-26 19:44:56 +01:00
Bram Moolenaar
32acf1f1a7 patch 9.0.0047: using freed memory with recursive substitute 
Problem:    Using freed memory with recursive substitute.
Solution:   Always make a copy for reg_prev_sub.
 2022-07-07 22:20:31 +01:00
Bram Moolenaar
44ddf19ec0 patch 8.2.5146: memory leak when substitute expression nests 
Problem:    Memory leak when substitute expression nests.
Solution:   Use an array of expression results.
 2022-06-21 22:15:25 +01:00
Paul Ollis
6574577cac patch 8.2.5057: using gettimeofday() for timeout is very inefficient 
Problem:    Using gettimeofday() for timeout is very inefficient.
Solution:   Set a platform dependent timer. (Paul Ollis, closes #10505)
 2022-06-05 16:55:54 +01:00
Bram Moolenaar
4aaf3e7f4d patch 8.2.5046: vim_regsub() can overwrite the destination 
Problem:    vim_regsub() can overwrite the destination.
Solution:   Pass the destination length, give an error when it doesn't fit.
 2022-05-30 20:58:55 +01:00
zeertzjq
cfe456543e patch 8.2.5029: "textlock" is always zero 
Problem:    "textlock" is always zero.
Solution:   Remove "textlock" and rename "textwinlock" to "textlock".
            (closes #10489)
 2022-05-27 17:26:55 +01:00
Bram Moolenaar
e2bd8600b8 patch 8.2.4977: memory access error when substitute expression changes window 
Problem:    Memory access error when substitute expression changes window.
Solution:   Disallow changing window in substitute expression.
 2022-05-18 13:11:57 +01:00
Bram Moolenaar
6ed545e797 patch 8.2.4928: various white space and cosmetic mistakes 
Problem:    Various white space and cosmetic mistakes.
Solution:   Change spaces to tabs, improve comments.
 2022-05-09 20:09:23 +01:00
Bram Moolenaar
249591057b patch 8.2.4911: the mode #defines are not clearly named 
Problem:    The mode #defines are not clearly named.
Solution:   Prepend MODE_.  Renumber them to put the mapped modes first.
 2022-05-07 20:01:16 +01:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
b836658a04 patch 8.2.4750: small pieces of dead code 
Problem:    Small pieces of dead code.
Solution:   Remove the dead code. (Goc Dundar, closes #10190) Rename the
            qftf_cb struct member to avoid confusion.
 2022-04-14 20:43:56 +01:00
zeertzjq
3a56b6d405 patch 8.2.4711: when 'insermode' is set :edit from <Cmd> mapping misbehaves 
Problem:    When 'insermode' is set :edit from <Cmd> mapping misbehaves.
Solution:   Don't set "need_start_insertmode" when already in Insert mode.
            (closes #10116)
 2022-04-08 11:56:14 +01:00
Bram Moolenaar
ce416b453a patch 8.2.4672: using :normal with Ex mode may make :substitute hang 
Problem:    Using :normal with Ex mode may make :substitute hang.
Solution:   When getting an empty line behave like 'q' was typed.
            (closes #10070)
 2022-04-03 12:59:34 +01:00