aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-10-01 04:54:07 -04:00
Code Activity
19,528 Commits 1 Branch 18,547 Tags
031a745608d615d56f9d79bb0f76e2a74b2eaf14
Commit Graph

42 Commits

Author SHA1 Message Date
Keith Thompson
184f71cc68 patch 9.1.0006: is*() and to*() function may be unsafe 
Problem:  is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
          (Keith Thompson)

Use SAFE_() macros for is*() and to*() functions

The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF.  If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.

Solution: Add SAFE_*() macros that cast the argument to unsigned char.

Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.

The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0
(v9.0.2054)

fixes: #13332
closes: #13347

Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-01-04 21:19:04 +01:00
Christian Brabandt
ee17b6f70d patch 9.0.1886: Various Typos 
Problem:  Various Typos
Solution: Fix Typos

This is a collection of typo related commits.

closes: #12753
closes: #13016

Co-authored-by: Adri Verhoef <a3@a3.xs4all.nl>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
Co-authored-by: Viktor Szépe <viktor@szepe.net>
Co-authored-by: nuid64 <lvkuzvesov@proton.me>
Co-authored-by: Meng Xiangzhuo <aumo@foxmail.com>
Co-authored-by: Dominique Pellé <dominique.pelle@gmail.com>

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-09 11:31:38 +02:00
Bram Moolenaar
5145c9a829 patch 9.0.1400: find_file_in_path() is not reentrant 
Problem:    find_file_in_path() is not reentrant.
Solution:   Instead of global variables pass pointers to the functions.
            (closes #12093)
 2023-03-11 13:55:53 +00:00
zeertzjq
1b438a8228 patch 9.0.1271: using sizeof() and subtract array size is tricky 
Problem:    Using sizeof() and subtract array size is tricky.
Solution:   Use offsetof() instead. (closes #11926)
 2023-02-01 13:11:15 +00:00
zeertzjq
3770f4c9cd patch 9.0.1231: completion of :runtime does not handle {where} argument 
Problem:    Completion of :runtime does not handle {where} argument.
Solution:   Parse the {where} argument. (closes #11863)
 2023-01-22 18:38:51 +00:00
Yegappan Lakshmanan
1cfb14aa97 patch 9.0.1166: code is indented more than necessary 
Problem:    Code is indented more than necessary.
Solution:   Use an early return where it makes sense. (Yegappan Lakshmanan,
            closes #11792)
 2023-01-09 19:04:23 +00:00
Yegappan Lakshmanan
7f8b2559a3 patch 9.0.1158: code is indented more than necessary 
Problem:    Code is indented more than necessary.
Solution:   Use an early return where it makes sense. (Yegappan Lakshmanan,
            closes #11787)
 2023-01-08 13:44:24 +00:00
Bram Moolenaar
a4e0b9785e patch 9.0.0634: evaluating "expr" options has more overhead than needed 
Problem:    Evaluating "expr" options has more overhead than needed.
Solution:   Use call_simple_func() for 'foldtext', 'includeexpr', 'printexpr',
            "expr" of 'spellsuggest', 'diffexpr', 'patchexpr', 'balloonexpr',
            'formatexpr', 'indentexpr' and 'charconvert'.
 2022-10-01 19:43:52 +01:00
Bram Moolenaar
747f110420 patch 9.0.0498: various small issues 
Problem:    Various small issues.
Solution:   Various small fixes.
 2022-09-18 13:06:41 +01:00
Bram Moolenaar
2bd9dbc19f patch 9.0.0270: some values of 'path' and 'tags' invalid in the tiny version 
Problem:    Some values of 'path' and 'tags' do not work in the tiny version.
Solution:   Graduate the +path_extra feature.
 2022-08-25 18:12:06 +01:00
Bram Moolenaar
f80f40a55c patch 9.0.0265: no good reason why the "gf" command isn't in the tiny version 
Problem:    No good reason why the "gf" command is not in the tiny version.
Solution:   Graduate the file_in_path feature.
 2022-08-25 16:02:23 +01:00
John Drouhard
95fca12b0e patch 9.0.0126: expanding file names fails in dir with more than 255 entries 
Problem:    Expanding file names fails in directory with more than 255
            entries.
Solution:   Use an int instead of char_u to count. (John Drouhard,
            closes #10818)
 2022-08-01 11:38:17 +01:00
Bram Moolenaar
424bcae1fb patch 8.2.4273: the EBCDIC support is outdated 
Problem:    The EBCDIC support is outdated.
Solution:   Remove the EBCDIC support.
 2022-01-31 14:59:41 +00:00
Bram Moolenaar
47bcc5f4c8 patch 8.2.4184: cannot use an import in 'includeexpr' 
Problem:    Cannot use an import in 'includeexpr'.
Solution:   Set the script context when evaluating 'includeexpr'
 2022-01-22 20:19:22 +00:00
Bram Moolenaar
9530b580a7 patch 8.2.4179: 'foldtext' is evaluated in the current script context 
Problem:    'foldtext' is evaluated in the current script context.
Solution:   Use the script context where the option was set.
 2022-01-22 13:39:08 +00:00
Bram Moolenaar
04935fb17e patch 8.2.4043: using int for second argument of ga_init2() 
Problem:    Using int for second argument of ga_init2().
Solution:   Remove unnessary type cast (int) when using sizeof().
 2022-01-08 16:19:22 +00:00
Bram Moolenaar
9d00e4a814 patch 8.2.4010: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-05 17:49:15 +00:00
Bram Moolenaar
ac78dd4a35 patch 8.2.3985: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-02 19:25:26 +00:00
Bram Moolenaar
eaaac014a0 patch 8.2.3983: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-02 17:00:40 +00:00
Dominique Pelle
af4a61a85d patch 8.2.3914: various spelling mistakes in comments 
Problem:    Various spelling mistakes in comments.
Solution:   Fix the mistakes. (Dominique Pellé, closes #9416)
 2021-12-27 17:21:41 +00:00
Yegappan Lakshmanan
6df0f2759d patch 8.2.3824: no ASAN support for MSVC 
Problem:    No ASAN support for MSVC.
Solution:   Add ASAN support and fix a coupld of uncovered problems. (Yegappan
            Lakshmanan, closes #9357)
 2021-12-16 13:06:10 +00:00
Bram Moolenaar
e015d99abb patch 8.2.3613: :find test fails 
Problem:    :find test fails.
Solution:   Put length check inside if block.
 2021-11-17 19:01:53 +00:00
Bram Moolenaar
615ddd5342 patch 8.2.3611: crash when using CTRL-W f without finding a file name 
Problem:    Crash when using CTRL-W f without finding a file name.
Solution:   Bail out when the file name length is zero.
 2021-11-17 18:00:31 +00:00
Yegappan Lakshmanan
4490ec4e83 patch 8.2.3229: Vim9: runtime and compile time type checks are not the same 
Problem:    Vim9: runtime and compile time type checks are not the same.
Solution:   Add more runtime type checks for builtin functions. (Yegappan
            Lakshmanan, closes #8646)
 2021-07-27 22:00:44 +02:00
Christian Brabandt
7a4ca32175 patch 8.2.3219: :find searches non-existing directories 
Problem:    :find searches non-existing directories.
Solution:   Check the path is not "..".  Update help. (Christian Brabandt,
            closes #8612, closes #8533)
 2021-07-25 15:08:05 +02:00
Bram Moolenaar
3cfa5b16b0 patch 8.2.2949: tests failing because no error for float to string conversion 
Problem:    Tests failing because there is no error for float to string
            conversion.
Solution:   Change the check for failure to check for correct result.  Make
            some conversions strict in Vim9 script.
 2021-06-06 14:14:39 +02:00
Bram Moolenaar
efd5d8a967 patch 8.2.1684: "gF" does not use line number after file in Visual mode 
Problem:    "gF" does not use line number after file in Visual mode.
Solution:   Look for ":123" after the Visual area. (closes #6952)
 2020-09-14 19:11:45 +02:00
Bram Moolenaar
b171fb1790 patch 8.2.1049: Vim9: leaking memory when using continuation line 
Problem:    Vim9: leaking memory when using continuation line.
Solution:   Keep a pointer to the continuation line in evalarg_T.  Centralize
            checking for a next command.
 2020-06-24 20:34:03 +02:00
Bram Moolenaar
fdcbe3c3fe patch 8.2.0985: simplify() does not remove slashes from "///path" 
Problem:    Simplify() does not remove slashes from "///path".
Solution:   Reduce > 2 slashes to one. (closes #6263)
 2020-06-15 21:41:56 +02:00
Bram Moolenaar
71ccd03ee8 patch 8.2.0967: unnecessary type casts for vim_strnsave() 
Problem:    Unnecessary type casts for vim_strnsave().
Solution:   Remove the type casts.
 2020-06-12 22:59:11 +02:00
Bram Moolenaar
a80faa8930 patch 8.2.0559: clearing a struct is verbose 
Problem:    Clearing a struct is verbose.
Solution:   Define and use CLEAR_FIELD() and CLEAR_POINTER().
 2020-04-12 19:37:17 +02:00
Bram Moolenaar
64e74c9cc7 patch 8.2.0030: "gF" does not work on output of "verbose command" 
Problem:    "gF" does not work on output of "verbose command".
Solution:   Recognize " line " and translations. (closes #5391)
 2019-12-22 15:38:06 +01:00
Bram Moolenaar
217e1b8359 patch 8.1.2379: using old C style comments 
Problem:    Using old C style comments.
Solution:   Use // comments where appropriate.
 2019-12-01 21:41:28 +01:00
Bram Moolenaar
1614a14901 patch 8.1.2120: some MB_ macros are more complicated than necessary 
Problem:    Some MB_ macros are more complicated than necessary. (Dominique
            Pelle)
Solution:   Simplify the macros.  Expand inline.
 2019-10-06 22:00:13 +02:00
Bram Moolenaar
b005cd80cf patch 8.1.1979: code for handling file names is spread out 
Problem:    Code for handling file names is spread out.
Solution:   Move code to new filepath.c file.  Graduate FEAT_MODIFY_FNAME.
 2019-09-04 15:54:55 +02:00
Bram Moolenaar
5843f5f37b patch 8.1.1891: functions used in one file are global 
Problem:    Functions used in one file are global.
Solution:   Add "static". (Yegappan Lakshmanan, closes #4840)
 2019-08-20 20:13:45 +02:00
Bram Moolenaar
c799fe206e patch 8.1.1414: alloc() returning "char_u *" causes a lot of type casts 
Problem:    Alloc() returning "char_u *" causes a lot of type casts.
Solution:   Have it return "void *". (Mike Williams)  Define ALLOC_ONE() to
            check the simple allocations.
 2019-05-28 23:08:19 +02:00
Bram Moolenaar
51e14387f1 patch 8.1.1393: unnecessary type casts 
Problem:    Unnecessary type casts.
Solution:   Remove type casts from alloc() and lalloc() calls. (Mike Williams)
 2019-05-25 20:21:28 +02:00
Bram Moolenaar
964b3746b9 patch 8.1.1384: using "int" for alloc() often results in compiler warnings 
Problem:    Using "int" for alloc() often results in compiler warnings.
Solution:   Use "size_t" and remove type casts.  Remove alloc_check(), Vim
            only works with 32 bit ints anyway.
 2019-05-24 18:54:09 +02:00
Bram Moolenaar
b4a6020ac6 patch 8.1.1099: the do_tag() function is too long 
Problem:    The do_tag() function is too long.
Solution:   Factor parts out to separate functions.  Move simplify_filename()
            to a file where it fits better. (Andy Massimino, closes #4195)
 2019-03-31 19:40:07 +02:00
Bram Moolenaar
cbef8e1aa1 patch 8.1.1002: "gf" does not always work when URL has a port number 
Problem:    "gf" does not always work when URL has a port number. (Jakob
            Schöttl)
Solution:   When a URL is recognized also accept ":". (closes #4082)
 2019-03-09 12:32:56 +01:00
Bram Moolenaar
5fd0f5052f patch 8.1.0914: code related to findfile() is spread out 
Problem:    Code related to findfile() is spread out.
Solution:   Put findfile() related code into a new source file. (Yegappan
            Lakshmanan, closes #3934)
 2019-02-13 23:13:28 +01:00