0
0
mirror of https://github.com/vim/vim.git synced 2025-09-24 03:44:06 -04:00

patch 9.0.1508: catch does not work when lines are joined with a newline

Problem:    Catch does not work when lines are joined with a newline.
Solution:   Set "nextcmd" appropriately. (closes #12348)
This commit is contained in:
zeertzjq
2023-05-05 17:22:35 +01:00
committed by Bram Moolenaar
parent 53f5e51628
commit f2588b6fc9
3 changed files with 41 additions and 6 deletions

View File

@@ -2699,12 +2699,15 @@ eval0_retarg(
semsg(_(e_invalid_expression_str), arg);
}
// Some of the expression may not have been consumed. Do not check for
// a next command to avoid more errors, unless "|" is following, which
// could only be a command separator.
if (eap != NULL && p != NULL
&& skipwhite(p)[0] == '|' && skipwhite(p)[1] != '|')
eap->nextcmd = check_nextcmd(p);
if (eap != NULL && p != NULL)
{
// Some of the expression may not have been consumed.
// Only execute a next command if it cannot be a "||" operator.
// The next command may be "catch".
char_u *nextcmd = check_nextcmd(p);
if (nextcmd != NULL && *nextcmd != '|')
eap->nextcmd = nextcmd;
}
return FAIL;
}

View File

@@ -2220,6 +2220,36 @@ func Test_BufEnter_exception()
%bwipe!
endfunc
" Test for using try/catch when lines are joined by "|" or "\n" {{{1
func Test_try_catch_nextcmd()
func Throw()
throw "Failure"
endfunc
let lines =<< trim END
try
let s:x = Throw()
catch
let g:caught = 1
endtry
END
let g:caught = 0
call execute(lines)
call assert_equal(1, g:caught)
let g:caught = 0
call execute(join(lines, '|'))
call assert_equal(1, g:caught)
let g:caught = 0
call execute(join(lines, "\n"))
call assert_equal(1, g:caught)
unlet g:caught
delfunc Throw
endfunc
" Test for using try/catch in a user command with a failing expression {{{1
func Test_user_command_try_catch()
let lines =<< trim END

View File

@@ -695,6 +695,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1508,
/**/
1507,
/**/