aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-10-16 07:24:23 -04:00
Code Activity

patch 9.1.1851: memory leak in heredoc_get()

Browse Source 
Problem:  memory leak in heredoc_get()
Solution: Free "str" if list_append_string() fails
          (Lidong Yan).

In heredoc_get(), eval_all_expr_in_str() allocates a new string and
assign it to local variable "str". When list_append_string() failed
the memory pointed to by "str" leaks. Free "str" if list_append_string()
failed.

related: #18533

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Lidong Yan
2025-10-12 15:05:11 +00:00
committed by Christian Brabandt
parent da2dabc6f7
commit dc75a204f1
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/evalvars.c
View File

@@ -968,7 +968,11 @@ heredoc_get(exarg_T *eap, char_u *cmd, int script_get, int vim9compile)
} }
if (list_append_string(l, str, -1) == FAIL) if (list_append_string(l, str, -1) == FAIL)
{
if (free_str)
vim_free(str);
break; break;
}
if (free_str) if (free_str)
vim_free(str); vim_free(str);
} }

2
src/version.c
View File

@@ -729,6 +729,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
1851,
/**/ /**/
1850, 1850,
/**/ /**/