patch 8.2.5018: Vim9: some code is not covered by tests

Problem:    Vim9: some code is not covered by tests.
Solution:   Delete dead code.

src/proto/vim9instr.pro

@@ -32,7 +32,7 @@ int generate_STORE(cctx_T *cctx, isntype_T isn_type, int idx, char_u *name);
 int generate_STORENR(cctx_T *cctx, int idx, varnumber_T value);
 int generate_LOAD(cctx_T *cctx, isntype_T isn_type, int idx, char_u *name, type_T *type);
 int generate_LOADOUTER(cctx_T *cctx, int idx, int nesting, type_T *type);
-int generate_LOADV(cctx_T *cctx, char_u *name, int error);
+int generate_LOADV(cctx_T *cctx, char_u *name);
 int generate_UNLET(cctx_T *cctx, isntype_T isn_type, char_u *name, int forceit);
 int generate_LOCKCONST(cctx_T *cctx);
 int generate_OLDSCRIPT(cctx_T *cctx, isntype_T isn_type, char_u *name, int sid, type_T *type);

src/version.c

@@ -734,6 +734,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    5018,
 /**/
     5017,
 /**/

src/vim9compile.c

@@ -1151,7 +1151,7 @@ generate_loadvar(
 	    generate_LOAD(cctx, ISN_LOADREG, name[1], NULL, &t_string);
 	    break;
 	case dest_vimvar:
-	    generate_LOADV(cctx, name + 2, TRUE);
+	    generate_LOADV(cctx, name + 2);
 	    break;
 	case dest_local:
 	    if (lvar->lv_from_outer > 0)

src/vim9expr.c

@@ -442,7 +442,7 @@ compile_load(
 
 	    switch (**arg)
 	    {
-		case 'v': res = generate_LOADV(cctx, name, error);
+		case 'v': res = generate_LOADV(cctx, name);
 			  break;
 		case 's': if (current_script_is_vim9())
 			  {

src/vim9instr.c

@@ -355,11 +355,6 @@ get_compare_isn(
     vartype_T	vartype1 = tv1 != NULL ? tv1->v_type : type1->tt_type;
     vartype_T	vartype2 = tv2 != NULL ? tv2->v_type : type2->tt_type;
 
-    if (vartype1 == VAR_UNKNOWN)
-	vartype1 = VAR_ANY;
-    if (vartype2 == VAR_UNKNOWN)
-	vartype2 = VAR_ANY;
-
     if (vartype1 == vartype2)
     {
 	switch (vartype1)
@@ -462,11 +457,8 @@ generate_COMPARE(cctx_T *cctx, exprtype_T exprtype, int ic)
     isn->isn_arg.op.op_ic = ic;
 
     // takes two arguments, puts one bool back
-    if (stack->ga_len >= 2)
-    {
     --stack->ga_len;
     set_type_on_stack(cctx, &t_bool, 0);
-    }
 
     return OK;
 }
@@ -485,9 +477,6 @@ generate_CONCAT(cctx_T *cctx, int count)
 
     RETURN_OK_IF_SKIP(cctx);
 
-    if (count < 1)
-	return FAIL;
-
     if ((isn = generate_instr(cctx, ISN_CONCAT)) == NULL)
 	return FAIL;
     isn->isn_arg.number = count;
@@ -578,17 +567,12 @@ generate_SETTYPE(
 /*
  * Generate a PUSH instruction for "tv".
  * "tv" will be consumed or cleared.
- * Nothing happens if "tv" is NULL or of type VAR_UNKNOWN;
  */
     int
 generate_tv_PUSH(cctx_T *cctx, typval_T *tv)
 {
-    if (tv != NULL)
-    {
     switch (tv->v_type)
     {
-	    case VAR_UNKNOWN:
-		break;
 	case VAR_BOOL:
 	    generate_PUSHBOOL(cctx, tv->vval.v_number);
 	    break;
@@ -646,12 +630,11 @@ generate_tv_PUSH(cctx_T *cctx, typval_T *tv)
 	    tv->vval.v_string = NULL;
 	    break;
 	default:
-		iemsg("constant type not supported");
+	    siemsg("constant type %d not supported", tv->v_type);
 	    clear_tv(tv);
 	    return FAIL;
     }
     tv->v_type = VAR_UNKNOWN;
-    }
     return OK;
 }
 
@@ -735,22 +718,21 @@ generate_PUSHF(cctx_T *cctx, float_T fnumber)
 generate_PUSHS(cctx_T *cctx, char_u **str)
 {
     isn_T	*isn;
+    int		ret = OK;
 
-    if (cctx->ctx_skip == SKIP_YES)
+    if (cctx->ctx_skip != SKIP_YES)
     {
-	if (str != NULL)
-	    VIM_CLEAR(*str);
-	return OK;
-    }
 	if ((isn = generate_instr_type(cctx, ISN_PUSHS, &t_string)) == NULL)
+	    ret = FAIL;
+	else
 	{
+	    isn->isn_arg.string = str == NULL ? NULL : *str;
+	    return OK;
+	}
+    }
     if (str != NULL)
 	VIM_CLEAR(*str);
-	return FAIL;
+    return ret;
-    }
-    isn->isn_arg.string = str == NULL ? NULL : *str;
-
-    return OK;
 }
 
 /*
@@ -864,6 +846,7 @@ generate_AUTOLOAD(cctx_T *cctx, char_u *name, type_T *type)
  * Generate an ISN_GETITEM instruction with "index".
  * "with_op" is TRUE for "+=" and other operators, the stack has the current
  * value below the list with values.
+ * Caller must check the type is a list.
  */
     int
 generate_GETITEM(cctx_T *cctx, int index, int with_op)
@@ -874,12 +857,6 @@ generate_GETITEM(cctx_T *cctx, int index, int with_op)
 
     RETURN_OK_IF_SKIP(cctx);
 
-    if (type->tt_type != VAR_LIST)
-    {
-	// cannot happen, caller has checked the type
-	emsg(_(e_list_required));
-	return FAIL;
-    }
     item_type = type->tt_member;
     if ((isn = generate_instr(cctx, ISN_GETITEM)) == NULL)
 	return FAIL;
@@ -1048,8 +1025,7 @@ generate_LOADOUTER(
     int
 generate_LOADV(
 	cctx_T	    *cctx,
-	char_u	    *name,
+	char_u	    *name)
-	int	    error)
 {
     int	    di_flags;
     int	    vidx = find_vim_var(name, &di_flags);
@@ -1058,7 +1034,6 @@ generate_LOADV(
     RETURN_OK_IF_SKIP(cctx);
     if (vidx < 0)
     {
-	if (error)
 	semsg(_(e_variable_not_found_str), name);
 	return FAIL;
     }
@@ -1258,23 +1233,22 @@ generate_FUNCREF(cctx_T *cctx, ufunc_T *ufunc, isn_T **isnp)
 generate_NEWFUNC(cctx_T *cctx, char_u *lambda_name, char_u *func_name)
 {
     isn_T	*isn;
+    int		ret = OK;
 
-    if (cctx->ctx_skip == SKIP_YES)
+    if (cctx->ctx_skip != SKIP_YES)
     {
-	vim_free(lambda_name);
-	vim_free(func_name);
-	return OK;
-    }
 	if ((isn = generate_instr(cctx, ISN_NEWFUNC)) == NULL)
+	    ret = FAIL;
+	else
 	{
-	vim_free(lambda_name);
-	vim_free(func_name);
-	return FAIL;
-    }
 	    isn->isn_arg.newfunc.nf_lambda = lambda_name;
 	    isn->isn_arg.newfunc.nf_global = func_name;
-
 	    return OK;
+	}
+    }
+    vim_free(lambda_name);
+    vim_free(func_name);
+    return ret;
 }
 
 /*
@@ -1827,19 +1801,20 @@ generate_EXEC_copy(cctx_T *cctx, isntype_T isntype, char_u *line)
 generate_EXEC(cctx_T *cctx, isntype_T isntype, char_u *str)
 {
     isn_T	*isn;
+    int		ret = OK;
 
-    if (cctx->ctx_skip == SKIP_YES)
+    if (cctx->ctx_skip != SKIP_YES)
     {
-	vim_free(str);
-	return OK;
-    }
 	if ((isn = generate_instr(cctx, isntype)) == NULL)
+	    ret = FAIL;
+	else
 	{
-	vim_free(str);
-	return FAIL;
-    }
 	    isn->isn_arg.string = str;
 	    return OK;
+	}
+    }
+    vim_free(str);
+    return ret;
 }
 
     int