0
0
mirror of https://github.com/vim/vim.git synced 2025-09-23 03:43:49 -04:00

patch 9.1.1107: cannot loop through completion menu with fuzzy

Problem:  cannot loop through completion menu with fuzzy and nosort in
          'completeopt'
          (Tomasz N)
Solution: Reset cur to zero and update compl_shown_match when
          'completeopt' contains "nosort" but not "noselect"
          (glepnir)

fixes: #16624
closes: #16629

Signed-off-by: glepnir <glephunter@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
glepnir
2025-02-13 20:27:44 +01:00
committed by Christian Brabandt
parent 4f010c90bd
commit c0b7ca406b
3 changed files with 28 additions and 2 deletions

View File

@@ -1367,8 +1367,6 @@ ins_compl_build_pum(void)
if (!compl_no_select) if (!compl_no_select)
compl_shown_match = compl; compl_shown_match = compl;
} }
else if (!fuzzy_sort && i == 0 && !compl_no_select)
compl_shown_match = shown_compl;
if (!shown_match_ok && compl == compl_shown_match && !compl_no_select) if (!shown_match_ok && compl == compl_shown_match && !compl_no_select)
{ {
@@ -1402,6 +1400,13 @@ ins_compl_build_pum(void)
if (compl_match_arraysize == 0) if (compl_match_arraysize == 0)
return -1; return -1;
if (fuzzy_filter && !fuzzy_sort && !compl_no_select && !shown_match_ok)
{
compl_shown_match = shown_compl;
shown_match_ok = TRUE;
cur = 0;
}
compl_match_array = ALLOC_CLEAR_MULT(pumitem_T, compl_match_arraysize); compl_match_array = ALLOC_CLEAR_MULT(pumitem_T, compl_match_arraysize);
if (compl_match_array == NULL) if (compl_match_array == NULL)
return -1; return -1;

View File

@@ -2689,6 +2689,8 @@ func Test_complete_fuzzy_match()
func OnPumChange() func OnPumChange()
let g:item = get(v:event, 'completed_item', {}) let g:item = get(v:event, 'completed_item', {})
let g:word = get(g:item, 'word', v:null) let g:word = get(g:item, 'word', v:null)
let g:abbr = get(g:item, 'abbr', v:null)
let g:selected = get(complete_info(['selected']), 'selected')
endfunction endfunction
augroup AAAAA_Group augroup AAAAA_Group
@@ -2875,6 +2877,20 @@ func Test_complete_fuzzy_match()
call feedkeys("S\<C-x>\<C-o>fooB\<C-Y>", 'tx') call feedkeys("S\<C-x>\<C-o>fooB\<C-Y>", 'tx')
call assert_equal('fooBaz', getline('.')) call assert_equal('fooBaz', getline('.'))
set cot=menuone,fuzzy,nosort
func CompAnother()
call complete(col('.'), [#{word: "do" }, #{word: "echo"}, #{word: "for (${1:expr1}, ${2:expr2}, ${3:expr3}) {\n\t$0\n}", abbr: "for" }, #{word: "foo"}])
return ''
endfunc
call feedkeys("i\<C-R>=CompAnother()\<CR>\<C-N>\<C-N>", 'tx')
call assert_equal("for", g:abbr)
call assert_equal(2, g:selected)
set cot+=noinsert
call feedkeys("i\<C-R>=CompAnother()\<CR>f", 'tx')
call assert_equal("for", g:abbr)
call assert_equal(2, g:selected)
" clean up " clean up
set omnifunc= set omnifunc=
bw! bw!
@@ -2885,8 +2901,11 @@ func Test_complete_fuzzy_match()
delfunc OnPumChange delfunc OnPumChange
delfunc Omni_test delfunc Omni_test
delfunc Comp delfunc Comp
delfunc CompAnother
unlet g:item unlet g:item
unlet g:word unlet g:word
unlet g:selected
unlet g:abbr
endfunc endfunc
func Test_complete_fuzzy_with_completeslash() func Test_complete_fuzzy_with_completeslash()

View File

@@ -704,6 +704,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
1107,
/**/ /**/
1106, 1106,
/**/ /**/