aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-27 04:14:06 -04:00
Code Activity

patch 8.1.0886: compiler warning for NULL pointer and condition always true

Browse Source 
Problem:    Compiler warning for adding to NULL pointer and a condition that
            is always true.
Solution:   Check for NULL pointer before adding. Remove useless "if".
            (Friedirch, closes #3913)
This commit is contained in:
Bram Moolenaar
2019-02-10 21:48:25 +01:00
parent 18c5632cab
commit b763361161
3 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/dosinst.c
View File

@@ -291,16 +291,17 @@ findoldfile(char **destination)
{
char *bp = *destination;
size_t indir_l = strlen(installdir);
char *cp = bp + indir_l;
char *cp;
char *tmpname;
char *farname;
/*
* No action needed if exe not found or not in this directory.
*/
if (bp == NULL
|| strnicmp(bp, installdir, indir_l) != 0
|| strchr("/\\", *cp++) == NULL
if (bp == NULL || strnicmp(bp, installdir, indir_l) != 0)
return;
cp = bp + indir_l;
if (strchr("/\\", *cp++) == NULL
|| strchr(cp, '\\') != NULL
|| strchr(cp, '/') != NULL)
return;