aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-07-26 11:04:33 -04:00
Code

patch 8.0.1078: using freed memory with ":hi Normal"

Browse Source 
Problem:    Using freed memory with ":hi Normal".
Solution:   Get "item" again after updating the table.
This commit is contained in:
Bram Moolenaar 2017-09-09 15:28:14 +02:00
parent fe386641b0
commit b4ea1914b8
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/syntax.c
View File

@ -7380,6 +7380,9 @@ do_highlight(
#else #else
# define is_menu_group 0 # define is_menu_group 0
# define is_tooltip_group 0 # define is_tooltip_group 0
#endif
#if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS)
int did_highlight_changed = FALSE;
#endif #endif
/* /*
@ -7568,8 +7571,9 @@ do_highlight(
#if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS) #if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS)
if (USE_24BIT) if (USE_24BIT)
highlight_gui_started(); highlight_gui_started();
else
#endif #endif
highlight_changed(); highlight_changed();
redraw_later_clear(); redraw_later_clear();
return; return;
} }
@ -8174,7 +8178,12 @@ do_highlight(
#endif #endif
#if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS) #if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS)
if (USE_24BIT) if (USE_24BIT)
{
highlight_gui_started(); highlight_gui_started();
item = &HL_TABLE()[idx]; /* table may have changed */
did_highlight_changed = TRUE;
redraw_all_later(NOT_VALID);
}
#endif #endif
} }
#ifdef FEAT_GUI_X11 #ifdef FEAT_GUI_X11
@ -8210,7 +8219,11 @@ do_highlight(
/* Only call highlight_changed() once, after a sequence of highlight /* Only call highlight_changed() once, after a sequence of highlight
* commands, and only if an attribute actually changed. */ * commands, and only if an attribute actually changed. */
if (memcmp(item, &item_before, sizeof(item_before)) != 0) if (memcmp(item, &item_before, sizeof(item_before)) != 0
#if defined(FEAT_GUI) || defined(FEAT_TERMGUICOLORS)
&& !did_highlight_changed
#endif
)
{ {
redraw_all_later(NOT_VALID); redraw_all_later(NOT_VALID);
need_highlight_changed = TRUE; need_highlight_changed = TRUE;

2
src/version.c
View File

@ -769,6 +769,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
1078,
/**/ /**/
1077, 1077,
/**/ /**/