aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-27 04:14:06 -04:00
Code Activity

patch 8.2.3511: Vim9: entry for loop variable is created every round

Browse Source 
Problem:    Vim9: entry for loop variable is created every round.
Solution:   Only create the entry once. (closes #8996)
This commit is contained in:
Bram Moolenaar
2021-10-15 00:18:37 +01:00
parent 0a7984af56
commit a06758dd38
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/evalvars.c
View File

@@ -3319,7 +3319,7 @@ set_var_const(
goto failed; goto failed;
} }
if (var_in_vim9script) if (var_in_vim9script && (flags & ASSIGN_FOR_LOOP) == 0)
{ {
where_T where = WHERE_INIT; where_T where = WHERE_INIT;
@@ -3331,7 +3331,8 @@ set_var_const(
goto failed; goto failed;
} }
if (var_check_permission(di, name) == FAIL) if ((flags & ASSIGN_FOR_LOOP) == 0
&& var_check_permission(di, name) == FAIL)
goto failed; goto failed;
} }
else else

2
src/version.c
View File

@@ -757,6 +757,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
3511,
/**/ /**/
3510, 3510,
/**/ /**/

5
src/vim9script.c
View File

@@ -978,8 +978,9 @@ find_typval_in_script(typval_T *dest)
// legacy script doesn't store variable types // legacy script doesn't store variable types
return NULL; return NULL;
// Find the svar_T in sn_var_vals. // Find the svar_T in sn_var_vals. Start at the end, in a for loop the
for (idx = 0; idx < si->sn_var_vals.ga_len; ++idx) // variable was added at the end.
for (idx = si->sn_var_vals.ga_len - 1; idx >= 0; --idx)
{ {
svar_T *sv = ((svar_T *)si->sn_var_vals.ga_data) + idx; svar_T *sv = ((svar_T *)si->sn_var_vals.ga_data) + idx;