aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-26 04:04:07 -04:00
Code Activity

patch 8.2.1712: Vim9: leaking memory when calling a lambda

Browse Source 
Problem:    Vim9: leaking memory when calling a lambda.
Solution:   Decrement function reference from ISN_DCALL.
This commit is contained in:
Bram Moolenaar
2020-09-19 18:19:19 +02:00
parent fdeab65db6
commit a05e524f3a
4 changed files with 31 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/userfunc.c
View File

@@ -1058,7 +1058,7 @@ cleanup_function_call(funccall_T *fc)
* using function() does not count as a reference, because the function is
* looked up by name.
*/
static int
int
func_name_refcount(char_u *name)
{
return isdigit(*name) || *name == '<';
@@ -1176,8 +1176,9 @@ func_clear(ufunc_T *fp, int force)
* Free a function and remove it from the list of functions. Does not free
* what a function contains, call func_clear() first.
* When "force" is TRUE we are exiting.
* Returns OK when the function was actually freed.
*/
static void
static int
func_free(ufunc_T *fp, int force)
{
// Only remove it when not done already, otherwise we would remove a newer
@@ -1191,7 +1192,9 @@ func_free(ufunc_T *fp, int force)
unlink_def_function(fp);
VIM_CLEAR(fp->uf_name_exp);
vim_free(fp);
return OK;
}
return FAIL;
}
/*
@@ -1890,9 +1893,13 @@ free_all_functions(void)
++skipped;
else
{
func_free(fp, FALSE);
skipped = 0;
break;
if (func_free(fp, FALSE) == OK)
{
skipped = 0;
break;
}
// did not actually free it
++skipped;
}
}
}