From 58ceca5cae75ed839b20a89c5fa9998f02552f58 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Tue, 28 Jan 2020 22:46:22 +0100 Subject: [PATCH] patch 8.2.0167: Coverity warning for ignoring return value Problem: Coverity warning for ignoring return value. Solution: Check the return value and jump if failed. --- src/testdir/test_vim9_expr.vim | 2 ++ src/version.c | 2 ++ src/vim9execute.c | 3 ++- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim index ea79c04572..321dbf95ab 100644 --- a/src/testdir/test_vim9_expr.vim +++ b/src/testdir/test_vim9_expr.vim @@ -687,6 +687,8 @@ func Test_expr7_fails() call CheckDefFailure("let x = @", "E1002:") call CheckDefFailure("let x = @<", "E354:") + + call CheckDefFailure("let x = ¬exist", "E113:") endfunc let g:Funcrefs = [function('add')] diff --git a/src/version.c b/src/version.c index d5108d9787..c6259bc9f5 100644 --- a/src/version.c +++ b/src/version.c @@ -742,6 +742,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 167, /**/ 166, /**/ diff --git a/src/vim9execute.c b/src/vim9execute.c index 001d274110..6865ba1e24 100644 --- a/src/vim9execute.c +++ b/src/vim9execute.c @@ -556,7 +556,8 @@ call_def_function( if (ga_grow(&ectx.ec_stack, 1) == FAIL) goto failed; - get_option_tv(&name, &optval, TRUE); + if (get_option_tv(&name, &optval, TRUE) == FAIL) + goto failed; *STACK_TV_BOT(0) = optval; ++ectx.ec_stack.ga_len; }