0
0
mirror of https://github.com/vim/vim.git synced 2025-09-23 03:43:49 -04:00

updated for version 7.3.083

Problem:    When a read() or write() is interrupted by a signal it fails.
Solution:   Add read_eintr() and write_eintr().
This commit is contained in:
Bram Moolenaar
2010-12-17 16:27:16 +01:00
parent 45d9d02d71
commit 540fc6fbdb
8 changed files with 76 additions and 23 deletions

View File

@@ -918,7 +918,7 @@ readfile(fname, sfname, from, lines_to_skip, lines_to_read, eap, flags)
{ {
/* Read the first line (and a bit more). Immediately rewind to /* Read the first line (and a bit more). Immediately rewind to
* the start of the file. If the read() fails "len" is -1. */ * the start of the file. If the read() fails "len" is -1. */
len = vim_read(fd, firstline, 80); len = read_eintr(fd, firstline, 80);
lseek(fd, (off_t)0L, SEEK_SET); lseek(fd, (off_t)0L, SEEK_SET);
for (p = firstline; p < firstline + len; ++p) for (p = firstline; p < firstline + len; ++p)
if (*p >= 0x80) if (*p >= 0x80)
@@ -1373,7 +1373,7 @@ retry:
/* /*
* Read bytes from the file. * Read bytes from the file.
*/ */
size = vim_read(fd, ptr, size); size = read_eintr(fd, ptr, size);
} }
if (size <= 0) if (size <= 0)
@@ -4000,7 +4000,7 @@ buf_write(buf, fname, sfname, start, end, eap, append, forceit,
#ifdef HAS_BW_FLAGS #ifdef HAS_BW_FLAGS
write_info.bw_flags = FIO_NOCONVERT; write_info.bw_flags = FIO_NOCONVERT;
#endif #endif
while ((write_info.bw_len = vim_read(fd, copybuf, while ((write_info.bw_len = read_eintr(fd, copybuf,
BUFSIZE)) > 0) BUFSIZE)) > 0)
{ {
if (buf_write_bytes(&write_info) == FAIL) if (buf_write_bytes(&write_info) == FAIL)
@@ -4813,7 +4813,7 @@ restore_backup:
#ifdef HAS_BW_FLAGS #ifdef HAS_BW_FLAGS
write_info.bw_flags = FIO_NOCONVERT; write_info.bw_flags = FIO_NOCONVERT;
#endif #endif
while ((write_info.bw_len = vim_read(fd, smallbuf, while ((write_info.bw_len = read_eintr(fd, smallbuf,
SMBUFSIZE)) > 0) SMBUFSIZE)) > 0)
if (buf_write_bytes(&write_info) == FAIL) if (buf_write_bytes(&write_info) == FAIL)
break; break;
@@ -5330,7 +5330,7 @@ time_differs(t1, t2)
/* /*
* Call write() to write a number of bytes to the file. * Call write() to write a number of bytes to the file.
* Also handles encryption and 'encoding' conversion. * Handles encryption and 'encoding' conversion.
* *
* Return FAIL for failure, OK otherwise. * Return FAIL for failure, OK otherwise.
*/ */
@@ -5702,16 +5702,8 @@ buf_write_bytes(ip)
crypt_encode(buf, len, buf); crypt_encode(buf, len, buf);
#endif #endif
/* Repeat the write(), it may be interrupted by a signal. */ wlen = write_eintr(ip->bw_fd, buf, len);
while (len > 0) return (wlen < len) ? FAIL : OK;
{
wlen = vim_write(ip->bw_fd, buf, len);
if (wlen <= 0) /* error! */
return FAIL;
len -= wlen;
buf += wlen;
}
return OK;
} }
#ifdef FEAT_MBYTE #ifdef FEAT_MBYTE
@@ -6662,8 +6654,8 @@ vim_rename(from, to)
return -1; return -1;
} }
while ((n = vim_read(fd_in, buffer, BUFSIZE)) > 0) while ((n = read_eintr(fd_in, buffer, BUFSIZE)) > 0)
if (vim_write(fd_out, buffer, n) != n) if (write_eintr(fd_out, buffer, n) != n)
{ {
errmsg = _("E208: Error writing to \"%s\""); errmsg = _("E208: Error writing to \"%s\"");
break; break;
@@ -10304,3 +10296,55 @@ file_pat_to_reg_pat(pat, pat_end, allow_dirs, no_bslash)
} }
return reg_pat; return reg_pat;
} }
#if defined(EINTR) || defined(PROTO)
/*
* Version of read() that retries when interrupted by EINTR (possibly
* by a SIGWINCH).
*/
long
read_eintr(fd, buf, bufsize)
int fd;
void *buf;
size_t bufsize;
{
long ret;
for (;;)
{
ret = vim_read(fd, buf, bufsize);
if (ret >= 0 || errno != EINTR)
break;
}
return ret;
}
/*
* Version of write() that retries when interrupted by EINTR (possibly
* by a SIGWINCH).
*/
long
write_eintr(fd, buf, bufsize)
int fd;
void *buf;
size_t bufsize;
{
long ret = 0;
long wlen;
/* Repeat the write() so long it didn't fail, other than being interrupted
* by a signal. */
while (ret < (long)bufsize)
{
wlen = vim_write(fd, buf + ret, bufsize - ret);
if (wlen < 0)
{
if (errno != EINTR)
break;
}
else
ret += wlen;
}
return ret;
}
#endif

View File

@@ -1049,7 +1049,7 @@ mf_read(mfp, hp)
PERROR(_("E294: Seek error in swap file read")); PERROR(_("E294: Seek error in swap file read"));
return FAIL; return FAIL;
} }
if ((unsigned)vim_read(mfp->mf_fd, hp->bh_data, size) != size) if ((unsigned)read_eintr(mfp->mf_fd, hp->bh_data, size) != size)
{ {
PERROR(_("E295: Read error in swap file")); PERROR(_("E295: Read error in swap file"));
return FAIL; return FAIL;
@@ -1168,7 +1168,7 @@ mf_write_block(mfp, hp, offset, size)
} }
#endif #endif
if ((unsigned)vim_write(mfp->mf_fd, data, size) != size) if ((unsigned)write_eintr(mfp->mf_fd, data, size) != size)
result = FAIL; result = FAIL;
#ifdef FEAT_CRYPT #ifdef FEAT_CRYPT

View File

@@ -2062,7 +2062,7 @@ swapfile_info(fname)
fd = mch_open((char *)fname, O_RDONLY | O_EXTRA, 0); fd = mch_open((char *)fname, O_RDONLY | O_EXTRA, 0);
if (fd >= 0) if (fd >= 0)
{ {
if (read(fd, (char *)&b0, sizeof(b0)) == sizeof(b0)) if (read_eintr(fd, &b0, sizeof(b0)) == sizeof(b0))
{ {
if (STRNCMP(b0.b0_version, "VIM 3.0", 7) == 0) if (STRNCMP(b0.b0_version, "VIM 3.0", 7) == 0)
{ {
@@ -4392,7 +4392,7 @@ findswapname(buf, dirp, old_fname)
fd = mch_open((char *)fname, O_RDONLY | O_EXTRA, 0); fd = mch_open((char *)fname, O_RDONLY | O_EXTRA, 0);
if (fd >= 0) if (fd >= 0)
{ {
if (read(fd, (char *)&b0, sizeof(b0)) == sizeof(b0)) if (read_eintr(fd, &b0, sizeof(b0)) == sizeof(b0))
{ {
/* /*
* If the swapfile has the same directory as the * If the swapfile has the same directory as the

View File

@@ -4454,7 +4454,7 @@ mch_call_shell(cmd, options)
++noread_cnt; ++noread_cnt;
while (RealWaitForChar(fromshell_fd, 10L, NULL)) while (RealWaitForChar(fromshell_fd, 10L, NULL))
{ {
len = read(fromshell_fd, (char *)buffer len = read_eintr(fromshell_fd, buffer
# ifdef FEAT_MBYTE # ifdef FEAT_MBYTE
+ buffer_off, (size_t)(BUFLEN - buffer_off) + buffer_off, (size_t)(BUFLEN - buffer_off)
# else # else

View File

@@ -54,4 +54,6 @@ int au_exists __ARGS((char_u *arg));
int match_file_pat __ARGS((char_u *pattern, regprog_T *prog, char_u *fname, char_u *sfname, char_u *tail, int allow_dirs)); int match_file_pat __ARGS((char_u *pattern, regprog_T *prog, char_u *fname, char_u *sfname, char_u *tail, int allow_dirs));
int match_file_list __ARGS((char_u *list, char_u *sfname, char_u *ffname)); int match_file_list __ARGS((char_u *list, char_u *sfname, char_u *ffname));
char_u *file_pat_to_reg_pat __ARGS((char_u *pat, char_u *pat_end, char *allow_dirs, int no_bslash)); char_u *file_pat_to_reg_pat __ARGS((char_u *pat, char_u *pat_end, char *allow_dirs, int no_bslash));
long read_eintr __ARGS((int fd, void *buf, size_t bufsize));
long write_eintr __ARGS((int fd, void *buf, size_t bufsize));
/* vim: set ft=c : */ /* vim: set ft=c : */

View File

@@ -1386,7 +1386,7 @@ u_write_undo(name, forceit, buf, hash)
char_u mbuf[UF_START_MAGIC_LEN]; char_u mbuf[UF_START_MAGIC_LEN];
int len; int len;
len = vim_read(fd, mbuf, UF_START_MAGIC_LEN); len = read_eintr(fd, mbuf, UF_START_MAGIC_LEN);
close(fd); close(fd);
if (len < UF_START_MAGIC_LEN if (len < UF_START_MAGIC_LEN
|| memcmp(mbuf, UF_START_MAGIC, UF_START_MAGIC_LEN) != 0) || memcmp(mbuf, UF_START_MAGIC, UF_START_MAGIC_LEN) != 0)

View File

@@ -714,6 +714,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
83,
/**/ /**/
82, 82,
/**/ /**/

View File

@@ -1642,6 +1642,11 @@ int vim_memcmp __ARGS((void *, void *, size_t));
# define USE_INPUT_BUF # define USE_INPUT_BUF
#endif #endif
#ifndef EINTR
# define read_eintr(fd, buf, count) vim_read((fd), (buf), (count))
# define write_eintr(fd, buf, count) vim_write((fd), (buf), (count))
#endif
#ifdef MSWIN #ifdef MSWIN
/* On MS-Windows the third argument isn't size_t. This matters for Win64, /* On MS-Windows the third argument isn't size_t. This matters for Win64,
* where sizeof(size_t)==8, not 4 */ * where sizeof(size_t)==8, not 4 */