aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-23 03:43:49 -04:00
Code Activity

patch 9.1.0439: Cannot filter the history

Browse Source 
Problem:  Cannot filter the history
Solution: Implement :filter :history

closes: #14835

Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Christian Brabandt
2024-05-24 07:39:34 +02:00
parent 3074137542
commit 42a5b5a6d0
4 changed files with 60 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
runtime/doc/various.txt
View File

@@ -1,4 +1,4 @@
*various.txt* For Vim version 9.1. Last change: 2023 Sep 27
*various.txt* For Vim version 9.1. Last change: 2024 May 23
VIM REFERENCE MANUAL by Bram Moolenaar
@@ -608,6 +608,7 @@ N *+X11* Unix only: can restore window title |X11|
|:command| - filter by command name
|:files| - filter by file name
|:highlight| - filter by highlight group
|:history| - filter by history commands
|:jumps| - filter by file name
|:let| - filter by variable name
|:list| - filter whole line

3
src/cmdhist.c
View File

@@ -767,7 +767,8 @@ ex_history(exarg_T *eap)
if (i == hislen)
i = 0;
if (hist[i].hisstr != NULL
&& hist[i].hisnum >= j && hist[i].hisnum <= k)
&& hist[i].hisnum >= j && hist[i].hisnum <= k
&& !message_filtered(hist[i].hisstr))
{
msg_putchar('\n');
sprintf((char *)IObuff, "%c%6d ", i == idx ? '>' : ' ',

54
src/testdir/test_history.vim
View File

@@ -96,6 +96,60 @@ function Test_History()
call assert_fails('history xyz', 'E488:')
call assert_fails('history ,abc', 'E488:')
call assert_fails('call histdel(":", "\\%(")', 'E53:')
" Test for filtering the history list
let hist_filter = execute(':filter /_\d/ :history all')->split('\n')
call assert_equal(20, len(hist_filter))
let expected = [' # cmd history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # search history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # expr history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # input history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # debug history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4']
call assert_equal(expected, hist_filter)
let cmds = {'c': 'cmd', 's': 'search', 'e': 'expr', 'i': 'input', 'd': 'debug'}
for h in sort(keys(cmds))
" find some items
let hist_filter = execute(':filter /_\d/ :history ' .. h)->split('\n')
call assert_equal(4, len(hist_filter))
let expected = [' # ' .. cmds[h] .. ' history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4']
call assert_equal(expected, hist_filter)
" Search for an item that is not there
let hist_filter = execute(':filter /XXXX/ :history ' .. h)->split('\n')
call assert_equal(1, len(hist_filter))
let expected = [' # ' .. cmds[h] .. ' history']
call assert_equal(expected, hist_filter)
" Invert the filter condition, find non-matches
let hist_filter = execute(':filter! /_3$/ :history ' .. h)->split('\n')
call assert_equal(3, len(hist_filter))
let expected = [' # ' .. cmds[h] .. ' history',
\ ' 2 text_2',
\ '> 4 text_4']
call assert_equal(expected, hist_filter)
endfor
endfunction
function Test_history_truncates_long_entry()

2
src/version.c
View File

@@ -704,6 +704,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
439,
/**/
438,
/**/