0
0
mirror of https://github.com/vim/vim.git synced 2025-10-04 05:25:06 -04:00

patch 8.2.4879: screendump test may fail when using valgrind

Problem:    Screendump test may fail when using valgrind.
Solution:   Wait longer for the first screendump.
This commit is contained in:
Bram Moolenaar
2022-05-06 11:21:19 +01:00
parent dd7eff0a75
commit 3e79427803
3 changed files with 9 additions and 3 deletions

View File

@@ -15,15 +15,18 @@ endif
" Verify that Vim running in terminal buffer "buf" matches the screen dump.
" "options" is passed to term_dumpwrite().
" Additionally, the "wait" entry can specify the maximum time to wait for the
" screen dump to match in msec (default 1000 msec).
" The file name used is "dumps/{filename}.dump".
" Optionally an extra argument can be passed which is prepended to the error
" message. Use this when using the same dump file with different options.
" Will wait for up to a second for the screen dump to match.
" Returns non-zero when verification fails.
func VerifyScreenDump(buf, filename, options, ...)
let reference = 'dumps/' . a:filename . '.dump'
let testfile = 'failed/' . a:filename . '.dump'
let max_loops = get(a:options, 'wait', 1000) / 10
" Starting a terminal to make a screendump is always considered flaky.
let g:test_is_flaky = 1
@@ -60,7 +63,7 @@ func VerifyScreenDump(buf, filename, options, ...)
endif
break
endif
if i == 100
if i == max_loops
" Leave the failed dump around for inspection.
if filereadable(reference)
let msg = 'See dump file difference: call term_dumpdiff("testdir/' .. testfile .. '", "testdir/' .. reference .. '")'

View File

@@ -4552,7 +4552,8 @@ func Test_win_gotoid_in_mapping()
END
call writefile(lines, 'Xgotoscript')
let buf = RunVimInTerminal('-S Xgotoscript', #{rows: 15, wait_for_ruler: 0})
call VerifyScreenDump(buf, 'Test_win_gotoid_1', {})
" wait longer here, since we didn't wait for the ruler
call VerifyScreenDump(buf, 'Test_win_gotoid_1', #{wait: 3000})
call term_sendkeys(buf, "3Gvl")
call VerifyScreenDump(buf, 'Test_win_gotoid_2', {})

View File

@@ -746,6 +746,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
4879,
/**/
4878,
/**/