mirror of
https://github.com/vim/vim.git
synced 2025-09-25 03:54:15 -04:00
patch 8.2.3644: count for 'operatorfunc' in Visual mode is not redone
Problem: Count for 'operatorfunc' in Visual mode is not redone. Solution: Add the count to the redo buffer. (closes #9174)
This commit is contained in:
26
src/normal.c
26
src/normal.c
@@ -380,8 +380,10 @@ static const struct nv_cmd
|
|||||||
// Number of commands in nv_cmds[].
|
// Number of commands in nv_cmds[].
|
||||||
#define NV_CMDS_SIZE ARRAY_LENGTH(nv_cmds)
|
#define NV_CMDS_SIZE ARRAY_LENGTH(nv_cmds)
|
||||||
|
|
||||||
|
#ifndef PROTO // cproto doesn't like this
|
||||||
// Sorted index of commands in nv_cmds[].
|
// Sorted index of commands in nv_cmds[].
|
||||||
static short nv_cmd_idx[NV_CMDS_SIZE];
|
static short nv_cmd_idx[NV_CMDS_SIZE];
|
||||||
|
#endif
|
||||||
|
|
||||||
// The highest index for which
|
// The highest index for which
|
||||||
// nv_cmds[idx].cmd_char == nv_cmd_idx[nv_cmds[idx].cmd_char]
|
// nv_cmds[idx].cmd_char == nv_cmd_idx[nv_cmds[idx].cmd_char]
|
||||||
@@ -1696,6 +1698,23 @@ prep_redo(
|
|||||||
int cmd3,
|
int cmd3,
|
||||||
int cmd4,
|
int cmd4,
|
||||||
int cmd5)
|
int cmd5)
|
||||||
|
{
|
||||||
|
prep_redo_num2(regname, num, cmd1, cmd2, 0L, cmd3, cmd4, cmd5);
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Prepare for redo of any command with extra count after "cmd2".
|
||||||
|
*/
|
||||||
|
void
|
||||||
|
prep_redo_num2(
|
||||||
|
int regname,
|
||||||
|
long num1,
|
||||||
|
int cmd1,
|
||||||
|
int cmd2,
|
||||||
|
long num2,
|
||||||
|
int cmd3,
|
||||||
|
int cmd4,
|
||||||
|
int cmd5)
|
||||||
{
|
{
|
||||||
ResetRedobuff();
|
ResetRedobuff();
|
||||||
if (regname != 0) // yank from specified buffer
|
if (regname != 0) // yank from specified buffer
|
||||||
@@ -1703,13 +1722,14 @@ prep_redo(
|
|||||||
AppendCharToRedobuff('"');
|
AppendCharToRedobuff('"');
|
||||||
AppendCharToRedobuff(regname);
|
AppendCharToRedobuff(regname);
|
||||||
}
|
}
|
||||||
if (num)
|
if (num1 != 0)
|
||||||
AppendNumberToRedobuff(num);
|
AppendNumberToRedobuff(num1);
|
||||||
|
|
||||||
if (cmd1 != NUL)
|
if (cmd1 != NUL)
|
||||||
AppendCharToRedobuff(cmd1);
|
AppendCharToRedobuff(cmd1);
|
||||||
if (cmd2 != NUL)
|
if (cmd2 != NUL)
|
||||||
AppendCharToRedobuff(cmd2);
|
AppendCharToRedobuff(cmd2);
|
||||||
|
if (num2 != 0)
|
||||||
|
AppendNumberToRedobuff(num2);
|
||||||
if (cmd3 != NUL)
|
if (cmd3 != NUL)
|
||||||
AppendCharToRedobuff(cmd3);
|
AppendCharToRedobuff(cmd3);
|
||||||
if (cmd4 != NUL)
|
if (cmd4 != NUL)
|
||||||
|
14
src/ops.c
14
src/ops.c
@@ -3764,6 +3764,8 @@ do_pending_operator(cmdarg_T *cap, int old_col, int gui_yank)
|
|||||||
oap->motion_force, cap->cmdchar, cap->nchar);
|
oap->motion_force, cap->cmdchar, cap->nchar);
|
||||||
else if (cap->cmdchar != ':' && cap->cmdchar != K_COMMAND)
|
else if (cap->cmdchar != ':' && cap->cmdchar != K_COMMAND)
|
||||||
{
|
{
|
||||||
|
int opchar = get_op_char(oap->op_type);
|
||||||
|
int extra_opchar = get_extra_op_char(oap->op_type);
|
||||||
int nchar = oap->op_type == OP_REPLACE ? cap->nchar : NUL;
|
int nchar = oap->op_type == OP_REPLACE ? cap->nchar : NUL;
|
||||||
|
|
||||||
// reverse what nv_replace() did
|
// reverse what nv_replace() did
|
||||||
@@ -3771,10 +3773,14 @@ do_pending_operator(cmdarg_T *cap, int old_col, int gui_yank)
|
|||||||
nchar = CAR;
|
nchar = CAR;
|
||||||
else if (nchar == REPLACE_NL_NCHAR)
|
else if (nchar == REPLACE_NL_NCHAR)
|
||||||
nchar = NL;
|
nchar = NL;
|
||||||
prep_redo(oap->regname, 0L, NUL, 'v',
|
|
||||||
get_op_char(oap->op_type),
|
if (opchar == 'g' && extra_opchar == '@')
|
||||||
get_extra_op_char(oap->op_type),
|
// also repeat the count for 'operatorfunc'
|
||||||
nchar);
|
prep_redo_num2(oap->regname, 0L, NUL, 'v',
|
||||||
|
cap->count0, opchar, extra_opchar, nchar);
|
||||||
|
else
|
||||||
|
prep_redo(oap->regname, 0L, NUL, 'v',
|
||||||
|
opchar, extra_opchar, nchar);
|
||||||
}
|
}
|
||||||
if (!redo_VIsual_busy)
|
if (!redo_VIsual_busy)
|
||||||
{
|
{
|
||||||
|
@@ -10,6 +10,7 @@ void restore_visual_mode(void);
|
|||||||
int find_ident_under_cursor(char_u **text, int find_type);
|
int find_ident_under_cursor(char_u **text, int find_type);
|
||||||
int find_ident_at_pos(win_T *wp, linenr_T lnum, colnr_T startcol, char_u **text, int *textcol, int find_type);
|
int find_ident_at_pos(win_T *wp, linenr_T lnum, colnr_T startcol, char_u **text, int *textcol, int find_type);
|
||||||
void prep_redo(int regname, long num, int cmd1, int cmd2, int cmd3, int cmd4, int cmd5);
|
void prep_redo(int regname, long num, int cmd1, int cmd2, int cmd3, int cmd4, int cmd5);
|
||||||
|
void prep_redo_num2(int regname, long num1, int cmd1, int cmd2, long num2, int cmd3, int cmd4, int cmd5);
|
||||||
void clearop(oparg_T *oap);
|
void clearop(oparg_T *oap);
|
||||||
void clearopbeep(oparg_T *oap);
|
void clearopbeep(oparg_T *oap);
|
||||||
void may_clear_cmdline(void);
|
void may_clear_cmdline(void);
|
||||||
|
@@ -363,7 +363,7 @@ func Test_normal08_fold()
|
|||||||
bw!
|
bw!
|
||||||
endfunc
|
endfunc
|
||||||
|
|
||||||
func Test_normal09_operatorfunc()
|
func Test_normal09a_operatorfunc()
|
||||||
" Test operatorfunc
|
" Test operatorfunc
|
||||||
call Setup_NewWindow()
|
call Setup_NewWindow()
|
||||||
" Add some spaces for counting
|
" Add some spaces for counting
|
||||||
@@ -457,7 +457,7 @@ func Test_normal09_operatorfunc()
|
|||||||
bw!
|
bw!
|
||||||
endfunc
|
endfunc
|
||||||
|
|
||||||
func Test_normal09a_operatorfunc()
|
func Test_normal09b_operatorfunc()
|
||||||
" Test operatorfunc
|
" Test operatorfunc
|
||||||
call Setup_NewWindow()
|
call Setup_NewWindow()
|
||||||
" Add some spaces for counting
|
" Add some spaces for counting
|
||||||
@@ -484,6 +484,26 @@ func Test_normal09a_operatorfunc()
|
|||||||
unlet! g:opt
|
unlet! g:opt
|
||||||
endfunc
|
endfunc
|
||||||
|
|
||||||
|
func OperatorfuncRedo(_)
|
||||||
|
let g:opfunc_count = v:count
|
||||||
|
endfunc
|
||||||
|
|
||||||
|
func Test_normal09c_operatorfunc()
|
||||||
|
" Test redoing operatorfunc
|
||||||
|
new
|
||||||
|
call setline(1, 'some text')
|
||||||
|
set operatorfunc=OperatorfuncRedo
|
||||||
|
normal v3g@
|
||||||
|
call assert_equal(3, g:opfunc_count)
|
||||||
|
let g:opfunc_count = 0
|
||||||
|
normal .
|
||||||
|
call assert_equal(3, g:opfunc_count)
|
||||||
|
|
||||||
|
bw!
|
||||||
|
unlet g:opfunc_count
|
||||||
|
set operatorfunc=
|
||||||
|
endfunc
|
||||||
|
|
||||||
func Test_normal10_expand()
|
func Test_normal10_expand()
|
||||||
" Test for expand()
|
" Test for expand()
|
||||||
10new
|
10new
|
||||||
|
@@ -757,6 +757,8 @@ static char *(features[]) =
|
|||||||
|
|
||||||
static int included_patches[] =
|
static int included_patches[] =
|
||||||
{ /* Add new patch number below this line */
|
{ /* Add new patch number below this line */
|
||||||
|
/**/
|
||||||
|
3644,
|
||||||
/**/
|
/**/
|
||||||
3643,
|
3643,
|
||||||
/**/
|
/**/
|
||||||
|
Reference in New Issue
Block a user