0
0
mirror of https://github.com/vim/vim.git synced 2025-09-23 03:43:49 -04:00

patch 8.0.0220: completion of highlight names misses a few values

Problem:    Completion for :match does not show "none" and other missing
            highlight names.
Solution:   Skip over cleared entries before checking the index to be at the
            end.
This commit is contained in:
Bram Moolenaar
2017-01-22 19:25:33 +01:00
parent 7a40ea2138
commit 15eedf1d62
3 changed files with 36 additions and 7 deletions

View File

@@ -9956,6 +9956,13 @@ highlight_list_two(int cnt, int attr)
char_u * char_u *
get_highlight_name(expand_T *xp UNUSED, int idx) get_highlight_name(expand_T *xp UNUSED, int idx)
{ {
if (idx < 0)
return NULL;
/* Items are never removed from the table, skip the ones that were cleared.
*/
while (idx < highlight_ga.ga_len && HL_TABLE()[idx].sg_cleared)
++idx;
#ifdef FEAT_CMDL_COMPL #ifdef FEAT_CMDL_COMPL
if (idx == highlight_ga.ga_len && include_none != 0) if (idx == highlight_ga.ga_len && include_none != 0)
return (char_u *)"none"; return (char_u *)"none";
@@ -9968,12 +9975,6 @@ get_highlight_name(expand_T *xp UNUSED, int idx)
&& include_link != 0) && include_link != 0)
return (char_u *)"clear"; return (char_u *)"clear";
#endif #endif
if (idx < 0)
return NULL;
/* Items are never removed from the table, skip the ones that were cleared.
*/
while (idx < highlight_ga.ga_len && HL_TABLE()[idx].sg_cleared)
++idx;
if (idx >= highlight_ga.ga_len) if (idx >= highlight_ga.ga_len)
return NULL; return NULL;
return HL_TABLE()[idx].sg_name; return HL_TABLE()[idx].sg_name;

View File

@@ -25,8 +25,34 @@ func Test_complete_wildmenu()
set nowildmenu set nowildmenu
endfunc endfunc
func Test_match_completion()
if !has('cmdline_compl')
return
endif
hi Aardig ctermfg=green
call feedkeys(":match \<Tab>\<Home>\"\<CR>", 'xt')
call assert_equal('"match Aardig', getreg(':'))
call feedkeys(":match \<S-Tab>\<Home>\"\<CR>", 'xt')
call assert_equal('"match none', getreg(':'))
endfunc
func Test_highlight_completion()
if !has('cmdline_compl')
return
endif
hi Aardig ctermfg=green
call feedkeys(":hi \<Tab>\<Home>\"\<CR>", 'xt')
call assert_equal('"hi Aardig', getreg(':'))
call feedkeys(":hi li\<S-Tab>\<Home>\"\<CR>", 'xt')
call assert_equal('"hi link', getreg(':'))
call feedkeys(":hi d\<S-Tab>\<Home>\"\<CR>", 'xt')
call assert_equal('"hi default', getreg(':'))
call feedkeys(":hi c\<S-Tab>\<Home>\"\<CR>", 'xt')
call assert_equal('"hi clear', getreg(':'))
endfunc
func Test_expr_completion() func Test_expr_completion()
if !(has('cmdline_compl') && has('eval')) if !has('cmdline_compl')
return return
endif endif
for cmd in [ for cmd in [

View File

@@ -764,6 +764,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
220,
/**/ /**/
219, 219,
/**/ /**/