From 11ab02c819449eaeddc3d8d291f06bc73f428e91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ph=E1=BA=A1m=20B=C3=ACnh=20An?= Date: Tue, 18 Mar 2025 21:05:35 +0100 Subject: [PATCH] runtime(go): use :term for keywordprg for nvim/gvim MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: - The document from `go doc` can be very long, and you can scroll if using `!` to run shell command in Gvim. - I realize that I didn't fully mimic behavior of default keywordprg in Nvim in the last commit. Solution: - Use builtin terminal for keywordprg in Gvim - In Nvim (both TUI and GUI), it should mimic the behavior of Vim `:term`, `:Man`, and `:help` closes: #16911 Co-authored-by: zeertzjq Signed-off-by: Phạm Bình An Signed-off-by: Christian Brabandt --- runtime/ftplugin/go.vim | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/runtime/ftplugin/go.vim b/runtime/ftplugin/go.vim index b83db424bd..57fc73cd13 100644 --- a/runtime/ftplugin/go.vim +++ b/runtime/ftplugin/go.vim @@ -1,9 +1,10 @@ " Vim filetype plugin file " Language: Go -" Maintainer: David Barnett (https://github.com/google/vim-ft-go) +" Maintainer: David Barnett (https://github.com/google/vim-ft-go is archived) " Last Change: 2014 Aug 16 " 2024 Jul 16 by Vim Project (add recommended indent style) " 2025 Mar 07 by Vim Project (add formatprg and keywordprg option #16804) +" 2025 Mar 18 by Vim Project (use :term for 'keywordprg' #16911) if exists('b:did_ftplugin') finish @@ -33,10 +34,8 @@ if !exists('*' .. expand('') .. 'GoKeywordPrg') setl iskeyword+=. try let cmd = 'go doc -C ' . shellescape(expand('%:h')) . ' ' . shellescape(expand('')) - if has('nvim') - exe "term" cmd - startinsert - tmap call jobstop(&channel) bdelete + if has('gui_running') || has('nvim') + exe 'hor term' cmd else exe '!' . cmd endif