aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-10-24 08:54:47 -04:00
Code Activity

patch 9.1.1387: memory leak when buflist_new() fails to reuse curbuf

Browse Source 
Problem:  buflist_new() leaks ffname and fails to reuse curbuf when
          autocommands from buf_freeall change curbuf. Plus, a new
          buffer is not allocated in this case, despite what the comment
          above claims.
Solution: Remove the condition so ffname is not leaked and so a new
          buffer is allocated like before v8.2.4791. It should not be
          possible for undo_ftplugin or buf_freeall autocommands to
          delete the buffer as they set b_locked, but to stay consistent
          with other uses of buf_freeall, guard against that anyway
          (Sean Dewar).

Note that buf is set to NULL if it was deleted to guard against the (rare)
possibility of messing up the "buf != curbuf" condition below if a new buffer
happens to be allocated at the same address.

closes: #17319

Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
Sean Dewar
2025-05-14 20:16:52 +02:00
committed by Christian Brabandt
parent c952fd1b24
commit 0077282c82
3 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/buffer.c
View File

@@ -2220,13 +2220,14 @@ buflist_new(
buf = NULL;
if ((flags & BLN_CURBUF) && curbuf_reusable())
{
bufref_T bufref;
buf = curbuf;
set_bufref(&bufref, buf);
trigger_undo_ftplugin(buf, curwin);
// It's like this buffer is deleted. Watch out for autocommands that
// change curbuf! If that happens, allocate a new buffer anyway.
buf_freeall(buf, BFA_WIPE | BFA_DEL);
if (buf != curbuf) // autocommands deleted the buffer!
return NULL;
#ifdef FEAT_EVAL
if (aborting()) // autocmds may abort script processing
{
@@ -2234,6 +2235,8 @@ buflist_new(
return NULL;
}
#endif
if (!bufref_valid(&bufref))
buf = NULL; // buf was deleted; allocate a new buffer
}
if (buf != curbuf || curbuf == NULL)
{