diff --git a/src/buffer.c b/src/buffer.c index b4481b2f13..49ec77c7b1 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -2220,13 +2220,14 @@ buflist_new( buf = NULL; if ((flags & BLN_CURBUF) && curbuf_reusable()) { + bufref_T bufref; + buf = curbuf; + set_bufref(&bufref, buf); trigger_undo_ftplugin(buf, curwin); // It's like this buffer is deleted. Watch out for autocommands that // change curbuf! If that happens, allocate a new buffer anyway. buf_freeall(buf, BFA_WIPE | BFA_DEL); - if (buf != curbuf) // autocommands deleted the buffer! - return NULL; #ifdef FEAT_EVAL if (aborting()) // autocmds may abort script processing { @@ -2234,6 +2235,8 @@ buflist_new( return NULL; } #endif + if (!bufref_valid(&bufref)) + buf = NULL; // buf was deleted; allocate a new buffer } if (buf != curbuf || curbuf == NULL) { diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim index db5558304d..26f7145652 100644 --- a/src/testdir/test_autocmd.vim +++ b/src/testdir/test_autocmd.vim @@ -5390,4 +5390,29 @@ func Test_eventignorewin_non_current() %bw! endfunc +func Test_reuse_curbuf_leak() + new bar + let s:bar_buf = bufnr() + augroup testing + autocmd! + autocmd BufDelete * ++once let s:triggered = 1 | execute s:bar_buf 'buffer' + augroup END + enew + let empty_buf = bufnr() + + " Old curbuf should be reused, firing BufDelete. As BufDelete changes curbuf, + " reusing the buffer would fail and leak the ffname. + edit foo + call assert_equal(1, s:triggered) + " Wasn't reused because the buffer changed, but buffer "foo" is still created. + call assert_equal(1, bufexists(empty_buf)) + call assert_notequal(empty_buf, bufnr()) + call assert_equal('foo', bufname()) + call assert_equal('bar', bufname(s:bar_buf)) + + unlet! s:bar_buf s:triggered + call CleanUpTestAuGroup() + %bw! +endfunc + " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c index 78a6e7b7c0..7e6e862de6 100644 --- a/src/version.c +++ b/src/version.c @@ -704,6 +704,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1387, /**/ 1386, /**/