From fe5b9d1a46a89b45b200e3bfe3844f36c22d805a Mon Sep 17 00:00:00 2001 From: Daniel Schwarz Date: Tue, 13 Dec 2022 12:45:07 -0500 Subject: [PATCH] React properly to 422: Validation Failed. Status has already been taken errors --- toot/api.py | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/toot/api.py b/toot/api.py index 1ce1ec0..2e44b12 100644 --- a/toot/api.py +++ b/toot/api.py @@ -6,7 +6,7 @@ import uuid from urllib.parse import urlparse, urlencode, quote from toot import http, CLIENT_NAME, CLIENT_WEBSITE -from toot.exceptions import AuthenticationError +from toot.exceptions import AuthenticationError, ApiError from toot.utils import str_bool SCOPES = 'read write follow' @@ -23,6 +23,24 @@ def _status_action(app, user, status_id, action): return http.post(app, user, url).json() +def _status_toggle_action(app, user, status_id, action): + url = '/api/v1/statuses/{}/{}'.format(status_id, action) + + try: + response = http.post(app, user, url).json() + except ApiError as e: + # For "toggle" operations, Mastodon returns unhelpful + # 422: "Validation failed: Status has already been taken" + # responses when you try to bookmark a status already + # bookmarked, or favourite a status already favourited + # so we just swallow those errors here + if str(e) == "Validation failed: Status has already been taken": + response = None + else: + # not the error we expected; re-raise the exception + raise e + finally: + return response def create_app(domain, scheme='https'): url = '{}://{}/api/v1/apps'.format(scheme, domain) @@ -180,38 +198,40 @@ def delete_status(app, user, status_id): def favourite(app, user, status_id): - return _status_action(app, user, status_id, 'favourite') + return _status_toggle_action(app, user, status_id, 'favourite') def unfavourite(app, user, status_id): - return _status_action(app, user, status_id, 'unfavourite') + return _status_toggle_action(app, user, status_id, 'unfavourite') def reblog(app, user, status_id): - return _status_action(app, user, status_id, 'reblog') + return _status_toggle_action(app, user, status_id, 'reblog') def unreblog(app, user, status_id): - return _status_action(app, user, status_id, 'unreblog') + return _status_toggle_action(app, user, status_id, 'unreblog') def pin(app, user, status_id): - return _status_action(app, user, status_id, 'pin') + return _status_toggle_action(app, user, status_id, 'pin') def unpin(app, user, status_id): - return _status_action(app, user, status_id, 'unpin') + return _status_toggle_action(app, user, status_id, 'unpin') def bookmark(app, user, status_id): - return _status_action(app, user, status_id, 'bookmark') + return _status_toggle_action(app, user, status_id, 'bookmark') def unbookmark(app, user, status_id): - return _status_action(app, user, status_id, 'unbookmark') + return _status_toggle_action(app, user, status_id, 'unbookmark') def translate(app, user, status_id): + # don't use status_toggle_action for translate as this is + # not toggling anything server-side; it's a read only operation. return _status_action(app, user, status_id, 'translate')